- 07 Apr, 2022 1 commit
-
-
Milad Fa authored
Port 9ca0bfef Original Commit Message: This adds feedback collection to count the number of executions of call_direct instructions in Liftoff code. The purpose is better inlining decisions in Turbofan, which are enabled by having call count information for all kinds of calls. The new feature is gated on --wasm-speculative-inlining. While direct calls don't need to speculate about their target, the whole feedback collection infrastructure depends on that flag. R=jkummerow@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Id94a8a00e00877213b017d1ccf06ae0ea988539b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3576126Reviewed-by: Joran Siu <joransiu@ca.ibm.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#79862}
-
- 28 Mar, 2022 1 commit
-
-
Junliang Yan authored
Change-Id: Ife52b4279aa17e73316a77c5b4ef6f03bef763b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3555886Reviewed-by: Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#79641}
-
- 22 Mar, 2022 1 commit
-
-
Junliang Yan authored
Drive-by: fix compilation error Change-Id: I418cd6d6aaff4bf21c86db39a300bc41240c27d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3542987Reviewed-by: Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#79559}
-
- 15 Mar, 2022 1 commit
-
-
Milad Fa authored
Port 8a0d1b6f Original Commit Message: Modernise the RegList interface to be a proper class, rather than a typedef to an integer, and add proper methods onto it rather than ad-hoc bit manipulation. In particular, this makes RegList typesafe, adding a DoubleRegList for DoubleRegisters. The Arm64 CPURegList isn't updated to use (or extend) the new RegList interface, because of its weird type-erasing semantics (it can store Registers and VRegisters). Maybe in the future we'll want to get rid of CPURegList entirely and use RegList/DoubleRegList directly. R=leszeks@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I997156fe4f4f2ccc40b2631d5cb752efdc8a5ad2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3525084Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#79484}
-
- 10 Dec, 2021 1 commit
-
-
Milad Fa authored
Currently atomic ops on TF are using machine native byte order and cannot be used by Wasm calls. This Cl adds support for Little Endian enforced Wasm atomic ops to PPC/AIX by reversing bytes where needed. Change-Id: I4080f318022eedd2058e51d09595753eab385441 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3327721Reviewed-by: Vasili Skurydzin <vasili.skurydzin@ibm.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#78339}
-
- 02 Dec, 2021 1 commit
-
-
Igor Sheludko authored
... as a prerequisite for adding InstructionStream heap object. Bug: v8:11880 Change-Id: I22b4832cedd46bee4a4c5a0d7b5032eba10b2a7b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310900Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#78204}
-
- 23 Nov, 2021 1 commit
-
-
Milad Fa authored
This CL optimizes ByteReverse 16/32/64 ops on PPC<10 as well as PPC_10_PLUS. A 32bit sign extension is also added to `ByteRev32` in codegen. Change-Id: I6379ac4222f3574ab226971546238142039fe977 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3298308 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#78048}
-
- 12 Nov, 2021 1 commit
-
-
Milad Fa authored
Change-Id: Iff669f6272e2a95d5150108d5a3a77e903afbeb9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3275568Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77874}
-
- 10 Nov, 2021 1 commit
-
-
Vasili Skurydzin authored
Change-Id: Ic868b6f9bb17bb9d6e6fe2a7203a41383aef5cf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3272206Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Vasili Skurydzin <vasili.skurydzin@ibm.com> Cr-Commit-Position: refs/heads/main@{#77823}
-
- 01 Nov, 2021 1 commit
-
-
Milad Fa authored
Port: 89933af6 Bug: v8:11112 Change-Id: I59d5cf363e427e7e5157be8c9eb033a11614fad1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3251587Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77630}
-
- 20 Oct, 2021 1 commit
-
-
Milad Fa authored
Port e127f584 Original Commit Message: Handling of class constructors was moved from CallFunction to Call in [1]. When reducing calls with spread we forward varargs directly to CallFunction, if we are spreading to inlined arguments or arguments of the outermost function. In that case we didn't check for class constructors and therefore didn't raise an exception. This CL adds checks for class constructors to all JSCall* nodes in JSCallReducer that missed them before. [1] https://crrev.com/c/3186434 R=pthier@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I02cba90369354f064201daa1bf8812e17cb2dc21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3234040Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77480}
-
- 30 Sep, 2021 1 commit
-
-
Milad Fa authored
Port b9a6301e Original Commit Message: Load instance type into a register instead of using memory operands for several checks on ia32 and x64. R=pthier@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I05ea2bd32ea2a2053b601323813c580d55094e46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3198130Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77179}
-
- 24 Sep, 2021 1 commit
-
-
Junliang Yan authored
Port a0ace8a8 Original Message: In Liftoff, the result of table.grow was smi-untagged and sign-extended to a ptr-sized value. However the result is typed as i32, so the upper 32 bits should be cleared on 64 bit platforms. In particular this is observable when the value is used as an index for a memory operand, which leads to the repro in the attached issue. Match the TF behavior by untagging the value as a 32-bit int. Change-Id: I73ee1d29b830eae1fd4e680634b78317b04c069c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183160Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#77058}
-
- 22 Sep, 2021 4 commits
-
-
Junliang Yan authored
Change-Id: I91ed4bf22231c6080b2c5e445ea407d076baeadc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3175374Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76994}
-
Junliang Yan authored
Change-Id: I01c4a68377a70cfed425b3cd1ed56b120c9b5056 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3174627Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76992}
-
Junliang Yan authored
Change-Id: I83611a53426efff35960b2d90de909f2a6b07264 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3175369Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76991}
-
Junliang Yan authored
Change-Id: I74873db343b3103f12d47ca1a9617369d516424d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3174411Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76990}
-
- 21 Sep, 2021 1 commit
-
-
Junliang Yan authored
Port 06af754c Original Message: .. for more efficient access to builtins from generated code. Root-relative accesses tend to be faster and produce more compact code when the root-relative offset is small. IsolateData contains a few large tables (roots, external references, builtins), resulting in very large offsets in general. This CL starts by splitting the builtin table into tiers: tier 0 is a minimal set of perf-critical builtins that should be cheap to access. The offset to tier 0 builtins is guaranteed to be small. The full builtin table also remains in IsolateData for occasions in which we need to lookup builtins by index. In future work, we can also split external references and roots into tiers. On x64, this reduces deopt exit sizes from 7 to 4 bytes and from 12 to 9 bytes (dynamic map checks / EagerWithResume deopts). Change-Id: I021d60b20b783da170987ffcf0327b93206f7e5d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172917Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76967}
-
- 13 Sep, 2021 1 commit
-
-
Junliang Yan authored
Change-Id: Icdef3916993e14e39ef9da70af128b9fde2d3b60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158323Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76797}
-
- 12 Aug, 2021 1 commit
-
-
Ross McIlroy authored
These are no longer enabled, so remove the code mitigation logic from the codebase. BUG=chromium:1003890 Change-Id: I536bb1732e8463281c21da446bbba8f47ede8ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045704 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#76256}
-
- 11 Aug, 2021 3 commits
-
-
Milad Fa authored
MovFloatToInt and MovIntToFloat have been optimized on Power8 and above to use VSX instructions instead if using the memory. Change-Id: I77af9aa20aa477f8f9e3ec9545445ef777aa0c72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3087726 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#76241}
-
Junliang Yan authored
Change-Id: I6fb16c82e5c730e35d90a3de6c746f9c4415dc00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3087725Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#76240}
-
Junliang Yan authored
Change-Id: I5bab2fec2fc2b7256580982e6433f98f93b2c2f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3088186Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#76238}
-
- 04 Aug, 2021 1 commit
-
-
Milad Fa authored
Port 6e474ae9 Original Commit Message: This CL is a port of https://crrev.com/c/3045349 for ia32 and arm, adding helper methods to drop arguments from the stack. R=pthier@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I7099bd98285eb22cc1cbf3abd634b3479fe9e9d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3072539Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#76099}
-
- 28 Jul, 2021 1 commit
-
-
Junliang Yan authored
Change-Id: Ib10b00443fe1d46ccb75bd93ec0c855919bb563d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058295Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75964}
-
- 27 Jul, 2021 1 commit
-
-
Milad Fa authored
Port ec717160 Original Commit Message: This is no longer used, tail calls are dealt with inside of VisiTailCall. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I44cac6f77ce79d47806b3f504c3bad1d88475a25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3055307Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75945}
-
- 23 Jul, 2021 3 commits
-
-
Junliang Yan authored
Change-Id: I8d3b2e1bc5d3e5f437bc8f1bc50299459fbc7ad9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3049084Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75899}
-
Junliang Yan authored
Change-Id: Ibc2756484717804f67658156b750d9bbd18266fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3049352Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75892}
-
Junliang Yan authored
Change-Id: I04a950d196070ce8661e95b3e2b00802a5000870 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3042044Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75888}
-
- 19 Jul, 2021 2 commits
-
-
Junliang Yan authored
Change-Id: I61d07f61a344422a2048530a0497a2dc1a17b640 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038252Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75794}
-
Junliang Yan authored
Change-Id: I643bca82ee86d15e6cc65ab8856fb8b4bf5fd8e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038247Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75791}
-
- 16 Jul, 2021 2 commits
-
-
Junliang Yan authored
Change-Id: Ib8acd67b66f54dad8f6653c83aff2369f4d3a482 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3036541Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75769}
-
Junliang Yan authored
Change-Id: Id843b276e59baeaf700f92e6bf71e20edcb0dd9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3031581Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75754}
-
- 13 Jul, 2021 1 commit
-
-
Junliang Yan authored
Drive-by: clean up SubS64/AddS64 macroassembler Change-Id: I31a15b1f3f3825122f6857861845c8961ece3649 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3024152 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75711}
-
- 08 Jul, 2021 1 commit
-
-
Junliang Yan authored
Change-Id: I2b1adb84fb62b60e62229252dadbd4c9e4c8042e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3010322Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75638}
-
- 07 Jul, 2021 4 commits
-
-
Junliang Yan authored
Change-Id: I2a131a783b99a0bfd6550d0032a594f2eb402421 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3009227Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75617}
-
Junliang Yan authored
Change-Id: I7afc5bede8684f469670c84da0f94d251369e6fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3011165Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75611}
-
Junliang Yan authored
Change-Id: I6833e9815d2655064967f249c607c5d2b8fe2c01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3010681Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75607}
-
Junliang Yan authored
Change-Id: Iaab1eba1590a4489004880b039e2e8900aab94b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3011163Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75603}
-
- 06 Jul, 2021 1 commit
-
-
Junliang Yan authored
Change-Id: I1b1d8d0485f037ba5c105741039e62db87fd2b6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008642Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75584}
-