- 04 Jun, 2020 7 commits
-
-
Tobias Tebbi authored
Design Doc: https://docs.google.com/document/d/1lkvu8crkK7Ei39qjkPCFijpNyxWXsOktG9GB-7K34jM/ Bug: v8:10577 Change-Id: Ib9cfdffa401c48c895bf31caed5ee03545beddab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154792Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#68168}
-
Mythri A authored
We use StoreOwnIC to initialize the object after creating a new object with CreateObjectLiteral. CreateObjectLiteral stores kHoleNaNInt64 to indicate an uninitialized double field. When we actually try to store a NaN value into that field later using StoreOwnIC, IC avoids actually storing the new value since the existing value is "same as" the value we try to write. The float comparison treats all NaNs as equal. In this particular case, we should actually store the new value since kHoleNaNInt64 value is used to represent an uninitialized field. This cl just stores the new value even when the existing value is same as the new value for double fields. The check is still required to correctly track const fields. Bug: chromium:1082293 Change-Id: Ib37061802f2403545cffa6d6fef08be074b0825d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228886Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#68167}
-
Santiago Aboy Solanes authored
Change-Id: I29c1339fa75aa26bd18b7e007a0e88de15096a43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219934Reviewed-by:
-
Frank Tang authored
This reverts commit 3b1d24cf. Reason for revert: The problem is fixed Original change's description: > Revert "[Intl] Use new getDefaultHourCycle to replace old hack" > > This reverts commit 611e4127. > > Reason for revert: https://crbug.com/1080367 > > Original change's description: > > [Intl] Use new getDefaultHourCycle to replace old hack > > > > Use the ICU 67.1 new API DateTimePatternGenerator::getDefaultHourCycle > > to replace a hack which get the pattern of "jjmm" to find out the > > default hour cycle of a locale > > Bump the required API version from 65 to 67 > > > > Bug: v8:10225 > > Change-Id: I3378edacb6dfb8400357ac0bf3d5d50b9fe008bd > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173875 > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > Commit-Queue: Frank Tang <ftang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#67549} > > TBR=jkummerow@chromium.org,ftang@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: v8:10225 > Change-Id: I8bdfbdfc6c906814e5a7525cbde79c9cac854bd1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208811 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67929} TBR=jkummerow@chromium.org,zhin@chromium.org,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:10225 Change-Id: I386cf0347a0fa5403fb196bb46ac77f48c9c0a0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2229470Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68165}
-
Marja Hölttä authored
This reflects the latest changes in the Promise.any proposal. Bug: v8:9808 Change-Id: I0f8ea2e95f430479963bf9d9597f243024de8c74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2222344Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#68164}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c523c20..bdb409c Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/7a0ebcc..1b066f0 Rolling v8/third_party/aemu-linux-x64: V4ZGjQxGJ00ndsSZd9X90QJnY3N7-ZbuPq57Yk7yv74C..t4ELE6VgcCM5v-3W7_Dv8jFHkyeEu69AW5lwrtqWBOwC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1ec2986..15d5f65 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9904485..e65444f Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/011959a..cb44c86 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f5eca0d..a68151f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/8b9091f..59c0072 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iafe4f3edc0019eb4c061fb1f12c41047c4c411c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2229939Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68163}
-
Zhao Jiazhong authored
Port 3406cba8 https://crrev.com/c/2099451 Change-Id: I7217e333f468aa24f25231d24e31c321a2c209b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2224595Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#68162}
-
- 03 Jun, 2020 33 commits
-
-
Shu-yu Guo authored
This is a reland of c342ba82 Original change's description: > Set .name of anonymous functions on the RHS of logical assignment. > > https://github.com/tc39/proposal-logical-assignment/pull/24 reached > consensus in June TC39. > > Drive-by refactoring of testing for logical assignment ops using > IsInRange. > > Bug: v8:10579 > Change-Id: I5a203ba552a905cd28f75c5d223998431a1966ce > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2225809 > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68101} Bug: v8:10579 Change-Id: I321cf0e29515a146844abc05250e9b50ad651caf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2227255 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#68161}
-
Frank Tang authored
The fix is in 630b884f84 not f2223961. This reverts commit 464ee4b7. Reason for revert: roll to 67.1 after the landing of the fix Original change's description: > Revert "Roll ICU from 65.1 to 67.1 (f2223961) & correct tests" > > This reverts commit e270b6d6. > > Reason for revert: V8 DEPS roll stuck https://crbug.com/v8/10567#c1 > > Original change's description: > > Roll ICU from 65.1 to 67.1 (f2223961) & correct tests > > > > Rolling to chrome/src is in > > https://chromium-review.googlesource.com/c/chromium/src/+/2155530 > > > > Since auto rolling stop after 3/24/2020 and the rolling will cause > > change of test status, I get this cl ready (but not running trybot due > > to 1074260) and plan to hand roll after the submission of 2155530. > > > > Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437 > > Change-Id: I19554f68cfdc5b717dfc7fc4b1222e9dc25b8d69 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2158486 > > Auto-Submit: Frank Tang <ftang@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#67493} > > TBR=jkummerow@chromium.org,machenbach@chromium.org,jshin@chromium.org,ftang@chromium.org,syg@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437 > Change-Id: I3f4233815ed7414f2cde3d4d996696575b5f6e3a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219334 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68051} TBR=jkummerow@chromium.org,machenbach@chromium.org,jshin@chromium.org,zhin@chromium.org,ftang@chromium.org,syg@chromium.org # Not skipping CQ checks because this is a reland. Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437 Change-Id: I1de5eb36eff420482a12205682b153a2493d5249 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2220781Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Ng Zhi An authored
This relands commit 76debfda. This fix here is to convert the original mjsunit test into a cctest, where we check for SIMD support, and skip the test. We don't have lowering for I64x2 yet, so this is the workaround. Original change's description: > [wasm-simd][liftoff] Fix I64x2Mul > > The I64x2Mul overwrote the lhs/rhs if they are the same as dst. So when > deciding if we need temporaries, we should not only check the > cache_state, but whether they alias dst or not. > > Bug: chromium:1088273 > Change-Id: I82efa9b45e0a3d321a06efde60971ce95b21490f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2225796 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68114} Bug: chromium:1088273 Change-Id: Ia3fd251998159d9beb581a6af3414921fe968e40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2227068 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Change-Id: I8962c08329c57367ff82d4669880c7efb1db8875 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2229304Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68158}
-
Ng Zhi An authored
vroundps assembly is incorrect: - the signature was wrong, vroundps takes 2 operands and 1 immediate - when calling vinstr, should always pass xmm0, this wasn't causing issues because our test cases were restricted enough that it was always xmm0 anyway - the macro assembler should use AVX_OP_SSE4_1, since roundps requires SSE4_1 - drive-by fix for roundss and roundsd to be AVX_OP_SSE4_1 - add disasm for roundps and vroundps, and test them Bug: v8:10553 Change-Id: I4046eb81a9f18d5af7137bbd46bfa0478e5a9ab2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2227252Reviewed-by:
-
Andreas Haas authored
This CL repurposes the v8.wasm trace event category, and introduces additionally the v8.wasm.detailed category. The v8.wasm category is enabled by default and captures core wasm events like validation, compilation, instantiation, and important operations like grow-memory and tier-up timings. The v8.wasm.detailed category is disabled by default. It captures all events the previous v8.wasm category captured, like compilation of single functions, time needed for register allocation, ... This CL splits these categories to allow enabling the v8.wasm category in telemetry benchmarks to calculate compile time and other metrics from traces of telemetry runs. R=ecmziegler@chromium.org Bug: chromium:1084929 Change-Id: Ida58b8f344b0ccb6ee1210e259c3e0e993eff497 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2210230 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#68156}
-
Ng Zhi An authored
This adds s128 not, and, andnot, or, xor, and select. Bug: v8:10180 Change-Id: Id7f05f7fdc9f082bee1182babbb4a5e4b55d7d47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2225604Reviewed-by:
-
Milad Farazmand authored
Change-Id: I395471a93b6df55ae8d45b7627b23067ae208f54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2226552 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Kim-Anh Tran authored
Bug: chromium:1081735 Change-Id: Iab58b303ec718a15653ba80fefbb873ef93df003 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2218284 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Andreas Haas authored
All subtyping has been removed from the reference-types proposal. This CL implements this proposal change now in V8. R=manoskouk@chromium.org Bug: v8:10556 Change-Id: I08ef064952278e03ea655461fa9f0c96426157c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2222345 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
We already track register usage, so we can stop as soon as all registers are spilled. Also iterate the stack backwards, since the bottom of the stack is more likely to be already spilled. R=clemensb@chromium.org Bug: v8:10576 Change-Id: I06fe8efe257dd5b8bcb426b4e79a8815a8cb5c81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228494 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Michael Lippautz authored
This ports HeapStatsCollector (former ThreadHeapStatsCollector) from Blink. The CL only ports accounting of allocated object size which is needed for a simple growing strategy in a follow up. HeapStatsCollector is a global dependency for most sub components as it provides infrastructure for measuring time (through trace scopes) and space. The general idea of HeapStatsCollector is to act as sink where all sub components push time and space information. This information is then gathered and made available via an event that is implemented as POD. Time-dependent info is available through regular getters (pull) and observers (push). Change-Id: I40b4d76e1a40c56e5df1a7353622318cde730e26 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2225902 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68150}
-
Santiago Aboy Solanes authored
This CL makes it so that we revisit nodes in the revisit queue as soon as possible in RETYPE and PROPAGATE. This is done to revisit loops related to backedges before moving onto other nodes. Bug: v8:10424 Change-Id: I432c6551805903072b3f9fbc867adca82b263325 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2157373Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#68149}
-
Andreas Haas authored
Even in unreachable code, the targets of br_table have to have matching types. R=thibaudm@chromium.org Bug: v8:10556 Change-Id: I2e85df3cb92f7910a6bcb5ac03927c424194660d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2218062 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#68148}
-
Manos Koukoutos authored
Add some abstractions to make it easier to define more tests. Bug: v8:7748 Change-Id: Ia5605aa10963228eb4bfba37e2b412fc5af860d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2224212 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Junliang Yan authored
1) Rename remembered-set-inl.h back to remembered-set.h 2) Introduce a new remembered-set-inl.h and move the function definition that depends on ptr-compr-inl.h. Change-Id: I0e16e1e428937184ff255471937c70e6bb65a11e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2223816 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Clemens Backes authored
When tiering down (or up), we first get a list of all native modules (under a lock), then tier them down/up without holding the lock. Since we don't hold (shared) ownership of the native module, it could die in-between. This CL fixes this by keeping weak pointers to the native modules, and re-gaining a shared pointer before putting the module in the list of modules to be tiered down/up. R=thibaudm@chromium.org Bug: v8:10588 Change-Id: I2891c3729f42f26d4026f3e2448e124863b95122 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228515 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Michael Lippautz authored
No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1056170 Change-Id: I0f8d0a4e79fa3a526151efe3317546862aff70bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228333 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Arnaud Robin authored
Added return value display when tracing function calls in wasm. The new types handled are I32, I64, F32 and F64. Only single return value is handled. R=clemensb@chromium.org Bug: v8:10559 Change-Id: I726d08fcfdc8bf2c3e43a25ec1932412ff74387b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2225024Reviewed-by:
-
Mythri A authored
This is a followup of the cl [1] that fixes a bug where bytecode was getting flushed when allocating feedback vector. The fix added IsCompiledScope before allocating a new feedback vector. We now pass IsCompiledScope to JSFunction::EnsureFeedbackVector. This makes it explicit that EnsureFeedbackVector expects a function that is compiled and the bytecode shouldn't be flushed during the allocation.Also adds a test. [1] https://chromium-review.googlesource.com/c/v8/v8/+/2218066 Bug: v8:10560 Change-Id: I552c449a57555dffa625b2e4efa04c2c276fc0b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2222347 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Andreas Haas authored
With recent changes to the anyref proposal, null refs now have a type immediate which declares the type of a null ref constant. Likewise, the RefIsNull instruction is type aware now. This CL addresses these proposal changes now. R=jkummerow@chromium.org Bug: v8:10556 Change-Id: I810dfa3a4ab4389afc9639f897cee5d43e9b62cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215172 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Dan Elphick authored
Now ReadOnlySpace is not a Space, it cannot be upcasted to it, so cast to BaseSpace as well. Fixes ubsan failure introduced by https://chromium-review.googlesource.com/c/v8/v8/+/2209060. Bug: v8:10454 Change-Id: I2936bfd8349377b441be4a6eedf580d91f1c4ee4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228723 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I7cb19e19de63a74e5407665c28f1b5c0f23d7d0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2226563 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#68139}
-
Zhao Jiazhong authored
Port aa5bcc09 https://crrev.com/c/2225090 Change-Id: Ib3b159ebcee0d4da5ce003b08d02cd36b7218016 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228097Reviewed-by:
-
Dan Elphick authored
This changes ReadOnlySpace to no longer be a PagedSpace but instead it is now a BaseSpace. BasicSpace is a new base class that Space inherits from and which has no allocation methods and does not dictate how the pages should be held. ReadOnlySpace unlike Space holds its pages as a std::vector<ReadOnlyPage>, where ReadOnlyPage directly subclasses BasicMemoryChunk, meaning they do not have prev_ and next_ pointers and cannot be held in a heap::List. This is desirable since with pointer compression we would like to remap these pages to different memory addresses which would be impossible with a heap::List. Since ReadOnlySpace no longer uses most of the code from the other Spaces it makes sense to simplify its memory allocation to use a simple bump pointer and always allocate a new page whenever an allocation exceeds the remaining space on the final page. Change-Id: Iee6d9f96cfb174b4026ee671ee4f897909b38418 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2209060 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This brings %DebugPrint(string) closer to %DebugPrint(object) by also including the pointer, object kind, and RO/old space. Especially the pointer can be useful while debugging. One could consider going even further end printing full details of the string object, e.g. first and second pointers for cons strings. Before: $ out/debug/d8 --allow-natives-syntax -e '%DebugPrint("abc");' DebugPrint: #abc 0x263f080402cd: [Map] in ReadOnlySpace [...] After: $ out/debug/d8 --allow-natives-syntax -e '%DebugPrint("abc");' DebugPrint: 0xa830824ffe1: [String] in OldSpace: #abc 0xa83080402cd: [Map] in ReadOnlySpace [...] Drive-by: Document string printing functions. Drive-by: Use PrintUC16 in spots that don't want a full debug print. Bug: v8:10581 Change-Id: Ided59047b9c3edc1830ce7721376dddfd24fad1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228509Reviewed-by: -
Igor Sheludko authored
... in order to make it possible to collect zone memory usage stats from Chrome. Drive-by-cleanup: move TracingFlags definition to a separate file. Bug: v8:10572 Change-Id: I05fb65e207d573d5c18821067cfff4c37f2d77cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2226561Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#68135}
-
Dan Elphick authored
This moves several fields that will be needed by ReadOnlySpace pages when it stops using MemoryChunk into BasicMemoryChunk. Additionally AllocationStats is moved from spaces.h into allocation-stats.h. Bug: v8:10473, v8:10454 Change-Id: I76a66565a260126e629bd7588a5418267dfa8423 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228722Reviewed-by:
-
Igor Sheludko authored
... collected via --trace-zone-stats flag or v8.zone_stats trace category. This is an initial version inspired by heap-stats UI. Bug: v8:10572 Change-Id: Ib87cf0b4e120bc99683227eef02668a2a5c3d594 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2226855Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#68133}
-
Peter Ralbovsky authored
Fuzzilli is open source fuzzer by Samuel Groß (saelo@google.com) that can be used to find bugs in v8 javascript engine. As we want to automate fuzzing for current versions of v8, we want to merge fuzzilli toolkit into v8 code, so that fuzzer can automatically update to the newest version. So far Fuzzilli has been maintained at https://github.com/googleprojectzero/fuzzilli . Bug tracker Id: https://bugs.chromium.org/p/v8/issues/detail?id=10571 Change-Id: I83ddc7e8bb31664c19e4044395bb9044a1c12031 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2201760Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#68132}
-
Camillo Bruni authored
Passing tests that are marked as fail in a status file are not immediately visible as such. - Always show "--- FAILED ---" for failing tests - Show "--- UNEXPECTED PASS ---" for unexpectedly passing tests Drive-by-fixes: - Color failures in red with --progress=color - Color repro command in yellow with --progress=color Change-Id: Id43ecec348dbfd4ff627ea6aa4ba458a2e5a8445 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213434Reviewed-by:
-
Thibaud Michaud authored
On x86-64, we spend significant time constructing and copying operands in Liftoff (around 5% locally). Inlining the constructor and helper functions removes most of the overhead. R=clemensb@chromium.org Bug: v8:10576 Change-Id: I1663e3e92abe7683eba9320e77fce9be8f84b4ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2225023 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Iain Ireland authored
https://crrev.com/c/2072858 rewrote the implementation of non-unicode ignore-case matches to comply with the JS spec in some corner cases. It fixed character matches and character class matches. We missed a similar bug in the implementation of back references. This CL fixes that bug. The main change is in regexp-macro-assembler.cc, where CaseInsensitiveCompareUC16 is split into CaseInsensitiveCompareUnicode (which has the same semantics as before) and CaseInsensitiveCompareNonUnicode (which has the semantics described here: https://tc39.es/ecma262/#sec-runtime-semantics-canonicalize-ch). Most of the rest of the patch undoes https://crrev.com/c/2081816 to once again make the unicode flag available to the macroassembler, so that we can decide which helper function to call. The testcase is a version of test/intl/regress-10248.js, modified to test backreferences. Bug: v8:10573 Change-Id: I70ef7d134d37f99b1f75a5eba17020e82d59f1b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219284Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#68129}
-
