• Ng Zhi An's avatar
    [x64] Fix vroundps assembly, add disassembly · 02ee6904
    Ng Zhi An authored
    vroundps assembly is incorrect:
    - the signature was wrong, vroundps takes 2 operands and 1 immediate
    - when calling vinstr, should always pass xmm0, this wasn't causing
    issues because our test cases were restricted enough that it was always
    xmm0 anyway
    - the macro assembler should use AVX_OP_SSE4_1, since roundps requires
    SSE4_1
    - drive-by fix for roundss and roundsd to be AVX_OP_SSE4_1
    - add disasm for roundps and vroundps, and test them
    
    Bug: v8:10553
    Change-Id: I4046eb81a9f18d5af7137bbd46bfa0478e5a9ab2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2227252Reviewed-by: 's avatarDeepti Gandluri <gdeepti@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68157}
    02ee6904
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...