• Mythri A's avatar
    [ic] Fix a bug in StoreOwnIC when storing NaN values · b6133551
    Mythri A authored
    We use StoreOwnIC to initialize the object after creating a new object
    with CreateObjectLiteral. CreateObjectLiteral stores kHoleNaNInt64
    to indicate an uninitialized double field. When we actually try
    to store a NaN value into that field later using StoreOwnIC, IC avoids
    actually storing the new value since the existing value is "same as"
    the value we try to write. The float comparison treats all NaNs as
    equal. In this particular case, we should actually store the new value
    since kHoleNaNInt64 value is used to represent an uninitialized field.
    
    This cl just stores the new value even when the existing value is same
    as the new value for double fields. The check is still required to
    correctly track const fields.
    
    Bug: chromium:1082293
    Change-Id: Ib37061802f2403545cffa6d6fef08be074b0825d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228886Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68167}
    b6133551
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...