Skip to content

V
V8
Commit f6ce085a authored by Frank Tang's avatar Frank Tang Committed by Commit Bot
Browse files
Options

Reland "Roll ICU from 65.1 to 67.1 & correct tests" 

The fix is in 630b884f84 not f2223961.

This reverts commit 464ee4b7.

Reason for revert: roll to 67.1 after the landing of the fix

Original change's description:
> Revert "Roll ICU from 65.1 to 67.1 (f2223961) & correct tests"
>
> This reverts commit e270b6d6.
>
> Reason for revert: V8 DEPS roll stuck https://crbug.com/v8/10567#c1
>
> Original change's description:
> > Roll ICU from 65.1 to 67.1 (f2223961) & correct tests
> >
> > Rolling to chrome/src is in
> > https://chromium-review.googlesource.com/c/chromium/src/+/2155530
> >
> > Since auto rolling stop after 3/24/2020 and the rolling will cause
> > change of test status, I get this cl ready (but not running trybot due
> > to 1074260) and plan to hand roll after the submission of 2155530.
> >
> > Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437
> > Change-Id: I19554f68cfdc5b717dfc7fc4b1222e9dc25b8d69
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2158486
> > Auto-Submit: Frank Tang <ftang@chromium.org>
> > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#67493}
>
> TBR=jkummerow@chromium.org,machenbach@chromium.org,jshin@chromium.org,ftang@chromium.org,syg@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437
> Change-Id: I3f4233815ed7414f2cde3d4d996696575b5f6e3a
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219334
> Reviewed-by: Zhi An Ng <zhin@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Zhi An Ng <zhin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#68051}

TBR=jkummerow@chromium.org,machenbach@chromium.org,jshin@chromium.org,zhin@chromium.org,ftang@chromium.org,syg@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437
Change-Id: I1de5eb36eff420482a12205682b153a2493d5249
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2220781Reviewed-by: 's avatarFrank Tang <ftang@chromium.org>
Reviewed-by: 's avatarZhi An Ng <zhin@chromium.org>
Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68160}
parent 1495b3db
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 132 deletions
DEPS
View file @ f6ce085a
......@@ -76,7 +76,7 @@ deps = {
'v8/third_party/depot_tools':
Var('chromium_url') + '/chromium/tools/depot_tools.git' + '@' + '99044852de36333f88644adfd074189c05eaec12',
'v8/third_party/icu':
Var('chromium_url') + '/chromium/deps/icu.git' + '@' + '84e9d0035875f383b98320d48f3e7008a23c3738',
Var('chromium_url') + '/chromium/deps/icu.git' + '@' + '630b884f84d1d5e92aeda3463dca99fe2befd30e',
'v8/third_party/instrumented_libraries':
Var('chromium_url') + '/chromium/src/third_party/instrumented_libraries.git' + '@' + 'bb3f1802c237dd19105dd0f7919f99e536a39d10',
'v8/buildtools':
......
test/intl/intl.status
View file @ f6ce085a
......@@ -33,11 +33,6 @@
# https://code.google.com/p/v8/issues/detail?id=7481
'collator/check-kf-option': [FAIL],
'collator/check-kn-option': [FAIL],
# http://crbug/v8/9930
'date-format/format_range_hour_cycle': [FAIL],
# http://crbug/v8/10437
'regress-10437': [FAIL],
}], # ALWAYS
['variant == no_wasm_traps', {
......
test/intl/locale/locale-constructor.js
View file @ f6ce085a
......@@ -19,9 +19,8 @@ assertThrows(() => new Intl.Locale('abcdefghi'), RangeError);
// Options will be force converted into Object.
assertDoesNotThrow(() => new Intl.Locale('sr', 5));
// ICU problem - locale length is limited.
// http://bugs.icu-project.org/trac/ticket/13417.
assertThrows(
// Regression for http://bugs.icu-project.org/trac/ticket/13417.
assertDoesNotThrow(
() => new Intl.Locale(
'sr-cyrl-rs-t-ja-u-ca-islamic-cu-rsd-tz-uslax-x-whatever', {
calendar: 'buddhist',
......
test/intl/number-format/unified/sign-display.js
View file @ f6ce085a
......@@ -13,7 +13,7 @@ const testData = [
["auto", "-123", "-0", "0", "123"],
["always", "-123", "-0", "+0", "+123"],
["never", "123", "0", "0", "123"],
["exceptZero", "-123", "-0", "0", "+123"],
["exceptZero", "-123", "0", "0", "+123"],
];
for (const [signDisplay, neg, negZero, zero, pos] of testData) {
......
test/test262/test262.status
View file @ f6ce085a
......@@ -382,103 +382,6 @@
# https://bugs.chromium.org/p/v8/issues/detail?id=10379
'built-ins/RegExp/named-groups/non-unicode-property-names-valid': [FAIL],
'built-ins/RegExp/property-escapes/generated/Alphabetic': [FAIL],
'built-ins/RegExp/property-escapes/generated/Assigned': [FAIL],
'built-ins/RegExp/property-escapes/generated/Case_Ignorable': [FAIL],
'built-ins/RegExp/property-escapes/generated/Cased': [FAIL],
'built-ins/RegExp/property-escapes/generated/Changes_When_Casefolded': [FAIL],
'built-ins/RegExp/property-escapes/generated/Changes_When_Casemapped': [FAIL],
'built-ins/RegExp/property-escapes/generated/Changes_When_Lowercased': [FAIL],
'built-ins/RegExp/property-escapes/generated/Changes_When_NFKC_Casefolded': [FAIL],
'built-ins/RegExp/property-escapes/generated/Changes_When_Titlecased': [FAIL],
'built-ins/RegExp/property-escapes/generated/Changes_When_Uppercased': [FAIL],
'built-ins/RegExp/property-escapes/generated/Dash': [FAIL],
'built-ins/RegExp/property-escapes/generated/Diacritic': [FAIL],
'built-ins/RegExp/property-escapes/generated/Emoji': [FAIL],
'built-ins/RegExp/property-escapes/generated/Emoji_Modifier_Base': [FAIL],
'built-ins/RegExp/property-escapes/generated/Emoji_Presentation': [FAIL],
'built-ins/RegExp/property-escapes/generated/Extended_Pictographic': [FAIL],
'built-ins/RegExp/property-escapes/generated/Extender': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Cased_Letter': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Dash_Punctuation': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Decimal_Number': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Letter': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Lowercase_Letter': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Mark': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Modifier_Letter': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Modifier_Symbol': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Nonspacing_Mark': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Number': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Other_Letter': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Other_Number': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Other_Punctuation': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Other_Symbol': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Punctuation': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Spacing_Mark': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Symbol': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Uppercase_Letter': [FAIL],
'built-ins/RegExp/property-escapes/generated/Grapheme_Base': [FAIL],
'built-ins/RegExp/property-escapes/generated/Grapheme_Extend': [FAIL],
'built-ins/RegExp/property-escapes/generated/ID_Continue': [FAIL],
'built-ins/RegExp/property-escapes/generated/ID_Start': [FAIL],
'built-ins/RegExp/property-escapes/generated/Ideographic': [FAIL],
'built-ins/RegExp/property-escapes/generated/Lowercase': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Arabic': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Armenian': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Bopomofo': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Chakma': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Chorasmian': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Common': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Dives_Akuru': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Han': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Other': [FAIL],
'built-ins/RegExp/property-escapes/generated/General_Category_-_Unassigned': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Inherited': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Khitan_Small_Script': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Latin': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Lisu': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Malayalam': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Newa': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Oriya': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Sharada': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Sinhala': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Syloti_Nagri': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Tangut': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_-_Yezidi': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Arabic': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Bopomofo': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Chakma': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Chorasmian': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Common': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Cyrillic': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Dives_Akuru': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Georgian': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Han': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Inherited': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Khitan_Small_Script': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Latin': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Lisu': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Malayalam': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Newa': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Oriya': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Sharada': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Sinhala': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Syloti_Nagri': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Syriac': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Tangut': [FAIL],
'built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Yezidi': [FAIL],
'built-ins/RegExp/property-escapes/generated/Sentence_Terminal': [FAIL],
'built-ins/RegExp/property-escapes/generated/Terminal_Punctuation': [FAIL],
'built-ins/RegExp/property-escapes/generated/Unified_Ideograph': [FAIL],
'built-ins/RegExp/property-escapes/generated/Uppercase': [FAIL],
'built-ins/RegExp/property-escapes/generated/XID_Continue': [FAIL],
'built-ins/RegExp/property-escapes/generated/XID_Start': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=10380
'language/identifiers/part-unicode-13.0.0': [FAIL],
'language/identifiers/part-unicode-13.0.0-escaped': [FAIL],
'language/identifiers/start-unicode-13.0.0': [FAIL],
'language/identifiers/start-unicode-13.0.0-escaped': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=4628
'language/eval-code/direct/non-definable-function-with-function': [FAIL],
......@@ -643,31 +546,6 @@
# super() should evaluate arguments before checking IsConstructable
'language/expressions/super/call-proto-not-ctor': [FAIL],
# Intl.NumberFormat(..., {signDisplay:'exceptZero'}).format(0.0001)
# produce +0 due to rounding
# https://bugs.chromium.org/p/v8/issues/detail?id=9515
'intl402/NumberFormat/prototype/format/signDisplay-en-US': [FAIL],
'intl402/NumberFormat/prototype/format/signDisplay-de-DE': [FAIL],
'intl402/NumberFormat/prototype/format/signDisplay-ja-JP': [FAIL],
'intl402/NumberFormat/prototype/format/signDisplay-ko-KR': [FAIL],
'intl402/NumberFormat/prototype/format/signDisplay-zh-TW': [FAIL],
'intl402/NumberFormat/prototype/format/signDisplay-rounding': [FAIL],
'intl402/NumberFormat/prototype/format/signDisplay-currency-de-DE': [FAIL],
'intl402/NumberFormat/prototype/format/signDisplay-currency-en-US': [FAIL],
'intl402/NumberFormat/prototype/format/signDisplay-currency-ja-JP': [FAIL],
'intl402/NumberFormat/prototype/format/signDisplay-currency-ko-KR': [FAIL],
'intl402/NumberFormat/prototype/format/signDisplay-currency-zh-TW': [FAIL],
'intl402/NumberFormat/prototype/formatToParts/signDisplay-en-US': [FAIL],
'intl402/NumberFormat/prototype/formatToParts/signDisplay-de-DE': [FAIL],
'intl402/NumberFormat/prototype/formatToParts/signDisplay-ja-JP': [FAIL],
'intl402/NumberFormat/prototype/formatToParts/signDisplay-ko-KR': [FAIL],
'intl402/NumberFormat/prototype/formatToParts/signDisplay-zh-TW': [FAIL],
'intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-de-DE': [FAIL],
'intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-en-US': [FAIL],
'intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-ja-JP': [FAIL],
'intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-ko-KR': [FAIL],
'intl402/NumberFormat/prototype/formatToParts/signDisplay-currency-zh-TW': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=10381
'built-ins/Array/prototype/concat/arg-length-near-integer-limit': [FAIL],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment