• Jakob Gruber's avatar
    Include standard heap object header when debug-printing String objects · 86fee30e
    Jakob Gruber authored
    This brings %DebugPrint(string) closer to %DebugPrint(object) by also
    including the pointer, object kind, and RO/old space. Especially the
    pointer can be useful while debugging.
    
    One could consider going even further end printing full details of
    the string object, e.g. first and second pointers for cons strings.
    
    Before:
    
     $ out/debug/d8 --allow-natives-syntax -e '%DebugPrint("abc");'
     DebugPrint: #abc
     0x263f080402cd: [Map] in ReadOnlySpace
     [...]
    
    After:
    
     $ out/debug/d8 --allow-natives-syntax -e '%DebugPrint("abc");'
     DebugPrint: 0xa830824ffe1: [String] in OldSpace: #abc
     0xa83080402cd: [Map] in ReadOnlySpace
     [...]
    
    Drive-by: Document string printing functions.
    Drive-by: Use PrintUC16 in spots that don't want a full debug print.
    
    Bug: v8:10581
    Change-Id: Ided59047b9c3edc1830ce7721376dddfd24fad1d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228509Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68136}
    86fee30e
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...