• Frank Tang's avatar
    Reland "[Intl] Use new getDefaultHourCycle to replace old hack" · cf209e2a
    Frank Tang authored
    This reverts commit 3b1d24cf.
    
    Reason for revert: The problem is fixed
    
    Original change's description:
    > Revert "[Intl] Use new getDefaultHourCycle to replace old hack"
    > 
    > This reverts commit 611e4127.
    > 
    > Reason for revert: https://crbug.com/1080367
    > 
    > Original change's description:
    > > [Intl] Use new getDefaultHourCycle to replace old hack
    > > 
    > > Use the ICU 67.1 new API DateTimePatternGenerator::getDefaultHourCycle
    > > to replace a hack which get the pattern of "jjmm" to find out the
    > > default hour cycle of a locale
    > > Bump the required API version from 65 to 67
    > > 
    > > Bug: v8:10225
    > > Change-Id: I3378edacb6dfb8400357ac0bf3d5d50b9fe008bd
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173875
    > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > > Commit-Queue: Frank Tang <ftang@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#67549}
    > 
    > TBR=jkummerow@chromium.org,ftang@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: v8:10225
    > Change-Id: I8bdfbdfc6c906814e5a7525cbde79c9cac854bd1
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208811
    > Reviewed-by: Zhi An Ng <zhin@chromium.org>
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Commit-Queue: Zhi An Ng <zhin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67929}
    
    TBR=jkummerow@chromium.org,zhin@chromium.org,ftang@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:10225
    Change-Id: I386cf0347a0fa5403fb196bb46ac77f48c9c0a0f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2229470Reviewed-by: 's avatarFrank Tang <ftang@chromium.org>
    Reviewed-by: 's avatarZhi An Ng <zhin@chromium.org>
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68165}
    cf209e2a
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...