• Frank Tang's avatar
    Reland "Roll ICU from 65.1 to 67.1 & correct tests" · f6ce085a
    Frank Tang authored
    The fix is in 630b884f84 not f2223961.
    
    This reverts commit 464ee4b7.
    
    Reason for revert: roll to 67.1 after the landing of the fix
    
    Original change's description:
    > Revert "Roll ICU from 65.1 to 67.1 (f2223961) & correct tests"
    >
    > This reverts commit e270b6d6.
    >
    > Reason for revert: V8 DEPS roll stuck https://crbug.com/v8/10567#c1
    >
    > Original change's description:
    > > Roll ICU from 65.1 to 67.1 (f2223961) & correct tests
    > >
    > > Rolling to chrome/src is in
    > > https://chromium-review.googlesource.com/c/chromium/src/+/2155530
    > >
    > > Since auto rolling stop after 3/24/2020 and the rolling will cause
    > > change of test status, I get this cl ready (but not running trybot due
    > > to 1074260) and plan to hand roll after the submission of 2155530.
    > >
    > > Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437
    > > Change-Id: I19554f68cfdc5b717dfc7fc4b1222e9dc25b8d69
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2158486
    > > Auto-Submit: Frank Tang <ftang@chromium.org>
    > > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#67493}
    >
    > TBR=jkummerow@chromium.org,machenbach@chromium.org,jshin@chromium.org,ftang@chromium.org,syg@chromium.org
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437
    > Change-Id: I3f4233815ed7414f2cde3d4d996696575b5f6e3a
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219334
    > Reviewed-by: Zhi An Ng <zhin@chromium.org>
    > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    > Commit-Queue: Zhi An Ng <zhin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#68051}
    
    TBR=jkummerow@chromium.org,machenbach@chromium.org,jshin@chromium.org,zhin@chromium.org,ftang@chromium.org,syg@chromium.org
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437
    Change-Id: I1de5eb36eff420482a12205682b153a2493d5249
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2220781Reviewed-by: 's avatarFrank Tang <ftang@chromium.org>
    Reviewed-by: 's avatarZhi An Ng <zhin@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68160}
    f6ce085a
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...