Skip to content

V
V8
Switch branch/tag
  1. 12 May, 2021 1 commit
    • Milad Fa's avatar
      PPC/S390 [simulator] Use bit_cast instead of reinterpret_cast · dfe7aca1
      Milad Fa authored 
      The following bit casting method using reinterpret_cast
has undefined behaviour:
```
int a = 1;
float b = *reinterpret_cast<float*>(&a);
```
Above breaks the strict aliasing rule which indicates:
> dereferencing pointers to objects of different types will
never refer to the same memory location.

More information can be found under src/base/macros.h.

`bit_cast` here is implemented with `memcpy` behind the scenes.
C++20 will have this feature included by default.

Change-Id: I69ffdbeba6db64e24b268d838ea1d863fcd9121d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2889331Reviewed-by: 's avatarJunliang Yan <junyan@redhat.com>
Commit-Queue: Milad Fa <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/master@{#74513}
      dfe7aca1
  3. 07 May, 2021 1 commit
  5. 30 Apr, 2021 1 commit
  7. 22 Apr, 2021 1 commit
  9. 07 Apr, 2021 1 commit
  11. 26 Mar, 2021 1 commit
  13. 25 Mar, 2021 1 commit
  15. 22 Mar, 2021 2 commits
  17. 17 Mar, 2021 2 commits
  19. 16 Mar, 2021 2 commits
  21. 15 Mar, 2021 2 commits
  23. 12 Mar, 2021 3 commits
  25. 11 Mar, 2021 1 commit
  27. 10 Mar, 2021 3 commits
  29. 08 Mar, 2021 1 commit
  31. 03 Mar, 2021 2 commits
  33. 02 Mar, 2021 2 commits
  35. 01 Mar, 2021 1 commit
  37. 25 Feb, 2021 2 commits
  39. 24 Feb, 2021 1 commit
  41. 23 Feb, 2021 1 commit
  43. 15 Feb, 2021 1 commit
  45. 02 Feb, 2021 1 commit
    • Milad Fa's avatar
      PPC/s390: Fix frame size to account for q registers · f8360140
      Milad Fa authored 
      Port 45b99aaa

Original Commit Message:

    In https://crrev.com/c/2645694 we push the full q registers before lazy
    compile, but we did not change the fixed frame size to account for the
    wider registers being pushed.

    This manifested in the frame having data like:

    (gdb) x/10xg start.ptr_
    0x7f5576ff3eb0: 0x0000000000000000      0x0000336b08202759
    0x7f5576ff3ec0: 0x7ff000007f801000      0x0000000000000000
    0x7f5576ff3ed0: 0x7ff000007f801001      0x0000000000000000
    0x7f5576ff3ee0: 0x7ff000007f801002      0x0000000000000000
    0x7f5576ff3ef0: 0x7ff000007f801003      0x0000000000000000

    The GC then walks part of this frame, thinking that 0x7ff000007f801003
    is a heap object, and then crashes.

    Add some static_asserts (similar to builtins-x64) to remind ourselves
    that the pushed registers have to match the size in frame constants.

R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com
BUG=
LOG=N

Change-Id: I994f1b7fecbb24ea97d846b1eed98201bc3b08ad
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2669308Reviewed-by: 's avatarJunliang Yan <junyan@redhat.com>
Commit-Queue: Milad Fa <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/master@{#72496}
      f8360140
  47. 29 Jan, 2021 1 commit
  49. 17 Nov, 2020 1 commit
  51. 03 Nov, 2020 1 commit
  53. 02 Nov, 2020 1 commit
  55. 28 Oct, 2020 1 commit
  57. 03 Sep, 2020 1 commit