- 19 Mar, 2021 24 commits
-
-
Shu-yu Guo authored
Bug: v8:11573 Change-Id: Iab32d07443298bcd39c470ad92c5ce6db0a2b580 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2770603 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73550}
-
Junliang Yan authored
This is a reland of 88c1ae95 Original change's description: > s390x: [liftoff] implement CallRuntimeStub > > Change-Id: I505ea67af31006f3f233eef390f234cfc0188d6c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2774479 > Reviewed-by: Milad Fa <mfarazma@redhat.com> > Commit-Queue: Junliang Yan <junyan@redhat.com> > Cr-Commit-Position: refs/heads/master@{#73525} Change-Id: Id5d0ece78533439870fdc6b000026fe04e576448 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2774561Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73549}
-
Clemens Backes authored
This allows to hold a constexpr (empty) "builder" object instead of creating it for every use. R=ahaas@chromium.org Bug: v8:11384 Change-Id: Ib5e13c58e81a950bb5dd0e8eefe4021bc77d8b64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773801 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73548}
-
Milad Fa authored
Port 7e6fe4ea Original Commit Message: Although the result was unused, these functions used to return a (often random) Node* to satisfy old restrictions of graph-builder-interface. Now that these restrictions are lifted, we can type them properly as {void}. R=manoskouk@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Iabcc889af26ddb2325530dc78d15f5a8f4667387 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2775570 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73547}
-
Leszek Swirski authored
StoreTaggedSignedField wasn't clearing the lower bits of a field when writing a 32-bit Smi Bug: v8:11420 Change-Id: I543a35001ca8a78490de2d09539b72f52749b198 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2775571 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73546}
-
Junliang Yan authored
Change-Id: I7dfe3005554286f2f6a83acc4019c3cf06f7f65c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2774058Reviewed-by:
-
Manos Koukoutos authored
Although the result was unused, these functions used to return a (often random) Node* to satisfy old restrictions of graph-builder-interface. Now that these restrictions are lifted, we can type them properly as {void}. Change-Id: I914024240f3005bc8a8636ac33ed4594f5ae5988 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767218 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: -
Junliang Yan authored
Port 4b3371c6 Original Message: This will make it easier to generate builtin calls that require the context to be passed in that register, because this can be represented as a {LiftoffRegister} then. Change-Id: I35f14d9f5460706ef1d51f39a7eb3afdf0979f9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764682Reviewed-by:
-
Clemens Backes authored
If memory64 is enabled, memory.grow should consume and return an i64 instead of i32. This CL implements this for both TurboFan and Liftoff, and adds validation and execution tests at different layers. R=manoskouk@chromium.org Bug: v8:10949 Change-Id: I0b725dbd0d5767bda4609747c1f4aad163c35304 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773800Reviewed-by:
-
Frank Emrich authored
This CL makes CTZ (count trailing zeros) and POPCOUNT (count set bits), which are optional ops in the raw machine assembler, available in CSA. A fallback exists for the case that they are not available. This CL also adds the 64 bit version of the mandatory CLZ (count leading zeros) op available. Change-Id: I53cd6738b8ede8bd5842a83bb1161299824d39c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742207Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Clemens Backes authored
The initial implementation of {FixedSizeSignature} contains undefined behaviour, because {InitReps} wrote to the {reps_} array before the constructor of that array has been called. This also resulted in bugs if {FixedSizeSignature} was used with types that actually have a constructor (like {ValueType}). The array constructor would call the default constructor on each contained element, thus overwriting the values written by {InitReps}. This CL fixes that by switching to a plain array, and only writing to the array in the body of the constructor (after the field was properly initialized). It also removes the {Concat} method in favor or simply copying from two input arrays in a private constructor. Drive-by: Use proper constant names for the template parameters to make cpplint happy. R=ahaas@chromium.org Bug: v8:11384 Change-Id: Id748c8fef3c846069f91843f74d0555ed8ca9fb7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773799Reviewed-by: -
Georg Neis authored
The condition can change between VisitBranch and VisitIf, so VisitIf can't assume that the condition is not yet in the ControlPathConditions list. Thanks Manos! Change-Id: Ic74253b6faf2663cfa5212765d81392cb89d73b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773312Reviewed-by:
-
Milad Fa authored
This reverts commit 88c1ae95. Reason for revert: illegal instruction Original change's description: > s390x: [liftoff] implement CallRuntimeStub > > Change-Id: I505ea67af31006f3f233eef390f234cfc0188d6c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2774479 > Reviewed-by: Milad Fa <mfarazma@redhat.com> > Commit-Queue: Junliang Yan <junyan@redhat.com> > Cr-Commit-Position: refs/heads/master@{#73525} Change-Id: Ie464430bce6f768f38ebed193d10bbf0107a8484 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2774164Reviewed-by:
Junliang Yan <junyan@redhat.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73538}
-
Manos Koukoutos authored
This is a reland of a3b1233e Changes compared to original commit: - Use a more canonical way to replace TrapIf/Unless nodes that always trap. This fixes the issue where their outputs were marked dead even if they were Merge/Loop nodes. - Use Throw() over Return() to connect a dangling trap to End(). - Add regression test. Original change's description: > [turbofan] Optimize TrapIf/Unless in BranchElim. and CommonOp-Reducer > > Bug: v8:11510 > Change-Id: I1e8fcb54444e494c7d765ad556d09d954441361f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752876 > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73468} Bug: v8:11510, chromium:1189454 Change-Id: I1d691a3ea299ed668cff925910ed231aad37cac6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772601 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
The `Script::source_url` field holds the value of the magic `//# sourceURL` comment if found, and the `Script::name` field is supposed to hold the actual name of the resource (as provided by the embedder ideally), in case of Chromium that's supposed to be the URL (in case of Node.js it's often the local path). Using `source_url` worked by chance so far, but for loading DWARF symbol files correctly we need the initiator (which we pick from the embedderName of the Script as reported to DevTools). More importantly, the partial handling of `//# sourceURL` in V8 is a layering violation and causes trouble in DevTools, i.e. when users put relative paths here. So as part of refactoring and correctifying the handling of `//# sourceURL`, we need to make sure that the embedder provided name (the URL in case of Chromium) is always stored in the `Script::name` field. Bug: chromium:1183990, chromium:974543, chromium:1174507 Change-Id: I32e11def2b9b52be11bd2e0e64a2ab6bdcf5e52d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773584 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
This use of LR previously allowed overwriting it with arbitrary addresses that aren't signed. Change this so we never return to an arbitrary LR. Instead of loading the InterpreterTrampolineEntry address into LR directly, use an ADR instruction to place into LR the address of a piece of code that jumps to the InterpreterTrampolineEntry instead. This makes a difference because BR is also constrained by BTI, whereas RET isn't. An alternative would have been to `Call` instead of `Jump` to the target bytecode and avoid the ADR instruction altogether, but I wanted to keep the same behaviour with respect to the return stack that the existing code exhibits. Also add a comment to src/regexp/arm64/regexp-macro-assembler-arm64.cc for a similar use of LR that should eventually be removed. Bug: v8:10026 Change-Id: I24a13481f3fa416247dab8f9e5ae6f52f6b2ad42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764761Reviewed-by:
-
Shu-yu Guo authored
Calls with a spread expression in a non-final position get transformed to calls to Reflect.apply. This transformation is currently done in the parser, which does not compose well with other features (e.g. direct eval checking, optional chaining). Do this transform in the BytecodeGenerator instead. Bug: v8:11573, v8:11558, v8:5690 Change-Id: I56c90a2036fe5b43e0897c57766f666bf72bc3a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2765783 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Jakob Gruber authored
When making inlining decisions in the JSInliningHeuristic, it's possible that a Node is not a candidate on the first visit, but becomes a candidate in later visits due to other node reductions. These later visits should also result in the inlining decision being made. Until now this was prevented by the visit aborting early since the Node was added to the seen_ list on the first (unsuccessful) visit. This CL changes the seen_ insertion to happen only once a positive inlining decision was made. Change-Id: Ide7f6abd3c1d9759d7422fcd5ad9c7daff825795 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764759 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#73533}
-
Santiago Aboy Solanes authored
`has_non_instance_prototype` can be modified in live objects. For the native context's map that we serialize on the background this bit is "set" but it doesn't change value (i.e. it is set to false when it was already false). Bug: v8:7790, v8:11575 Change-Id: I070c0f0e383250d0e3cb92065d1113662976cabf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772609 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Restore of https://chromium-review.googlesource.com/c/v8/v8/+/2194012. I changed it to be non-atomic and missed the fact that the concurrent marker accesses the has_prototype_slot concurrently. Bug: v8:7790, v8:11353 Change-Id: I292aeacb340b6340c40b633db2591c7d0cbca3bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772608Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73531}
-
Leszek Swirski authored
Bug: chromium:1011762 Change-Id: I960b3f57fa29f25d4cda038304825375ada686b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2108039 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#73530}
-
Leszek Swirski authored
Add an always_sparkplug testing variant, and fix a couple of issues it found. Bug: v8:11420 Change-Id: I7d87a41e3413f40271a0140118531f075d633b23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773047Reviewed-by:
Patrick Thier <pthier@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73529}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ff9d9de..100ae19 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/c93be42..4e07843 Rolling v8/third_party/aemu-linux-x64: fU_J9KtzLrfiXhqpf_1eV01gy30M641raluN5uaKPNAC..ASZAw9q3qc9gzTTRn-mGL72ir5Z_qIi5GvZGRBYa4sMC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2737963..9757ad5 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/41f9e2d..283bb29 Rolling v8/tools/luci-go: git_revision:e81c0c9c528d0a416922e4ccd958d0de59a64816..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d Rolling v8/tools/luci-go: git_revision:e81c0c9c528d0a416922e4ccd958d0de59a64816..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d Rolling v8/tools/luci-go: git_revision:e81c0c9c528d0a416922e4ccd958d0de59a64816..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iefca39aa2842894aaa4ec039bad4862533cbf0e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2774713Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73528}
-
Ng Zhi An authored
- Use movhlps instead of pshufd if dst == src - use xorps with punpckhdq instead of two shuffles Bug: v8:11470 Change-Id: I50f77b8591372cccca48b9a6078fc3132fe48a2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773902Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73527}
-
- 18 Mar, 2021 16 commits
-
-
Ng Zhi An authored
This is a reland of 1a69d8d8 The fix is to skip this regression test on systems that do not support SIMD. Original change's description: > [wasm-simd] Fix i32x4.extadd_pairwise_i16x8_u codegen > > It did not handle the case where dst == src. We switch the registers > used around to write to scratch first and ensure we don't overwrite dst. > > Bug: chromium:1187831 > Change-Id: Idf447aa1a3eff3920f2dfa3e0ec11efae37778cd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762425 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73521} Bug: chromium:1187831 Change-Id: I1bb6f4ce69f98064d3da5113e3b4c5a4f75a08c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2774133Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73526}
-
Junliang Yan authored
Change-Id: I505ea67af31006f3f233eef390f234cfc0188d6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2774479Reviewed-by:
-
Ng Zhi An authored
Move them from post-mvp to relaxed-simd flag. We will have a follow up change to move all the relaxed-simd tests into their own file. Bug: v8:11583 Change-Id: Iea9809a309bac428c856e5d0bd024fe0070d5921 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773898Reviewed-by:
-
Junliang Yan authored
Change-Id: I1dd37b86634aae67a0cb7f0bf4d5b21e1f1845df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773803Reviewed-by:
-
Clemens Backes authored
This reverts commit 1a69d8d8. Reason for revert: Fails on nosse: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux/41365/overview Original change's description: > [wasm-simd] Fix i32x4.extadd_pairwise_i16x8_u codegen > > It did not handle the case where dst == src. We switch the registers > used around to write to scratch first and ensure we don't overwrite dst. > > Bug: chromium:1187831 > Change-Id: Idf447aa1a3eff3920f2dfa3e0ec11efae37778cd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762425 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73521} Bug: chromium:1187831 Change-Id: I40d360b16338ef52e7e4327d4166c194ee950827 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773802 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73522}
-
Ng Zhi An authored
It did not handle the case where dst == src. We switch the registers used around to write to scratch first and ensure we don't overwrite dst. Bug: chromium:1187831 Change-Id: Idf447aa1a3eff3920f2dfa3e0ec11efae37778cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762425Reviewed-by:
-
Leszek Swirski authored
In the TestTypeOf handler, use the statically known value of the type-of literal flag to emit the specific type-of check for that type, rather than going to the general type-of builtin. These checks are very simple, so we can get away with hand-writing them in the baseline compiler. Bug: v8:11420 Change-Id: Id9f51042916abaea62f929a2f95cf2c64dc32ee3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772613 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
-
Ng Zhi An authored
This is not used anywhere yet, and will be later used to gate instructions like FMA (which is prototyped). Bug: v8:11583 Change-Id: I2eac60cde6998490fcf3aee11c618ab5478346ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2770605Reviewed-by:
-
Michael Achenbach authored
This reverts commit f187d0a1. Reason for revert: https://crbug.com/v8/11587 Original change's description: > [test] Extend testing on Mac on arm64 > > Ensure more testing of --future for different test types on Mac. > > No-Try: true > Bug: v8:11527 > Change-Id: Iac499dc48dde3342ad2057f86ef1ad5fa43b4eac > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772981 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73514} Bug: v8:11527, v8:11587 Change-Id: I76a1baccdf20ed32b02fe8509ae13f7b62651592 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773051 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73518}
-
Clemens Backes authored
The test was extended in this CL: https://crrev.com/c/2762420 It now uses wasm::SimdShuffle, which is only available if webassembly is enabled. Thus, #if out the test if webassembly is disabled. Drive-by: Add a missing include. R=jkummerow@chromium.org CC=zhin@chromium.org Bug: v8:11238 Change-Id: I1b53d0145467b58616a161944fb88d2ca256fd58 Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772978Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73517}
-
Frank Emrich authored
This CL is part of a series that adds the C++ implementation of SwissNameDictionary, a deterministic property backing store based on Swiss Tables. This CL adds test-swiss-name-dictionary-infra.[h|cc], which contain the infrastructure for writing tests that simulatenously check the C++ and CSA/Torque implementation of SwissNameDictionary operations. The actual tests are added in a subsequent CL, which will be the last of this series. Bug: v8:11388 Change-Id: I89cbc7e575ed694fe34cb66c0e1ec70683504bd8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742574Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Frank Emrich <emrich@google.com> Cr-Commit-Position: refs/heads/master@{#73516}
-
Leszek Swirski authored
This reverts commit c4b44d5d. Reason for revert: UBSan failures (https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/15621/overview) Original change's description: > [bigint] Begin src/bigint refactoring > > This patch moves a first function, Compare, from src/objects/bigint.cc > to src/bigint/, to blaze the trail. More to follow! > > Bug: v8:11515 > Change-Id: Id7fa0b40ea852dbed1360f7ab439cb32d0c15762 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2737295 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73511} Bug: v8:11515 Change-Id: I98f3e385c785297b1b71de07fc4835da2bbe816c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773048 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73515}
-
Michael Achenbach authored
Ensure more testing of --future for different test types on Mac. No-Try: true Bug: v8:11527 Change-Id: Iac499dc48dde3342ad2057f86ef1ad5fa43b4eac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772981Reviewed-by:
-
Clemens Backes authored
We do not emit this opcode in the asm.js to wasm translator, hence we do not need to handle this case in the function body decoder. Replace it by a DCHECK to catch bugs where we might accidentally emit the opcode. R=thibaudm@chromium.org Change-Id: Ibaa07099f30b871c28e3d3cebae96277f46e3164 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2768619Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73513}
-
Milad Fa authored
Port d16eefe0 Original Commit Message: We currently canonicalize shuffles in the architecture specific instruction selector. This has the drawback that if we want to pattern match on nodes that have a shuffle as input, they need to individually canonicalize the shuffle. There can also be a subtle bug if we canonicalize the same shuffle node twice (see bug for details). This moves the canonicalization to "construction time", in wasm-compiler, when building the graph. As such, any pattern matches in instruction-selector will only need to deal with canonicalized shuffles. We introduce a new kind of parameter for shuffle nodes, ShuffleParameter, to store the 16 bytes plus a bool indicating if this is a swizzle. A swizzle essentially: inputs to the shuffle are the same or all indices only touch 1 input. We calculate this when canonicalizing, so store this bit of information inside of the node's parameter. We update the tests in x64 to handle special cases where, even though the node's inputs are not swapped (due to canonicalization), they need to be swapped for the specific instruction selected (e.g. palignr). The test data also contains canonicalized shuffles, so we have to manually canonicalize them. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I9872fcdaa06739c8972f02d81e77bcbf372126c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773138Reviewed-by:
-
Jakob Kummerow authored
This patch moves a first function, Compare, from src/objects/bigint.cc to src/bigint/, to blaze the trail. More to follow! Bug: v8:11515 Change-Id: Id7fa0b40ea852dbed1360f7ab439cb32d0c15762 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2737295Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73511}
-
