• Benedikt Meurer's avatar
    [wasm][inspector] Don't use `Script::source_url` to store URL. · c0ee8f90
    Benedikt Meurer authored
    The `Script::source_url` field holds the value of the magic
    `//# sourceURL` comment if found, and the `Script::name` field is
    supposed to hold the actual name of the resource (as provided by
    the embedder ideally), in case of Chromium that's supposed to be
    the URL (in case of Node.js it's often the local path).
    
    Using `source_url` worked by chance so far, but for loading DWARF
    symbol files correctly we need the initiator (which we pick from
    the embedderName of the Script as reported to DevTools). More
    importantly, the partial handling of `//# sourceURL` in V8 is a
    layering violation and causes trouble in DevTools, i.e. when users
    put relative paths here. So as part of refactoring and correctifying
    the handling of `//# sourceURL`, we need to make sure that the embedder
    provided name (the URL in case of Chromium) is always stored in the
    `Script::name` field.
    
    Bug: chromium:1183990, chromium:974543, chromium:1174507
    Change-Id: I32e11def2b9b52be11bd2e0e64a2ab6bdcf5e52d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773584
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73536}
    c0ee8f90
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...