• Georgia Kouveli's avatar
    [cfi][arm64] Change InterpreterEnterBytecode use of LR for CFI. · ce85e66a
    Georgia Kouveli authored
    This use of LR previously allowed overwriting it with arbitrary addresses
    that aren't signed. Change this so we never return to an arbitrary LR.
    
    Instead of loading the InterpreterTrampolineEntry address into LR directly,
    use an ADR instruction to place into LR the address of a piece of code
    that jumps to the InterpreterTrampolineEntry instead. This makes a difference
    because BR is also constrained by BTI, whereas RET isn't.
    
    An alternative would have been to `Call` instead of `Jump` to the target
    bytecode and avoid the ADR instruction altogether, but I wanted to keep the
    same behaviour with respect to the return stack that the existing code
    exhibits.
    
    Also add a comment to src/regexp/arm64/regexp-macro-assembler-arm64.cc for
    a similar use of LR that should eventually be removed.
    
    Bug: v8:10026
    Change-Id: I24a13481f3fa416247dab8f9e5ae6f52f6b2ad42
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764761Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com>
    Cr-Commit-Position: refs/heads/master@{#73535}
    ce85e66a
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...