• Milad Fa's avatar
    PPC/s390: [wasm-simd] Canonicalize shuffles when creating TurboFan graph · d95b1645
    Milad Fa authored
    Port d16eefe0
    
    Original Commit Message:
    
        We currently canonicalize shuffles in the architecture specific
        instruction selector. This has the drawback that if we want to pattern
        match on nodes that have a shuffle as input, they need to individually
        canonicalize the shuffle. There can also be a subtle bug if we
        canonicalize the same shuffle node twice (see bug for details).
    
        This moves the canonicalization to "construction time", in
        wasm-compiler, when building the graph. As such, any pattern matches in
        instruction-selector will only need to deal with canonicalized shuffles.
    
        We introduce a new kind of parameter for shuffle nodes,
        ShuffleParameter, to store the 16 bytes plus a bool indicating if this
        is a swizzle. A swizzle essentially: inputs to the shuffle are the same
        or all indices only touch 1 input. We calculate this when
        canonicalizing, so store this bit of information inside of the node's
        parameter.
    
        We update the tests in x64 to handle special cases where, even though
        the node's inputs are not swapped (due to canonicalization), they need
        to be swapped for the specific instruction selected (e.g. palignr). The
        test data also contains canonicalized shuffles, so we have to manually
        canonicalize them.
    
    R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com
    BUG=
    LOG=N
    
    Change-Id: I9872fcdaa06739c8972f02d81e77bcbf372126c2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773138Reviewed-by: 's avatarJunliang Yan <junyan@redhat.com>
    Commit-Queue: Milad Fa <mfarazma@redhat.com>
    Cr-Commit-Position: refs/heads/master@{#73512}
    d95b1645
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...