[compiler] Enable off-thread finalization by default

Bug: chromium:1011762
Change-Id: I960b3f57fa29f25d4cda038304825375ada686b9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2108039
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73530}

src/flags/flag-definitions.h

@@ -1301,11 +1301,11 @@ DEFINE_BOOL(script_streaming, true, "enable parsing on background")
 DEFINE_BOOL(stress_background_compile, false,
             "stress test parsing on background")
 DEFINE_BOOL(
-    finalize_streaming_on_background, false,
+    finalize_streaming_on_background, true,
     "perform the script streaming finalization on the background thread")
 // TODO(leszeks): Parallel compile tasks currently don't support off-thread
 // finalization.
-DEFINE_NEG_IMPLICATION(finalize_streaming_on_background, parallel_compile_tasks)
+DEFINE_NEG_IMPLICATION(parallel_compile_tasks, finalize_streaming_on_background)
 DEFINE_BOOL(disable_old_api_accessors, false,
             "Disable old-style API accessors whose setters trigger through the "
             "prototype chain")

tools/testrunner/local/variants.py

@@ -31,7 +31,6 @@ ALL_VARIANT_FLAGS = {
   "stress_concurrent_allocation": [["--stress-concurrent-allocation"]],
   "stress_concurrent_inlining": [["--stress-concurrent-inlining"]],
   "stress_js_bg_compile_wasm_code_gc": [["--stress-background-compile",
-                                         "--finalize-streaming-on-background",
                                          "--stress-wasm-code-gc"]],
   "stress_incremental_marking": [["--stress-incremental-marking"]],
   "stress_snapshot": [["--stress-snapshot"]],
@@ -58,8 +57,8 @@ INCOMPATIBLE_FLAGS_PER_VARIANT = {
   "stress_concurrent_allocation": ["--single-threaded-gc", "--predictable"],
   "stress_concurrent_inlining": ["--single-threaded", "--predictable", "--no-turbo-direct-heap-access"],
   "stress_incremental_marking": ["--no-stress-incremental-marking"],
-  "future": ["--parallel-compile-tasks", "--no-turbo-direct-heap-access"],
-  "stress_js_bg_compile_wasm_code_gc": ["--no-stress-background-compile", "--parallel-compile-tasks"],
+  "future": ["--no-turbo-direct-heap-access"],
+  "stress_js_bg_compile_wasm_code_gc": ["--no-stress-background-compile"],
   "stress": ["--no-stress-opt", "--always-opt", "--no-always-opt", "--liftoff", "--max-inlined-bytecode-size=*",
              "--max-inlined-bytecode-size-cumulative=*", "--stress-inline"],
   "sparkplug": ["--jitless", "--no-sparkplug" ],
@@ -101,7 +100,7 @@ INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = {
   "--stress_concurrent_allocation": ["--single-threaded-gc", "--predictable"],
   "--stress_concurrent_inlining": ["--single-threaded", "--predictable"],
   "--stress-flush-bytecode": ["--no-stress-flush-bytecode"],
-  "--future": ["--parallel-compile-tasks", "--no-turbo-direct-heap-access"],
+  "--future": ["--no-turbo-direct-heap-access"],
   "--stress-incremental-marking": INCOMPATIBLE_FLAGS_PER_VARIANT["stress_incremental_marking"],
 }