• Jakob Gruber's avatar
    [compiler] Visit-order-independent inlining heuristics · 2dd02967
    Jakob Gruber authored
    When making inlining decisions in the JSInliningHeuristic, it's
    possible that a Node is not a candidate on the first visit, but
    becomes a candidate in later visits due to other node reductions.
    
    These later visits should also result in the inlining decision being
    made. Until now this was prevented by the visit aborting early since
    the Node was added to the seen_ list on the first (unsuccessful)
    visit.
    
    This CL changes the seen_ insertion to happen only once a positive
    inlining decision was made.
    
    Change-Id: Ide7f6abd3c1d9759d7422fcd5ad9c7daff825795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764759
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73533}
    2dd02967
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...