- 02 Nov, 2020 5 commits
-
-
Zhi An Ng authored
These instructions require SSE4_1, we need to enable SSE4_1 before calling them. These will only fail when there is no AVX and no SSE4_2, and we unfortunately is not a configuration we test (we test for no-AVX, and no-AVX && no-SSE4_1 (which also means no-SSE4_2) && no-SSSE3 and no-SSE3). Change-Id: I3d49b9c68385c4b5b631c4a82e5e46d388500c06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2513869Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70910}
-
Clemens Backes authored
This also extracts the {FrontendChannelImpl}, the {SetTimeoutTask}, and the {SetTimeoutExtension} for reuse by the inspector fuzzer. R=szuend@chromium.org Bug: chromium:1142437 Change-Id: I75e49d6fbb4b801ace1ffc9cac963d6b83c52f36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505717Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70909}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0dfb09a..eb675d7 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic43d9ba2687399b41e04672356163ed075ec6f4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512779Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#70908}
-
Zhi An Ng authored
Bug: v8:11038 Change-Id: Ifb50d8667b03afa045a957ffc8f3df799252e561 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2500939Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70907}
-
Zhi An Ng authored
Similar to the changes in the disassembly, break up simulator changes into smaller functions. This change only copy pastes implementation into various helper function, and does not follow the decoding rules in the manual yet, it is still using SpecialValue. Subsequent changes will clean this up. Bug: v8:11074 Change-Id: Ic2905406e905fc3df01825047763d083aa0fbff4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505248Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70906}
-
- 01 Nov, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/079c81c..0dfb09a Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7030291..dcd4fb3 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4dbfc06c044626d24160d42d5adf08e9ae968960 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512546Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#70905}
-
- 31 Oct, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b8645e7..079c81c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/24bd418..7030291 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e8dff37..9396c2b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/12b3cd3..e5230a2 Rolling v8/tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596 Rolling v8/tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596 Rolling v8/tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I52b4a621b1b1b74d3f4e7071cf438154f30ef5bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512544Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#70904}
-
- 30 Oct, 2020 14 commits
-
-
Camillo Bruni authored
- Introduce LazyTable that only shows the first 100 entries and can lazily expand - Make StatsPanel.update method async to not block the UI - Show "Total" entry as last item in StatsPanel tables - Fix StatsPanel table entries text alignment - Remove unused getters from StatsPanel class Drive-by-fix: - MapPanel._displayedMapsInTree is undefined when expanding to a sub-transition tree Bug: v8:10644 Change-Id: I5ce7c8b1ee825515cf790a3e52534c3069d8be89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507716 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#70903}
-
Milad Fa authored
Change-Id: Icd452df211c85d83c82812124d14fe6a31e733b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509553Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#70902}
-
Etienne Pierre-doray authored
IsCompleted is backwards. For a more consistent api, the function is renamed IsActive and logic is flipped. Following up on https://chromium-review.googlesource.com/c/v8/v8/+/2461840 The intend is to make the distinction between IsActive and IsValid obvious. Change-Id: Iaf00b9f6ffa8f1efe93ae29f09899737ef20f04d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2510969Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#70901}
-
Georg Neis authored
After c90ff8bd this is purely a cosmetic change. Change-Id: If804f1b7558ab2f8096e576570f68b848df7423c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509592Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#70900}
-
Michael Lippautz authored
- Provide GetRealStackAddressForSlot that deals with ASAN fake stacks properly, also accounting for the fact that ASAN gets its real stack address in a nested call. - Fix cppgc on-stack getter. - Reuse platform routines in global handles. Bug: chromium:1139914, chromium:1056170 Change-Id: If11a40d543b33edcea220bb70f170ac018e15053 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509594 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#70899}
-
Clemens Backes authored
The idea was to distribute the publish limits to reduce the chance that different tasks are publishing at the same time. We always used the same task_id to compute the limits though, so all queues had the same limit. This CL fixes that by using the task id of the respective queue. R=thibaudm@chromium.org Change-Id: I5231aa35b2b53d625fafbb2130b886390fb7d38a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2502292Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70898}
-
Michael Lippautz authored
We previously assumed that a fake stack should be mapped back to a real stack based on fake-stack offsets. This is not correct: Fake and real stack are disjoint and both contain the corresponding slot values. For global handles this means that on-stack handles must be registered using their real stack frame base to be able to purge them occasionally based on the current stack address. When dealing with a slot though, the GC can just dereference the slot for a value, indeppendent of whether the slot is in a fake or real frame. Drive-by: Fix tests that do not want stack handles by creating handles on heap. Change-Id: I2c86c8e047bd0d48c24c2642b2b4dba284a93909 Bug: chromium:1139914 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507720 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#70897}
-
Andreas Haas authored
This function is equivalent to CheckHasMemory by now. R=clemensb@chromium.org Bug: v8:11074 Change-Id: I05fbd160d6e5b8d7433133052a8390521564632b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509590Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#70896}
-
Almothana Athamneh authored
Relanding after failing test on ia32 was fixed. Bug: v8:11072 Change-Id: I939ed92f8fb7ea84314a79eb62f0d4aed272bea3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509589Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#70895}
-
Benedikt Meurer authored
Building these objects takes a lot of time and memory for realistic applications and exposing them via the Scope view in DevTools isn't practical either. We have a replacement in the Console now, and if this needs more exposure we can think about other, more scalable ways with better UX. Fixed: v8:10986 Bug: chromium:1141781 Change-Id: I6177d63a987749889a9880cf0738031191eb5705 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507696 Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70894}
-
Zhi An Ng authored
These operations can be moved into an existing macro list, since they are simple operations that generate only 1 instruction. The benefit is that they have support for AVX 3-operand instruction, and does not have to force dst to be equals to src. Bug: v8:9561 Change-Id: I9ec1d2496d14cb9f0fb3b4854ca39887eb5bf49b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505240Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70893}
-
Martin Bidlingmaier authored
This commit adds the 'l' (linear) RegExp flag (as in e.g. /asdf|123/l) that forces execution in linear time. These regexps are handled by the experimental engine. If the experimental engine cannot handle the pattern, an exception is thrown on creation of the regexp. The commit also adds a new global V8 flag and changes an existing one: * --enable-experimental-engine, which turns on recognition of the RegExp 'l' flag. Previously this flag also caused all supported regexps to be executed by the experimental engine; this is not the case anymore. * --default-to-experimental-regexp-engine takes over the previous semantics of --enable-experimental-regexp-engine: We execute all supported regexps with the experimental engine. Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Bug: v8:10765 Change-Id: I5622a89b19404105e8be280d454e9fdd63c003b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461244Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Martin Bidlingmaier <mbid@google.com> Cr-Commit-Position: refs/heads/master@{#70892}
-
Leszek Swirski authored
GeneralizeField already calculates the field owner. Change-Id: I0730471479d4289d3d027ea63178ddae659ee2b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507717 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#70891}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/acfd692..b8645e7 Rolling v8/third_party/aemu-linux-x64: zy6Zme4YpIqml3lhXc3o7a0r_gVd0_gcggle2n2j330C..uqYfh08DTmvjUgXl-HxNY1ptIb0KpyuY0I9MFaci9-AC Rolling v8/third_party/android_sdk/public: ijpIFSitwBfaEdO9VXBGPqDHUVzPimXy_whw3aHTN9oC..V__2Ycej-H2-6AcXX5A3gi7sIk74SuN44PBm2uC_N1sC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/15be7eb..24bd418 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/f9b4a22..12b3cd3 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8250aad9d82eb7ec2f5da2aa60b2dee040df6612 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507341Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#70890}
-
- 29 Oct, 2020 19 commits
-
-
Zhi An Ng authored
The main fix here is on non-AVX builds, the shifts require dst == src. Calling macro-assembler functions like Psrlw assumes that we already met that requirement (which we usually specify in TurboFan's instruction-selector). On Liftoff, we need to do that check manually. This is done by using the helper EmitSimdShiftOpImm which will do this check, and dispatches to AVX if supported, or mov if dst != src. Also fix a couple of places where we forgot to annotate the required SSE extension for the instruction. Bug: v8:11078 Change-Id: Icc31df9ab80c041f4bb3bd48444658368eaa2c91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505251Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70889}
-
Zhi An Ng authored
On AVX, many instructions can have 3 operands, unlike SSE which only has 2. So on SSE we use DefineSameAsFirst on the dst. But on AVX, using that will cause some unnecessary moves. This change moves a bunch of instructions that have single instruction codegen into a macro list which supports the this non-restricted AVX codegen. Bug: v8:9561 Change-Id: I348a8396e8a1129daf2e1ed08ae8526e1bc3a73b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505254Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70888}
-
Leszek Swirski authored
When searching for a target map during map update, attempt to update field representations in-place to the more general representation, where possible. Bug: chromium:1143772 Change-Id: I6a43c94910a1d2d8f8b0ad89048f94b51461f76c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507715 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#70887}
-
Camillo Bruni authored
- Use initial color for TimelineTrack chunks - Use async functions for TimelineTrack setChunkBackgrounds - Introduce timeSelection setter on TimelinePanel - Propagate time selection down to the TimelinePanel - Avoid layout recalculation in TimelineTrack updateSelection drive-by-cleanups: - Add common event listeners only to top-level document - Use console.warn instead of console.error for better debugging in DevTools Bug: v8:10644 Change-Id: Ie4f80f1c6c3f4fa193f8ac01225e0fb76981551d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2497175 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#70886}
-
Milad Fa authored
Change-Id: I875efc2db384742ca7e6b68099321504ca79a8d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2508689Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#70885}
-
Ulan Degenbaev authored
This allows GC to go slightly over the max heap limit in order to give NearHeapLimitCallback a chance to run and increase the limit. Based on the suggestion by Kenton Varda. Change-Id: I9c084b5a4c8fb7b9ce331b565958391c1be56add Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505724 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#70884}
-
Milad Fa authored
We need to load 32 bits into optimization_state. Change-Id: Id6024e33b65c92696366900098c9768b192a7160 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507265 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#70883}
-
Clemens Backes authored
Big partners are still hitting the code space limit, especially when debugging larger wasm apps. The limits was bumped to 2GB in August, but we already have security clearance to increase it to 4GB. A limit of exactly 4GB is problematic on 32-bit systems, and also on 64-bit we seem to store the limit in a uint32_t sometimes. Thus choose a limit slighly below 4GB, such that it fits in a 32-bit integer. R=ecmziegler@chromium.org Bug: chromium:1143118 Change-Id: If37f87280264c395cf73b3cc3bf6f7b1b27c46d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505768 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#70882}
-
Shu-yu Guo authored
Fix super calls so that arguments are evaluated before the super constructor is checked to be in fact a constructor. A new bytecode is introduced to split the IsConstructor check out from the current GetSuperConstructor bytecode. Bug: v8:10111 Change-Id: I3af99e32a34d99493806bb01b547d6f671cdc9de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2493077 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#70881}
-
Dominik Inführ authored
Merge the list of concurrently swept ArrayBufferExtensions sooner back to the main thread. When appending a new ArrayBufferExtension check whether the concurrent sweeping was already finished and merge the lists if it is. In order to reduce the number of GCs in the linked test case, reset young_bytes_ and old_bytes_ to 0 while sweeping the ArrayBufferExtensions. Surviving extensions will be accounted again when merging lists. As a drive-by change remove scavenge.process_array_buffers from GCTracer. GCTracer also printed the wrong value for fast_promote. Bug: v8:11044 Change-Id: I8a772df895c43a69493015f42336c6f33fe52056 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505764Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#70880}
-
Liu Yu authored
The optimization state is a 32-bit value, so we should load it by lw instruction instead of ld. Change-Id: I5845341ea9b87568fda08180ed51ad1a5c0635e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507312Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#70879}
-
Dan Elphick authored
TODO says gcc can't handle Local, but it is using Local. Bug: v8:11074 Change-Id: I4c5045abc319e82eb86f8e23c879db07b4cee13a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505767 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#70878}
-
Nico Hartmann authored
This is the 1st step in series of CLs to move the SharedFunctionInfo class to kNeverSerialized and make it concurrently accessible from the background thread. This CL: * Enables direct heap reads for the most basic members of SFI if FLAG_turbo_direct_heap_reads is enabled. * Adds synchronization to SharedFunctionInfo::script_or_debug_info. Bug: v8:7790 Change-Id: Ia7d28033e9053aae5771b1b9b174de40f194534d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461238Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#70877}
-
Frank Emrich authored
This CL changes the "small" versions of ordered hash tables, like SmallOrderedNameDictionary and the corresponding handlers, like OrderedNameDictionaryHandler, to use InternalIndex rather than int as the type used for indices. This is part of an effort to make the interfaces of the ordered and unordered name dictionaries more similar. Bug: v8:7569 Change-Id: I3b6fe79dfd3c6743f58a04cfe82798fe2ef09e19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505720 Commit-Queue: Frank Emrich <emrich@google.com> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#70876}
-
Jakob Gruber authored
These aren't called from or implemented in assembly, thus the exact registers don't matter. We can remove platform-specific definitions. This resolves 56 TODOs! )) Bug: v8:8888 Change-Id: I287fbf7eb3c03d7467ff58a27d614163baf34b3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505761Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#70875}
-
Jakob Gruber authored
For-in now collect feedback as well, the test passes. Tbr: neis@chromium.org Bug: v8:8888 Change-Id: I4e2ae41b60aa43132a24f001dc4de460a270a1a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505766Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#70874}
-
Frank Emrich authored
This changes the ordered hash data structures in ordered-hash-table.h to use InternalIndex as the type used for indices, rather than int. This makes the interface more similar to the (unordered) hash tables in dictionary.h and hash-table.h Bug: v8:7569 Change-Id: I2389b0c7d103eb7c33c5ed620b16eb198109b54c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2503949 Commit-Queue: Frank Emrich <emrich@google.com> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#70873}
-
Santiago Aboy Solanes authored
Inside of LoopPeeler::PeelInnerLoopsOfTree we call the typer, which inspects heap objects, so we need to unpark the local heap. Reverted in https://chromium-review.googlesource.com/c/v8/v8/+/2502333 Original change's description: > [compiler] Replace Symbol with direct reads > > Bug: v8:7790 > Change-Id: I49120a6349777fd992a97d697940e79b2e71dbd1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2400988 > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69812} Bug: v8:7790, chromium:1137594 Change-Id: I8539175002e19b04b84009eb6b2cc5ced4ee53c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2502339 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#70872}
-
Andreas Haas authored
This is a reland of 757f0431 There was a bug in a TurboFan optimization that was fixed in https://chromium-review.googlesource.com/c/v8/v8/+/2504250 Original change's description: > [wasm] Enable --wasm-opt > > This CL enables basic optimizations in TurboFan for WebAssembly code, > like dead code elimination (DeadCodeElimination), constant folding > (MachineOperatorReducer), and control flow optimizations > (CommonOperatorReducer). > > These optimizations were disabled originally to improve startup time, > at the expense of slower generated code. However, with Liftoff as the > baseline compiler, startup time is not so important anymore for > TurboFan. > > R=clemensb@chromium.org > CC=manoskouk@chromium.org > > Change-Id: I2a81f66929c43fbbdfc3625359772c8ea0f2235f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2488684 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70691} Change-Id: Ia3f6f48649c329b9a49e038264dd12f7d872d275 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504265Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#70871}
-