• Michael Lippautz's avatar
    global-handles: Fix ASAN fake stack handling · aad7b7ff
    Michael Lippautz authored
    We previously assumed that a fake stack should be mapped back to a
    real stack based on fake-stack offsets. This is not correct: Fake and
    real stack are disjoint and both contain the corresponding slot
    values.
    
    For global handles this means that on-stack handles must be registered
    using their real stack frame base to be able to purge them
    occasionally based on the current stack address.
    
    When dealing with a slot though, the GC can just dereference the slot
    for a value, indeppendent of whether the slot is in a fake or real
    frame.
    
    Drive-by: Fix tests that do not want stack handles by creating
    handles on heap.
    
    Change-Id: I2c86c8e047bd0d48c24c2642b2b4dba284a93909
    Bug: chromium:1139914
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507720
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70897}
    aad7b7ff
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...