• Zhi An Ng's avatar
    [wasm-simd][liftoff][ia32] Fix operands on non-AVX · 236aff1b
    Zhi An Ng authored
    The main fix here is on non-AVX builds, the shifts require dst == src.
    Calling macro-assembler functions like Psrlw assumes that we already
    met that requirement (which we usually specify in TurboFan's
    instruction-selector). On Liftoff, we need to do that check manually.
    This is done by using the helper EmitSimdShiftOpImm which will do this
    check, and dispatches to AVX if supported, or mov if dst != src.
    
    Also fix a couple of places where we forgot to annotate the required SSE
    extension for the instruction.
    
    Bug: v8:11078
    Change-Id: Icc31df9ab80c041f4bb3bd48444658368eaa2c91
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505251Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70889}
    236aff1b
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...