- 17 Mar, 2021 11 commits
-
-
Michael Lippautz authored
Previously, GCInfoTrait relied on the non-trivial constructor of a static object for registering a new GCInfo object. The generated code is required to be thread-safe which is achieved by introducing guard variables in the compiler. The new version is similar to Blink in that it relies on zero initialization of a trivially constructible atomic. Compared to guard variables that are created per GCInfo registration, the atomic creates less bloat (~20bytes/type) and also results in a better fast path. Minimum example: https://godbolt.org/z/qrdTf8 Bug: chromium:1056170 Change-Id: I95efbbf035b655d0440c9477f5391e310e2b71fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764750Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73463}
-
Omer Katz authored
Copy over from Blink two tests that the library was missing. Bug: chromium:1056170 Change-Id: If4349e8c4dc0036f4894d274e5d38e63b0390c4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764751 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73462}
-
Manos Koukoutos authored
Changes: - Remove the restriction that ref.test, ref.cast and br_on_cast may only cast to subtypes of the cast object's type. Optimize unrelated type casts in the decoder. Add tests. - Generalize Unreachable() interface function to Trap(TrapReason). - Fix rtt.sub to be able to accept an rtt without depth. Modify related test accordingly. - Type local.tee according to the local's type as opposed to the value's type. Bug: v8:7748, v8:11541 Change-Id: I4d1846a2cfda891d32a9c1ed26781e4518d4cdf9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756210Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73461}
-
Santiago Aboy Solanes authored
We can ensure that the constructor is set before the map is set on the JSObject. Setting the constructor remains non-atomic. Bug: v8:7790 Change-Id: Ie65519f61e29c9bed89bf09f582aa8bd39de1b03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2761199Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73460}
-
Camillo Bruni authored
- Sort by labels if no category is selected - Support page separators in simple txt files. - Fix un-toggling subcategories - Prompt for labels when loading multiple files - Improve parsing performance by using raw for-loops and fixing regexps Change-Id: Ibd388e4134b4c0722a7f44d7eb4c5c56748e5175 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759511 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#73459}
-
Igor Sheludko authored
This is a speed-for-memory tradeoff, which can be achieved by re-mapping the builtins code blob into existing code range. The feature can be enabled by v8_enable_short_builtin_calls flag and it's off by default. This CL adds GN flag and updates code generator to emit shorter pc-relative calls/jumps to builtins. However, the runtime doesn't support appearance of the off-heap builtins' PCs that point to the embedded code blob on the stack yet. Bug: v8:11527, v8:11421 Change-Id: Iaba384c549675852beae70739175976ee193ffef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727502Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73458}
-
Liu Yu authored
Port: 3f9ff062 Bug: v8:11238 Change-Id: I3ac454b7ea1addbbf41407c7acd6a18da7b35d10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763965 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Since unboxed doubles are removed already, MigrateFastToSlow doesn't need to invalidate old-to-old-slots anymore. Bug: chromium:1188483 Change-Id: I0875fc0c8bcf8086f22678ffbbef000fd94ea7ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764745Reviewed-by:
-
Jakob Gruber authored
.. which was previously broken due to 1. a hardcoded impl names list and 2. the addition of a new impl (riscv). The new solution prevents this in the future by basing both enum and name generation on a macro list. Bug: v8:11572 Change-Id: Ieb2134c9ecf3729633b76e4a30e7ddceba396328 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764752 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Nico Hartmann authored
This reverts commit 220e68c0. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1188563 Original change's description: > [TurboFan] Move FunctionTemplateInfo to never serialized > > This CL moves FunctionTemplateInfo to the list of never serialized > objects, allowing direct heap reads. To make this threadsafe, the CL: > - adds necessary atomic (relaxed/acquire-release) operations to the > accessors of FunctionTemplateInfo. > - changes FunctionTemplateInfoRef::LookupHolderOfExpectedType to be > usable from the background thread (e.g. no handle construction) with > the caveat of skipping optimization in some cases where necessary > JSObjects are not serialized. > > Drive-by: Add missing serialization of objects possibly reachable > through CallHandlerInfo::data. > > Bug: v8:7790 > Change-Id: I49cf4f328ecfab368dff9076fde8f5783ead3246 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2679687 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73364} TBR=neis@chromium.org No-Try: true No-Presubmit: true No-Tree-Checks: true Bug: v8:7790 Change-Id: I66fd8d915e2434e3f78103b9e11dce01eb356675 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764753Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#73454}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5081eef..37b76d6 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6d5a4e5..b965b65 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/593a6b5..36de4be Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/91db20b..752611e Rolling v8/tools/luci-go: git_revision:fd10124659e991321df2f8a5d3749687b54ceb0a..git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e Rolling v8/tools/luci-go: git_revision:fd10124659e991321df2f8a5d3749687b54ceb0a..git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e Rolling v8/tools/luci-go: git_revision:fd10124659e991321df2f8a5d3749687b54ceb0a..git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieface3d42f19f682162a61ba7e7cc9570da61401 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764818Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73453}
-
- 16 Mar, 2021 29 commits
-
-
Omer Katz authored
Bug: chromium:1056170 Change-Id: I4b43b78be23b8220b89f1ee5177f6b9b3c18146d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764748 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Sara Tang authored
This is a small change to the ETW instrumentation to enable --interpreted-frames-native-stack so that we can see intepreted functions on the JS call stack (in addition to jit-ted ones). Bug: v8:11043 Change-Id: I17870bda6bc5291d6fe429770a015dd803fe446b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757888Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sara Tang <sartang@microsoft.com> Cr-Commit-Position: refs/heads/master@{#73451}
-
Milad Fa authored
Change-Id: I06633381ad6bfd84090e7553404425d28a90f47a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2765443Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73450}
-
Michael Achenbach authored
No-try: true Bug: chromium:1176141 Change-Id: I6caa0f9ce530ca3fcc6aa715326727f68aa5c240 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2690586Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73449}
-
Omer Katz authored
Bug: chromium:1056170 Change-Id: I6b77c06b8c787a00be00b84490155588608c75da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764464Reviewed-by:
-
Milad Fa authored
Change-Id: I575dffb8810ccc9e73cae2413c7993e0f4fdbbdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764623 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
-
Milad Fa authored
Change-Id: I6dd7a99d464940304cfced8ab301e23e7b658762 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764782Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:11453 Change-Id: I9775032093ac1a0883339cb32bb30b7710f08491 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763877 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
In wasm-compiler, nodes that reference the Isolate and Instance should depend on whether the current frame JS or Wasm. This was implemented with mutable fields caching nodes in WasmGraphBuilder and its subclasses, but was not done consistently. This CL removes all mutability and replaces it with an additional field isolate_ in WasmGraphBuilder, which is only set in the constructor of the child class WasmWrapperGraphBuilder. Additional changes: - Remove three almost-unused utilities from WasmGraphAssembler. - Reduce duplicate BuildImportCall with int index argument to the one with Node* index argument (the additional operations should be optimized away). Bug: v8:11510 Change-Id: I2bb44a617210916edf671c238402727e04bdc38f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739976Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:11453 Change-Id: I8a29f1359b9f77401bba1f6abb8d11221b742176 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763876 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This CL implements the above in a concurrent setting without relying on serialization (except existing serialization to read a consistent JSObject state, which should be addressed in future work). There are three main cases in which GetOwnConstantElement can succeed: - Frozen elements are always constant. The backing store is immutable after initialization and can be accessed through relaxed reads. - String wrapper elements are always constant. The JSPrimitiveWrapper is immutable after initialization, and internalized Strings are protected by a mutex (other string kinds are currently not handled). - Dictionary elements may be constant. Since this case is not particularly important for the optimization, we leave it unimplemented for now. Bug: v8:7790 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_no_cm_rel_ng Change-Id: If2fbced50218ebd3930da8157cd2ae5eb83a8e02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2717308Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Marja Hölttä authored
(See bug for repro.) Bug: v8:11571 Change-Id: I7cf7ddad1c031c476d29edf5a3922c64079c186b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764462Reviewed-by:
-
Clemens Backes authored
Add a test for a module without a start function; in that case, we want to break when first calling into the module (via an exported function). R=bmeurer@chromium.org Bug: chromium:1151211 Change-Id: Id14978b5feff4dcd64cff828951f2a00b73c9736 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763880Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73440}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:11453 Change-Id: I6e73f68f842e9f5de95bed1233bfcc08ab600b43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763873Reviewed-by:
-
Mathias Bynens authored
macOS’s `readlink` doesn’t support the `-f` flag. By using `realpath` we get the same functionality with added support for macOS. Finally, this patch adds `v8` and `v8-debug` to the completion command. These are the binary names used by jsvu [1]. [1]: https://github.com/GoogleChromeLabs/jsvu Bug: v8:11567 Change-Id: I1ec47752e50bce4bfb97a7ce23571d0a6e55dbc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762147 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:1188212 Change-Id: I2c01544e5ff114d4fbdb853a344eb2b6250ee7ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763881Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#73437}
-
Jakob Kummerow authored
Bonus: this contains small regression tests for the issues fixed in https://chromium-review.googlesource.com/c/v8/v8/+/2739586. Fixed: chromium:1186603 Change-Id: I6eca2ef41936555e6fe81555805a659b30023952 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2761201 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Because why not. No-Try: true Bug: v8:11567 Change-Id: I763d9d0c6704f3f8c5e8336e2157336e159648fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762139 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#73435}
-
Ross McIlroy authored
Processing StateValues into operands is one of the most costly parts of instruction selection. As it happens, StateValues are shared by many nodes, and so we are unecessarily reprocessing the same StateValues multiple times. This CL introduces caching for the processed StateValues enabling very fast emitting of operands for subsiquent instructions with the same StateValue. The hitrate for the cache is higher than 90% on most optimizations. BUG=v8:9684 Change-Id: I7edcfa1b0d7add16e509f0e2abeda0a8873f5a95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756535 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
We had two similar methods (HasOnlyStablePrototypesWithFastElements and HasOnlyStablePrototypesWithFastElementsHelper) which seemed to have been defined to be used in different places, but they were used in only one place each. We can specialize those methods based on their uses and not worry about the other cases. Bug: v8:7790 Change-Id: I2341ce4849d421afd960cb199908f9c98511999e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759523Reviewed-by:
-
Santiago Aboy Solanes authored
Most of Map's bit_field (as in not 2 or 3) accessors are not set after construction e.g. is_callable. They are also not used as a synchronization point. From the compiler's point of view, they can be set as non-atomic. There are two accessors (`prototype_slot` and `non_instance_prototype`) that have to be atomic for concurrent marker reasons (relaxed is fine for them). Bug: v8:7790, chromium:1150811 Change-Id: Ic3c81a59e7895ee9c35a128bb10656040b19dd42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752154Reviewed-by:
-
Thibaud Michaud authored
Allocate the TryInfo in a unique_ptr to ensure that its destructor is called when the corresponding control block is popped from the control stack. In particular, the cache state allocates memory on the heap which is otherwise never freed. R=clemensb@chromium.org Bug: chromium:1185127 Change-Id: I3aee5573f99ef94c13d0649413a4e647a32bc555 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739649 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Release-official builds strip error messages from CHECK messages. This can make it difficult to distinguish a CHECK crash location in crash reports. As such, instead of using V8_FatalNoContext, import the IMMEDIATE_CRASH macro from chromium and use that instead, which should cause a crash directly in the instruction stream so that the top stackframe on the crash report directly identifies the CHECK location that failed. More details here: https://docs.google.com/document/d/1tyMwzxUNH8BctM_urSQIYdcbwmzP4kTnwEjnFamBpKY Change-Id: I5b8175f19571834f790060d641db08d0b9c2c17b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756223Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#73430}
-
Pierre Langlois authored
We try and match literal load instructions in order to print a relocation info comment. However, we could be doing it while we're decoding a constant pool. This would cause a DCHECK to fire on Arm64 with full pointers. Change-Id: I82a523dc5c033f86f41467db75e43419ab87d5ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756532Reviewed-by:
-
Frank Emrich authored
Change-Id: Iec90b4821f41838eb4c2bae26035af4e30082ef9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762140Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Frank Emrich <emrich@google.com> Cr-Commit-Position: refs/heads/master@{#73428}
-
Manos Koukoutos authored
The register allocator sometimes fails if a parameter node appears twice. This seems to be an issue in the register allocator rather than a global assumption of Turbofan. This CL ensures duplication does not happen in wasm code until the issue is resolved. Changes: - Cache parameter nodes in wasm-compiler. - Use Dead() over Parameter() as placeholder in lowering stages. Change-Id: I7afb5de45dd169819309fea3d3c1a7cfe68af62c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756529 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Poisoning unmarked objects serves two purposes: - Prohibits finalizer from accessing other unmarked objects; - Unpoisioning also clears potential poisoning of the embedder which is necessary as the sweeper and compactor modify the payload of objects; Bug: chromium:1056170 Change-Id: I4346a0ab736603b3d6170b41b0e7255db1452897 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762137Reviewed-by:
-
Toon Verwaest authored
Using RW to update code perturbs SMC snooping on some CPUs. This reland fixes Apple Silicon and jitless by forcing the flag off. Change-Id: Ie2cc2e4fac333cad24a129e59cbcb6b13590d6d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759515 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Sara Tang authored
While testing the perf for v8-etw, I noticed that the runtime flag didn't completely guard from event emission. This change fixes that. Bug: v8:11043 Change-Id: Iee919e6030214e18173c93e4426d6437aed08235 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757894Reviewed-by:
-
