• Manos Koukoutos's avatar
    [wasm] Introduce dependency of JS/Wasm frame in wasm-compiler · 06212c9a
    Manos Koukoutos authored
    In wasm-compiler, nodes that reference the Isolate and Instance should
    depend on whether the current frame JS or Wasm. This was implemented
    with mutable fields caching nodes in WasmGraphBuilder and its
    subclasses, but was not done consistently.
    This CL removes all mutability and replaces it with an additional field
    isolate_ in WasmGraphBuilder, which is only set in the constructor of
    the child class WasmWrapperGraphBuilder.
    
    Additional changes:
    - Remove three almost-unused utilities from WasmGraphAssembler.
    - Reduce duplicate BuildImportCall with int index argument to the one
      with Node* index argument (the additional operations should be
      optimized away).
    
    Bug: v8:11510
    Change-Id: I2bb44a617210916edf671c238402727e04bdc38f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739976Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73444}
    06212c9a
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...