Commit 0b56c191 authored by Sara Tang's avatar Sara Tang Committed by Commit Bot

[diagnostics] ETW should emit interpreted functions on the callstack

This is a small change to the ETW instrumentation to enable
--interpreted-frames-native-stack so that we can see intepreted
functions on the JS call stack (in addition to jit-ted ones).

Bug: v8:11043
Change-Id: I17870bda6bc5291d6fe429770a015dd803fe446b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757888Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
Commit-Queue: Sara Tang <sartang@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#73451}
parent 63572683
......@@ -3959,6 +3959,7 @@ bool Shell::SetOptions(int argc, char* argv[]) {
} else if (strcmp(argv[i], "--enable-system-instrumentation") == 0) {
options.enable_system_instrumentation = true;
options.trace_enabled = true;
i::FLAG_interpreted_frames_native_stack = true;
argv[i] = nullptr;
#endif
}
......
......@@ -1891,6 +1891,11 @@ DEFINE_BOOL(interpreted_frames_native_stack, false,
DEFINE_BOOL(enable_system_instrumentation, false,
"Enable platform-specific profiling.")
#ifndef V8_TARGET_ARCH_ARM
DEFINE_IMPLICATION(enable_system_instrumentation,
interpreted_frames_native_stack)
#endif
//
// Disassembler only flags
//
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment