- 26 Aug, 2022 17 commits
-
-
Jakob Kummerow authored
For the branching control flow structure we set up for feedback-directed inlining-capable `call_ref` sequences, we have to manually take care of the "instance cache nodes" in the SSA environment. Drive-by: improve Runtime_WasmTierUpFunction to process type feedback, making it usable for the included regression test. Fixed: v8:13230 Change-Id: I06a449ad73af90b96d0cc15c3cb9a0e4bed87be6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859326Reviewed-by:
Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#82749}
-
Leszek Swirski authored
Change the has-optimized FeedbackVector bit to two bits, one for Maglev and one for Turbofan. Ignition and Sparkplug can check both bits, while Maglev will only check the Turbofan one. Bug: v8:7700 Change-Id: I95f6e4326180cac02f127a97438f960950f09d82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3856569 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82748}
-
Leszek Swirski authored
Bug: v8:7700 Change-Id: I2860bea3008ea1d357cf7e89fb0453221f065786 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859344 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Matthias Liedtke authored
This is a left-over of the removal of the dynamic (rtt-based) variants. Bug: v8:7748 Change-Id: I93bb74a72543a5697f1102d283c7d65c6be99466 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3856577 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#82746}
-
Victor Gomes authored
Fixes undefined behavior, which manifests as a compiler error in C++20 in Google3. This was caused by using members of vector<T> before T has been defined. This change just massages the code a bit to get everything in the proper order. See cl/468678068 on Google3. Bug: chromium:1284275 Change-Id: I0b65e7f850e8dd1ed482be1b5cc0b8d9d77776eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859343 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#82745}
-
Samuel Groß authored
This is a reland of commit a31e8f24 Remove the checking logic, which will be addressed in a separate CL. Original change's description: > [sandbox] Forbid double-initialization of ExternalPointerSlots > > Double initialization may cause the ExternalPointerTable compaction > algorithm to behave non-optimally: Consider the case of an Entry E1 that > is owned by a HeapObject O and is marked for evacuation during GC > marking. In that case, a new entry E2 is allocated for it, and during > sweeping, E1 will be evacuated into E2 and the Handle in O updated to > point to E2. However, if a new entry E3 for O is allocated before > sweeping, then during sweeping E3 (instead of E1) will be moved into E2. > This may then violate the invariant that the compaction algorithms > always evacuates an entry out of the evacuation area. > > This CL therefore forbids double initializaiton of external pointer > slots and adds DCHECKs to attempt to catch these in debug builds. > > Bug: v8:10391 > Change-Id: I128dc930e8b3f863dab18ba648f34d68d8cb276b > Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3856563 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Samuel Groß <saelo@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82729} Bug: v8:10391 Change-Id: I6cef79f4adc340fdcdc291ad0f0c2210f5bf48cd Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857423Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#82744}
-
Feng Yu authored
Bug: v8:12781 Change-Id: I0c1234c5a649f3533eebbab89f7fe16140327d59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858927 Commit-Queue: Feng Yu <f3n67u@gmail.com> Reviewed-by:
Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#82743}
-
Victor Gomes authored
Maglev uses a different safepoint table. This CL introduces the functions FindReturnPCForTrampoline for MaglevFrame and TurboFanFrame. Bug: v8:7700, chromium:1356902 Change-Id: I90784ddfdc96604c5ada8047e6f7447c17e6c3aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859342 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82742}
-
Qifan Pan authored
Bug: v8:9407 Change-Id: I29f8f5ec68f09e8631b59d3a6a2926bab3b3bcd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3845638Reviewed-by:
-
Liu Yu authored
Port commit 1e5c03c7 Bug: v8:11880 Change-Id: I706056509c2d23e6d57203aba7adcbcbe22607cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859164Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu Yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#82740}
-
Hao Xu authored
This allows x64 to select shrl instead of shrq instruction for the below pattern: 2: ChangeUint32ToUint64(1) 3: Int64Constant[2] 4: Word64Shr(2, 3) Change-Id: I3278b9ab52dd7212d1a616291d114a6bff0d13d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857740Reviewed-by:
-
Leon Bettscheider authored
This CL fixes a data race that was found using TSAN. Bug: v8:13012 Change-Id: Ic29620edce116effea097a9f1d58532ba93b2224 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857424Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Leon Bettscheider <bettscheider@google.com> Cr-Commit-Position: refs/heads/main@{#82738}
-
Lu Yahan authored
This is a reland of commit 59d7cf52 Original change's description: > [riscv] Port [heap] Add shared barrier to RecordWrite builtin > > Bug: v8:11708 > > Change-Id: I803b5499f1bbc3f7b4e626628a73f98239df8454 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3854435 > Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> > Commit-Queue: ji qiu <qiuji@iscas.ac.cn> > Reviewed-by: ji qiu <qiuji@iscas.ac.cn> > Cr-Commit-Position: refs/heads/main@{#82710} Bug: v8:11708 Change-Id: I56fcfc8a92c71463bce22a8090e161173cc2c64c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857980 Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#82737}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/31c77cb..bbdc7d8 Add microsecond and nanosecond unit (Frank Tang) https://chromium.googlesource.com/chromium/deps/icu/+/bbdc7d8 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,ftang@chromium.org Change-Id: I2d996e16a0e3e52c1de237eb13ca656829ff3d0c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857874 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82736}
-
Yahan Lu authored
This reverts commit 59d7cf52. Reason for revert: wrong port Original change's description: > [riscv] Port [heap] Add shared barrier to RecordWrite builtin > > Bug: v8:11708 > > Change-Id: I803b5499f1bbc3f7b4e626628a73f98239df8454 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3854435 > Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> > Commit-Queue: ji qiu <qiuji@iscas.ac.cn> > Reviewed-by: ji qiu <qiuji@iscas.ac.cn> > Cr-Commit-Position: refs/heads/main@{#82710} Bug: v8:11708 Change-Id: I0e091b2eb086c87e7c60b9840d19b7c383124e42 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857979 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#82735}
-
Milad Fa authored
Port 1e5c03c7 Original Commit Message: This CL simplifies the API calls by removing some instructions from the most common path. R=ishell@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I989c7da21347dc8a081b55ecea6374d3415d4aa3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857444Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
-
Frank Tang authored
Also add AO: ToISOWeekOfYear Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.weekofyear https://tc39.es/proposal-temporal/#sec-temporal-toisoweekofyear Note- this is only the non-intl version. intl version in https://tc39.es/proposal-temporal/#sup-temporal.calendar.prototype.weekofyear will be implemented in later cl. PR https://github.com/tc39/proposal-temporal/pull/2378 Sync spec text for ToISODayOfYear and ToISODayOfWeek in the comment and add DCHECK for assertion. Bug: v8:11544 Change-Id: If07ff76551707d17d125e41bc624c12da6efa45a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3531567 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#82733}
-
- 25 Aug, 2022 23 commits
-
-
Samuel Groß authored
This reverts commit a31e8f24. Reason for revert: Causes DCHECK failures with --stress-snapshot Original change's description: > [sandbox] Forbid double-initialization of ExternalPointerSlots > > Double initialization may cause the ExternalPointerTable compaction > algorithm to behave non-optimally: Consider the case of an Entry E1 that > is owned by a HeapObject O and is marked for evacuation during GC > marking. In that case, a new entry E2 is allocated for it, and during > sweeping, E1 will be evacuated into E2 and the Handle in O updated to > point to E2. However, if a new entry E3 for O is allocated before > sweeping, then during sweeping E3 (instead of E1) will be moved into E2. > This may then violate the invariant that the compaction algorithms > always evacuates an entry out of the evacuation area. > > This CL therefore forbids double initializaiton of external pointer > slots and adds DCHECKs to attempt to catch these in debug builds. > > Bug: v8:10391 > Change-Id: I128dc930e8b3f863dab18ba648f34d68d8cb276b > Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3856563 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Samuel Groß <saelo@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82729} Bug: v8:10391 Change-Id: I37e6728cc16fe79fa7d743417dc9938d58fb0474 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857422 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
-
Danylo Boiko authored
Bug: v8:7327 Change-Id: Ie10dd2b7fde80f100589b388644143e626b7e610 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3856570Reviewed-by:
-
Patrick Thier authored
- Move StringForwardingTable implementation to own compilation unit. - Refactoring preparing for layout change (Introduce explicit record class to make transition from contiguous Tagged_t fields to a heterogeneous record layout easier). - Replace RootVisitor pattern for transitioning/cleanup during GC with callback. - Minor cleanups. Bug: v8:12957 Change-Id: Iae343393f470130eac0c54148a1303b67fb95aa4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3845635Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
-
Samuel Groß authored
Double initialization may cause the ExternalPointerTable compaction algorithm to behave non-optimally: Consider the case of an Entry E1 that is owned by a HeapObject O and is marked for evacuation during GC marking. In that case, a new entry E2 is allocated for it, and during sweeping, E1 will be evacuated into E2 and the Handle in O updated to point to E2. However, if a new entry E3 for O is allocated before sweeping, then during sweeping E3 (instead of E1) will be moved into E2. This may then violate the invariant that the compaction algorithms always evacuates an entry out of the evacuation area. This CL therefore forbids double initializaiton of external pointer slots and adds DCHECKs to attempt to catch these in debug builds. Bug: v8:10391 Change-Id: I128dc930e8b3f863dab18ba648f34d68d8cb276b Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3856563Reviewed-by:
-
Michael Achenbach authored
Bugs that are older than the switch of v8_foozzie.py to Python3 bisect to the switch commit unfortunately. This change attempts to let bisect run longer if a python2 executable still exists. No-Try: true Bug: chromium:1355824 Change-Id: I457a50af21704ddd2985793861eee8be5601a673 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3856574Reviewed-by:
Liviu Rau <liviurau@google.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#82728}
-
Dominik Inführ authored
ThinStrings are not transitioned to other string representations, so we shouldn't need the snapshotting protocol for them. Change-Id: I17cee1a4171b10c441a005ac29bd232a0a065207 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3852489Reviewed-by:
-
Victor Gomes authored
This does not enable exception handlers yet, we still bail out in MaglevCompiler::Compile if we have an exception handler table in the bytecode array. This CL: - Generates code for exception handler blocks (which previously were set as dead code) - Creates a machinery for nodes to set the property CanThrow - Reads the exception handler table from the bytecode array and identifies if we're emitting nodes inside a try-block and for which handler we should jump in case of an exception - Generates an exception handler table for Maglev code Change-Id: Ifc9d4cb7440d3222f4fda48a86e4e482340b3b15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3854061 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Feng Yu authored
Bug: v8:12781 Change-Id: I281047a0606b8f709a930998ef7e7a53f780f59d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3840146Reviewed-by:
-
Feng Yu authored
This is a reland of commit 437b311a Original change's description: > [test] Migrate cctest/test-inspector to unittests/ > > test-inspector.cc -> inspector-unittest.cc > > Bug: v8:12781 > Change-Id: I37d2bc2d023ffd91b94d5a09cdbfe4a6e22fecf1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3813062 > Reviewed-by: Jakob Linke <jgruber@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82512} Bug: v8:12781 Change-Id: Iece26e724f21d459dd1e96423d3aa72f15c5424e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3837705 Commit-Queue: Feng Yu <f3n67u@gmail.com> Reviewed-by:
Jakob Linke <jgruber@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#82724}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: I1cc74a53cde8594b3f0b116c7876e0d70139084c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3856583Reviewed-by:
-
Leszek Swirski authored
--stress-opt never did what we wanted it to; it ran its runs in different contexts (therefore not able to share feedback across runs), and even if it didn't, each run would create new closures for any defined closures, so we'd still more than likely end up poly- or mega-morphic. Fuzzers cover this use case better than --stress-opt ever did, so now it's just using precious bot time. We can get rid of it. Bug: v8:10386 Change-Id: Ibbb9207d887b4b1dc4ec9093858d477c0f95eb37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3803228 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Igor Sheludko authored
This reverts commit c89998d9. Reason for revert: a lot of unexpected memory regressions that require investigation. Original change's description: > Reland "[ext-code-space] Enable Code-less embedded builtins" > > This is a reland of commit 40901824 > The Ubsan issue is fixed here: https://chromium-review.googlesource.com/c/v8/v8/+/3849038. > > Original change's description: > > [ext-code-space] Enable Code-less embedded builtins > > > > Bug: v8:11880, v8:12592 > > Change-Id: I8d3d6ad0a4c26eb1fea2a998ffeddd1d96afa690 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784593 > > Commit-Queue: Igor Sheludko <ishell@chromium.org> > > Reviewed-by: Jakob Linke <jgruber@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#82642} > > Bug: v8:11880, v8:12592 > Change-Id: I66373d6af30b060d1204b952d733e260228548df > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3846493 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82683} Bug: v8:11880, v8:12592, chromium:1356329 Change-Id: I07aaf714da8d7afc66cf4116f189dd5dde5b8818 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3856357Reviewed-by:
-
Al Muthanna Athamina authored
Bug: v8:13234 No-Try: true Change-Id: I63a5402ce5e4419972e0d6728c7615a341398648 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855450Reviewed-by:
-
Feng Yu authored
This is a reland of commit 3615ae69. Original change's description: > [test] Migrate cctest/test-global-handles to unittests/ > > Bug: v8:12781 > Change-Id: If7681564f3e0c087e3347557a3f9169625b51607 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3817621 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82633} Bug: v8:12781 Change-Id: I776ab176733722fd8853deaabec93e0d44274d9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855979Reviewed-by:
-
ishell@chromium.org authored
This CL simplifies the API calls by removing some instructions from the most common path. Bug: v8:11880 Change-Id: Id8a62c35af51947ad2c152e093346d03c8e2f508 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855039 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Feng Yu authored
This is a reland of commit d83346be Original change's description: > [test] Migrate cctest/test-weakmaps to unittests/ > > Bug: v8:12781 > Change-Id: Ief6bd7ee0ff2876e19970b2fb6af4f3208ec7f4e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3815486 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82699} Bug: v8:12781 Change-Id: I9f74c32b924433dea67f62e26a336ef7263282e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3856096 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Tom Anderson authored
Bug: chromium:1355871 Change-Id: I7c465e7ce326c62cbc8ad92e2547eea78d23fe0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3852443Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Vasili Skurydzin authored
Change-Id: I99b4c5d9ea6183acf629f5f76ebb0f84c88e7b20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855198 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
-
Clemens Backes authored
Add static asserts that we only use specific types for flag values. Also, document that string values are not be frozen yet, and add TODOs to fix that. R=cbruni@chromium.org Bug: v8:12887 Change-Id: I7367108810f0c6463509f744c5cefd9392c469fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3852487Reviewed-by:
-
Leszek Swirski authored
This reverts commit d83346be. Reason for revert: Seems to be breaking TSAN bot (https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20stress-incremental-marking/8867/overview) Original change's description: > [test] Migrate cctest/test-weakmaps to unittests/ > > Bug: v8:12781 > Change-Id: Ief6bd7ee0ff2876e19970b2fb6af4f3208ec7f4e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3815486 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82699} Bug: v8:12781 Change-Id: Ia20078e9f40d0e2257cf0b953ddd2e72594c4085 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855938 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82713}
-
Liu Yu authored
Port commit 805df68f Bug: v8:11708 Change-Id: I1a6970d18f1991e4158edb41ec5b8e393fccba4c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855696 Auto-Submit: Liu Yu <liuyu@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
-
Clemens Backes authored
This reverts commit d84b4664. Reason for revert: Fails "Mutable Constants" check on android-binary-size: https://ci.chromium.org/ui/p/chromium/builders/try/android-binary-size/1211670/overview For details about this check, see https://chromium.googlesource.com/chromium/src/+/main/docs/speed/binary_size/android_binary_size_trybot.md#Mutable-Constants Original change's description: > [flags] Rename v8_flags to FLAGS > > Team members expressed concerns that "v8_flags" is easier to miss in the > code than the previous "FLAG_" syntax. After a poll and discussions we > decided to rename the struct to "FLAGS", so the new syntax for > addressing flag values is "FLAGS.foo" instead of the previous > "FLAG_foo". > > R=cbruni@chromium.org > CC=jkummerow@chromium.org > > Bug: v8:12887 > Change-Id: I51af4aa7fd5a3b3c29310c0cb4c4ff42086ff012 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3854508 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82701} Bug: v8:12887 Change-Id: I75516a0be9bc475afa2bbaa96a05e8a9b5be9be7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855936 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#82711}
-
Lu Yahan authored
Bug: v8:11708 Change-Id: I803b5499f1bbc3f7b4e626628a73f98239df8454 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3854435 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Reviewed-by:
-
