Commit 2dd434f4 authored by Tom Anderson's avatar Tom Anderson Committed by V8 LUCI CQ

Fix build with -Wextra-semi

Bug: chromium:1355871
Change-Id: I7c465e7ce326c62cbc8ad92e2547eea78d23fe0b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3852443Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82716}
parent 823f2a6e
......@@ -92,7 +92,7 @@ class V8_EXPORT WriteBarrier final {
#else // !CPPGC_YOUNG_GENERATION
template <GenerationalBarrierType>
static V8_INLINE void GenerationalBarrier(const Params& params,
const void* slot){};
const void* slot){}
#endif // CPPGC_YOUNG_GENERATION
#if V8_ENABLE_CHECKS
......
......@@ -265,11 +265,11 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
// Calls Abort(msg) if the condition cond is not satisfied.
// Use --debug-code to enable.
void Assert(Condition cond, AbortReason reason) NOOP_UNLESS_DEBUG_CODE;
void Assert(Condition cond, AbortReason reason) NOOP_UNLESS_DEBUG_CODE
// Like Assert(), but without condition.
// Use --debug-code to enable.
void AssertUnreachable(AbortReason reason) NOOP_UNLESS_DEBUG_CODE;
void AssertUnreachable(AbortReason reason) NOOP_UNLESS_DEBUG_CODE
// Like Assert(), but always enabled.
void Check(Condition cond, AbortReason reason);
......@@ -763,7 +763,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
}
// Tiering support.
void AssertFeedbackVector(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertFeedbackVector(Register object) NOOP_UNLESS_DEBUG_CODE
void ReplaceClosureCodeWithOptimizedCode(Register optimized_code,
Register closure);
void GenerateTailCallToReturnedCode(Runtime::FunctionId function_id);
......@@ -843,31 +843,31 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
void JumpIfNotSmi(Register value, Label* not_smi_label);
// Abort execution if argument is a smi, enabled via --debug-code.
void AssertNotSmi(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertSmi(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertNotSmi(Register object) NOOP_UNLESS_DEBUG_CODE
void AssertSmi(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a Constructor, enabled via --debug-code.
void AssertConstructor(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertConstructor(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSFunction, enabled via --debug-code.
void AssertFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a callable JSFunction, enabled via
// --debug-code.
void AssertCallableFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertCallableFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSBoundFunction,
// enabled via --debug-code.
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSGeneratorObject (or subclass),
// enabled via --debug-code.
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not undefined or an AllocationSite, enabled
// via --debug-code.
void AssertUndefinedOrAllocationSite(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
template <typename Field>
void DecodeField(Register dst, Register src) {
......
......@@ -564,15 +564,15 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
// Calls Abort(msg) if the condition cond is not satisfied.
// Use --debug_code to enable.
void Assert(Condition cond, AbortReason reason) NOOP_UNLESS_DEBUG_CODE;
void Assert(Condition cond, AbortReason reason) NOOP_UNLESS_DEBUG_CODE
// Like Assert(), but without condition.
// Use --debug_code to enable.
void AssertUnreachable(AbortReason reason) NOOP_UNLESS_DEBUG_CODE;
void AssertUnreachable(AbortReason reason) NOOP_UNLESS_DEBUG_CODE
void AssertSmi(Register object,
AbortReason reason = AbortReason::kOperandIsNotASmi)
NOOP_UNLESS_DEBUG_CODE;
NOOP_UNLESS_DEBUG_CODE
// Like Assert(), but always enabled.
void Check(Condition cond, AbortReason reason);
......@@ -695,7 +695,7 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
const VRegister& fm, Condition cond);
// Emits a runtime assert that the stack pointer is aligned.
void AssertSpAligned() NOOP_UNLESS_DEBUG_CODE;
void AssertSpAligned() NOOP_UNLESS_DEBUG_CODE
// Copy slot_count stack slots from the stack offset specified by src to
// the stack offset specified by dst. The offsets and count are expressed in
......@@ -779,7 +779,7 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
// Abort execution if argument is not a positive or zero integer, enabled via
// --debug-code.
void AssertPositiveOrZero(Register value) NOOP_UNLESS_DEBUG_CODE;
void AssertPositiveOrZero(Register value) NOOP_UNLESS_DEBUG_CODE
#define DECLARE_FUNCTION(FN, REGTYPE, REG, OP) \
inline void FN(const REGTYPE REG, const MemOperand& addr);
......@@ -1142,7 +1142,7 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
ucvtf(vd, vn, fbits);
}
void AssertFPCRState(Register fpcr = NoReg) NOOP_UNLESS_DEBUG_CODE;
void AssertFPCRState(Register fpcr = NoReg) NOOP_UNLESS_DEBUG_CODE
void CanonicalizeNaN(const VRegister& dst, const VRegister& src);
void CanonicalizeNaN(const VRegister& reg) { CanonicalizeNaN(reg, reg); }
......@@ -1826,7 +1826,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
// Tiering support.
void AssertFeedbackVector(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
void ReplaceClosureCodeWithOptimizedCode(Register optimized_code,
Register closure);
void GenerateTailCallToReturnedCode(Runtime::FunctionId function_id);
......@@ -1863,32 +1863,32 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
// Abort execution if argument is a smi, enabled via --debug-code.
void AssertNotSmi(Register object,
AbortReason reason = AbortReason::kOperandIsASmi)
NOOP_UNLESS_DEBUG_CODE;
NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a CodeT, enabled via --debug-code.
void AssertCodeT(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertCodeT(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a Constructor, enabled via --debug-code.
void AssertConstructor(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertConstructor(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSFunction, enabled via --debug-code.
void AssertFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a callable JSFunction, enabled via
// --debug-code.
void AssertCallableFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertCallableFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSGeneratorObject (or subclass),
// enabled via --debug-code.
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSBoundFunction,
// enabled via --debug-code.
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not undefined or an AllocationSite, enabled
// via --debug-code.
void AssertUndefinedOrAllocationSite(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertUndefinedOrAllocationSite(Register object) NOOP_UNLESS_DEBUG_CODE
// ---- Calling / Jumping helpers ----
......
......@@ -483,9 +483,9 @@ class V8_EXPORT_PRIVATE V8_NODISCARD CpuFeatureScope {
// Use this macro to mark functions that are only defined if
// V8_ENABLE_DEBUG_CODE is set, and are a no-op otherwise.
// Use like:
// void AssertMyCondition() NOOP_UNLESS_DEBUG_CODE;
// void AssertMyCondition() NOOP_UNLESS_DEBUG_CODE
#ifdef V8_ENABLE_DEBUG_CODE
#define NOOP_UNLESS_DEBUG_CODE
#define NOOP_UNLESS_DEBUG_CODE ;
#else
#define NOOP_UNLESS_DEBUG_CODE \
{ static_assert(FLAG_debug_code.value() == false); }
......
......@@ -107,11 +107,11 @@ class V8_EXPORT_PRIVATE TurboAssembler
// Calls Abort(msg) if the condition cc is not satisfied.
// Use --debug_code to enable.
void Assert(Condition cc, AbortReason reason) NOOP_UNLESS_DEBUG_CODE;
void Assert(Condition cc, AbortReason reason) NOOP_UNLESS_DEBUG_CODE
// Like Assert(), but without condition.
// Use --debug_code to enable.
void AssertUnreachable(AbortReason reason) NOOP_UNLESS_DEBUG_CODE;
void AssertUnreachable(AbortReason reason) NOOP_UNLESS_DEBUG_CODE
// Like Assert(), but always enabled.
void Check(Condition cc, AbortReason reason);
......@@ -556,7 +556,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
// Tiering support.
void AssertFeedbackVector(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
void ReplaceClosureCodeWithOptimizedCode(Register optimized_code,
Register closure, Register scratch1,
Register slot_address);
......@@ -568,34 +568,34 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
Register optimization_state, XMMRegister saved_feedback_vector);
// Abort execution if argument is not a smi, enabled via --debug-code.
void AssertSmi(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertSmi(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is a smi, enabled via --debug-code.
void AssertNotSmi(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertNotSmi(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSFunction, enabled via --debug-code.
void AssertFunction(Register object, Register scratch) NOOP_UNLESS_DEBUG_CODE;
void AssertFunction(Register object, Register scratch) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a callable JSFunction, enabled via
// --debug-code.
void AssertCallableFunction(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a Constructor, enabled via --debug-code.
void AssertConstructor(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertConstructor(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSBoundFunction,
// enabled via --debug-code.
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSGeneratorObject (or subclass),
// enabled via --debug-code.
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not undefined or an AllocationSite, enabled
// via --debug-code.
void AssertUndefinedOrAllocationSite(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
// ---------------------------------------------------------------------------
// Exception handling
......
......@@ -101,7 +101,7 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
// Calls Abort(msg) if the condition cc is not satisfied.
// Use --debug_code to enable.
void Assert(Condition cc, AbortReason reason, Register rj,
Operand rk) NOOP_UNLESS_DEBUG_CODE;
Operand rk) NOOP_UNLESS_DEBUG_CODE
// Like Assert(), but always enabled.
void Check(Condition cc, AbortReason reason, Register rj, Operand rk);
......@@ -461,8 +461,8 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
}
// Abort execution if argument is a smi, enabled via --debug-code.
void AssertNotSmi(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertSmi(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertNotSmi(Register object) NOOP_UNLESS_DEBUG_CODE
void AssertSmi(Register object) NOOP_UNLESS_DEBUG_CODE
int CalculateStackPassedWords(int num_reg_arguments,
int num_double_arguments);
......@@ -898,7 +898,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
bool argument_count_is_length = false);
// Make sure the stack is aligned. Only emits code in debug mode.
void AssertStackIsAligned() NOOP_UNLESS_DEBUG_CODE;
void AssertStackIsAligned() NOOP_UNLESS_DEBUG_CODE
// Load the global proxy from the current context.
void LoadGlobalProxy(Register dst) {
......@@ -1022,32 +1022,32 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
void JumpIfNotSmi(Register value, Label* not_smi_label);
// Abort execution if argument is not a Constructor, enabled via --debug-code.
void AssertConstructor(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertConstructor(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSFunction, enabled via --debug-code.
void AssertFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a callable JSFunction, enabled via
// --debug-code.
void AssertCallableFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertCallableFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSBoundFunction,
// enabled via --debug-code.
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSGeneratorObject (or subclass),
// enabled via --debug-code.
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not undefined or an AllocationSite, enabled
// via --debug-code.
void AssertUndefinedOrAllocationSite(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
// ---------------------------------------------------------------------------
// Tiering support.
void AssertFeedbackVector(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
void ReplaceClosureCodeWithOptimizedCode(Register optimized_code,
Register closure);
void GenerateTailCallToReturnedCode(Runtime::FunctionId function_id);
......
......@@ -135,7 +135,7 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
// Calls Abort(msg) if the condition cc is not satisfied.
// Use --debug_code to enable.
void Assert(Condition cc, AbortReason reason, Register rs,
Operand rt) NOOP_UNLESS_DEBUG_CODE;
Operand rt) NOOP_UNLESS_DEBUG_CODE
// Like Assert(), but always enabled.
void Check(Condition cc, AbortReason reason, Register rs, Operand rt);
......@@ -526,8 +526,8 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
}
// Abort execution if argument is a smi, enabled via --debug-code.
void AssertNotSmi(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertSmi(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertNotSmi(Register object) NOOP_UNLESS_DEBUG_CODE
void AssertSmi(Register object) NOOP_UNLESS_DEBUG_CODE
int CalculateStackPassedWords(int num_reg_arguments,
int num_double_arguments);
......@@ -1084,7 +1084,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
bool argument_count_is_length = false);
// Make sure the stack is aligned. Only emits code in debug mode.
void AssertStackIsAligned() NOOP_UNLESS_DEBUG_CODE;
void AssertStackIsAligned() NOOP_UNLESS_DEBUG_CODE
// Load the global proxy from the current context.
void LoadGlobalProxy(Register dst) {
......@@ -1210,32 +1210,32 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
BranchDelaySlot bd = PROTECT);
// Abort execution if argument is not a Constructor, enabled via --debug-code.
void AssertConstructor(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertConstructor(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSFunction, enabled via --debug-code.
void AssertFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a callable JSFunction, enabled via
// --debug-code.
void AssertCallableFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertCallableFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSBoundFunction,
// enabled via --debug-code.
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSGeneratorObject (or subclass),
// enabled via --debug-code.
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not undefined or an AllocationSite, enabled
// via --debug-code.
void AssertUndefinedOrAllocationSite(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
// ---------------------------------------------------------------------------
// Tiering support.
void AssertFeedbackVector(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
void ReplaceClosureCodeWithOptimizedCode(Register optimized_code,
Register closure, Register scratch1,
Register scratch2);
......
......@@ -670,7 +670,7 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
// Calls Abort(msg) if the condition cond is not satisfied.
// Use --debug_code to enable.
void Assert(Condition cond, AbortReason reason,
CRegister cr = cr7) NOOP_UNLESS_DEBUG_CODE;
CRegister cr = cr7) NOOP_UNLESS_DEBUG_CODE
// Like Assert(), but always enabled.
void Check(Condition cond, AbortReason reason, CRegister cr = cr7);
......@@ -809,8 +809,8 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
}
// Abort execution if argument is a smi, enabled via --debug-code.
void AssertNotSmi(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertSmi(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertNotSmi(Register object) NOOP_UNLESS_DEBUG_CODE
void AssertSmi(Register object) NOOP_UNLESS_DEBUG_CODE
void ZeroExtByte(Register dst, Register src);
void ZeroExtHalfWord(Register dst, Register src);
......@@ -1297,7 +1297,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
// Tiering support.
void AssertFeedbackVector(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
void ReplaceClosureCodeWithOptimizedCode(Register optimized_code,
Register closure, Register scratch1,
Register slot_address);
......@@ -1398,27 +1398,27 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
#endif
// Abort execution if argument is not a Constructor, enabled via --debug-code.
void AssertConstructor(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertConstructor(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSFunction, enabled via --debug-code.
void AssertFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a callable JSFunction, enabled via
// --debug-code.
void AssertCallableFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertCallableFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSBoundFunction,
// enabled via --debug-code.
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSGeneratorObject (or subclass),
// enabled via --debug-code.
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not undefined or an AllocationSite, enabled
// via --debug-code.
void AssertUndefinedOrAllocationSite(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
// ---------------------------------------------------------------------------
// Patching helpers.
......
......@@ -1337,7 +1337,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
// Tiering support.
void AssertFeedbackVector(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
void ReplaceClosureCodeWithOptimizedCode(Register optimized_code,
Register closure);
void GenerateTailCallToReturnedCode(Runtime::FunctionId function_id);
......
......@@ -927,11 +927,11 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
// Calls Abort(msg) if the condition cond is not satisfied.
// Use --debug_code to enable.
void Assert(Condition cond, AbortReason reason,
CRegister cr = cr7) NOOP_UNLESS_DEBUG_CODE;
CRegister cr = cr7) NOOP_UNLESS_DEBUG_CODE
// Like Assert(), but without condition.
// Use --debug-code to enable.
void AssertUnreachable(AbortReason reason) NOOP_UNLESS_DEBUG_CODE;
void AssertUnreachable(AbortReason reason) NOOP_UNLESS_DEBUG_CODE
// Like Assert(), but always enabled.
void Check(Condition cond, AbortReason reason, CRegister cr = cr7);
......@@ -1066,8 +1066,8 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase {
}
// Abort execution if argument is a smi, enabled via --debug-code.
void AssertNotSmi(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertSmi(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertNotSmi(Register object) NOOP_UNLESS_DEBUG_CODE
void AssertSmi(Register object) NOOP_UNLESS_DEBUG_CODE
// Activation support.
void EnterFrame(StackFrame::Type type,
......@@ -1713,27 +1713,27 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
// Abort execution if argument is not a Constructor, enabled via --debug-code.
void AssertConstructor(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSFunction, enabled via --debug-code.
void AssertFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a callable JSFunction, enabled via
// --debug-code.
void AssertCallableFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertCallableFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSBoundFunction,
// enabled via --debug-code.
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSGeneratorObject (or subclass),
// enabled via --debug-code.
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not undefined or an AllocationSite, enabled
// via --debug-code.
void AssertUndefinedOrAllocationSite(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
template <typename Field>
void DecodeField(Register dst, Register src) {
......@@ -1747,7 +1747,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
// Tiering support.
void AssertFeedbackVector(Register object,
Register scratch) NOOP_UNLESS_DEBUG_CODE;
Register scratch) NOOP_UNLESS_DEBUG_CODE
void ReplaceClosureCodeWithOptimizedCode(Register optimized_code,
Register closure, Register scratch1,
Register slot_address);
......
......@@ -226,11 +226,11 @@ class V8_EXPORT_PRIVATE TurboAssembler
Condition CheckSmi(Operand src);
// Abort execution if argument is a smi, enabled via --debug-code.
void AssertNotSmi(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertNotSmi(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a smi, enabled via --debug-code.
void AssertSmi(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertSmi(Operand object) NOOP_UNLESS_DEBUG_CODE;
void AssertSmi(Register object) NOOP_UNLESS_DEBUG_CODE
void AssertSmi(Operand object) NOOP_UNLESS_DEBUG_CODE
// Test-and-jump functions. Typically combines a check function
// above with a conditional jump.
......@@ -453,19 +453,19 @@ class V8_EXPORT_PRIVATE TurboAssembler
// Calls Abort(msg) if the condition cc is not satisfied.
// Use --debug_code to enable.
void Assert(Condition cc, AbortReason reason) NOOP_UNLESS_DEBUG_CODE;
void Assert(Condition cc, AbortReason reason) NOOP_UNLESS_DEBUG_CODE
// Like Assert(), but without condition.
// Use --debug_code to enable.
void AssertUnreachable(AbortReason reason) NOOP_UNLESS_DEBUG_CODE;
void AssertUnreachable(AbortReason reason) NOOP_UNLESS_DEBUG_CODE
// Abort execution if a 64 bit register containing a 32 bit payload does not
// have zeros in the top 32 bits, enabled via --debug-code.
void AssertZeroExtended(Register reg) NOOP_UNLESS_DEBUG_CODE;
void AssertZeroExtended(Register reg) NOOP_UNLESS_DEBUG_CODE
// Abort execution if the signed bit of smi register with pointer compression
// is not zero, enabled via --debug-code.
void AssertSignedBitOfSmiIsZero(Register smi) NOOP_UNLESS_DEBUG_CODE;
void AssertSignedBitOfSmiIsZero(Register smi) NOOP_UNLESS_DEBUG_CODE
// Like Assert(), but always enabled.
void Check(Condition cc, AbortReason reason);
......@@ -830,7 +830,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
Immediate ClearedValue() const;
// Tiering support.
void AssertFeedbackVector(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertFeedbackVector(Register object) NOOP_UNLESS_DEBUG_CODE
void ReplaceClosureCodeWithOptimizedCode(Register optimized_code,
Register closure, Register scratch1,
Register slot_address);
......@@ -844,29 +844,29 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
JumpMode jump_mode = JumpMode::kJump);
// Abort execution if argument is not a CodeT, enabled via --debug-code.
void AssertCodeT(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertCodeT(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a Constructor, enabled via --debug-code.
void AssertConstructor(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertConstructor(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSFunction, enabled via --debug-code.
void AssertFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a callable JSFunction, enabled via
// --debug-code.
void AssertCallableFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertCallableFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSBoundFunction,
// enabled via --debug-code.
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertBoundFunction(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not a JSGeneratorObject (or subclass),
// enabled via --debug-code.
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertGeneratorObject(Register object) NOOP_UNLESS_DEBUG_CODE
// Abort execution if argument is not undefined or an AllocationSite, enabled
// via --debug-code.
void AssertUndefinedOrAllocationSite(Register object) NOOP_UNLESS_DEBUG_CODE;
void AssertUndefinedOrAllocationSite(Register object) NOOP_UNLESS_DEBUG_CODE
// ---------------------------------------------------------------------------
// Exception handling
......
......@@ -522,7 +522,7 @@ class TranslationArrayProcessor {
TranslationArrayBuilder& translation_array_builder() {
return *translation_array_builder_;
};
}
LocalIsolate* local_isolate_;
std::unique_ptr<TranslationArrayBuilder> translation_array_builder_;
......
......@@ -1874,7 +1874,7 @@ struct GetRegister<DoubleRegister> {
return target.GetDoubleRegister();
}
};
}; // namespace
} // namespace
void ConstantGapMove::GenerateCode(MaglevCodeGenState* code_gen_state,
const ProcessingState& state) {
switch (node_->opcode()) {
......
......@@ -268,7 +268,7 @@ Map Context::GetInitialJSArrayMap(ElementsKind kind) const {
EXTERNAL_POINTER_ACCESSORS(NativeContext, microtask_queue, MicrotaskQueue*,
kMicrotaskQueueOffset,
kNativeContextMicrotaskQueueTag);
kNativeContextMicrotaskQueueTag)
void NativeContext::synchronized_set_script_context_table(
ScriptContextTable script_context_table) {
......
......@@ -724,7 +724,7 @@ class NativeContext : public Context {
ReleaseStoreTag);
// [microtask_queue]: pointer to the MicrotaskQueue object.
DECL_EXTERNAL_POINTER_ACCESSORS(microtask_queue, MicrotaskQueue*);
DECL_EXTERNAL_POINTER_ACCESSORS(microtask_queue, MicrotaskQueue*)
inline void synchronized_set_script_context_table(
ScriptContextTable script_context_table);
......
......@@ -22,7 +22,7 @@ namespace internal {
TQ_OBJECT_CONSTRUCTORS_IMPL(Foreign)
EXTERNAL_POINTER_ACCESSORS(Foreign, foreign_address, Address,
kForeignAddressOffset, kForeignForeignAddressTag);
kForeignAddressOffset, kForeignForeignAddressTag)
} // namespace internal
} // namespace v8
......
......@@ -19,7 +19,7 @@ namespace internal {
class Foreign : public TorqueGeneratedForeign<Foreign, HeapObject> {
public:
// [foreign_address]: field containing the address.
DECL_EXTERNAL_POINTER_ACCESSORS(foreign_address, Address);
DECL_EXTERNAL_POINTER_ACCESSORS(foreign_address, Address)
// Dispatched behavior.
DECL_PRINTER(Foreign)
......
......@@ -571,7 +571,7 @@ void JSObject::InitializeBody(Map map, int start_offset,
TQ_OBJECT_CONSTRUCTORS_IMPL(JSExternalObject)
EXTERNAL_POINTER_ACCESSORS(JSExternalObject, value, void*, kValueOffset,
kExternalObjectValueTag);
kExternalObjectValueTag)
DEF_GETTER(JSGlobalObject, native_context_unchecked, Object) {
return TaggedField<Object, kNativeContextOffset>::Relaxed_Load(cage_base,
......
......@@ -297,7 +297,7 @@ EXTERNAL_POINTER_ACCESSORS(WasmInternalFunction, call_target, Address,
ACCESSORS(WasmFunctionData, internal, WasmInternalFunction, kInternalOffset)
EXTERNAL_POINTER_ACCESSORS(WasmExportedFunctionData, sig, wasm::FunctionSig*,
kSigOffset, kWasmExportedFunctionDataSignatureTag);
kSigOffset, kWasmExportedFunctionDataSignatureTag)
// WasmJSFunction
WasmJSFunction::WasmJSFunction(Address ptr) : JSFunction(ptr) {
......
......@@ -731,7 +731,7 @@ class WasmExportedFunctionData
: public TorqueGeneratedWasmExportedFunctionData<WasmExportedFunctionData,
WasmFunctionData> {
public:
DECL_EXTERNAL_POINTER_ACCESSORS(sig, wasm::FunctionSig*);
DECL_EXTERNAL_POINTER_ACCESSORS(sig, wasm::FunctionSig*)
// Dispatched behavior.
DECL_PRINTER(WasmExportedFunctionData)
......@@ -762,7 +762,7 @@ class WasmInternalFunction
static MaybeHandle<WasmInternalFunction> FromExternal(Handle<Object> external,
Isolate* isolate);
DECL_EXTERNAL_POINTER_ACCESSORS(call_target, Address);
DECL_EXTERNAL_POINTER_ACCESSORS(call_target, Address)
// Dispatched behavior.
DECL_PRINTER(WasmInternalFunction)
......@@ -909,7 +909,7 @@ class AsmWasmData : public TorqueGeneratedAsmWasmData<AsmWasmData, Struct> {
class WasmTypeInfo
: public TorqueGeneratedWasmTypeInfo<WasmTypeInfo, HeapObject> {
public:
DECL_EXTERNAL_POINTER_ACCESSORS(native_type, Address);
DECL_EXTERNAL_POINTER_ACCESSORS(native_type, Address)
DECL_PRINTER(WasmTypeInfo)
......@@ -1033,7 +1033,7 @@ class WasmContinuationObject
static Handle<WasmContinuationObject> New(
Isolate* isolate, Handle<WasmContinuationObject> parent);
DECL_EXTERNAL_POINTER_ACCESSORS(jmpbuf, Address);
DECL_EXTERNAL_POINTER_ACCESSORS(jmpbuf, Address)
DECL_PRINTER(WasmContinuationObject)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment