Commit 8809950e authored by Igor Sheludko's avatar Igor Sheludko

Revert "Reland "[ext-code-space] Enable Code-less embedded builtins""

This reverts commit c89998d9.

Reason for revert: a lot of unexpected memory regressions that
require investigation.

Original change's description:
> Reland "[ext-code-space] Enable Code-less embedded builtins"
>
> This is a reland of commit 40901824
> The Ubsan issue is fixed here: https://chromium-review.googlesource.com/c/v8/v8/+/3849038.
>
> Original change's description:
> > [ext-code-space] Enable Code-less embedded builtins
> >
> > Bug: v8:11880, v8:12592
> > Change-Id: I8d3d6ad0a4c26eb1fea2a998ffeddd1d96afa690
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784593
> > Commit-Queue: Igor Sheludko <ishell@chromium.org>
> > Reviewed-by: Jakob Linke <jgruber@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#82642}
>
> Bug: v8:11880, v8:12592
> Change-Id: I66373d6af30b060d1204b952d733e260228548df
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3846493
> Commit-Queue: Igor Sheludko <ishell@chromium.org>
> Reviewed-by: Jakob Linke <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#82683}

Bug: v8:11880, v8:12592, chromium:1356329
Change-Id: I07aaf714da8d7afc66cf4116f189dd5dde5b8818
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3856357Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#82721}
parent ee58c57b
......@@ -227,7 +227,7 @@ const size_t kShortBuiltinCallsOldSpaceSizeThreshold = size_t{2} * GB;
// This flag enables the mode when V8 does not create trampoline Code objects
// for builtins. It should be enough to have only CodeDataContainer objects.
// TODO(v8:11880): remove the flag one the Code-less builtins mode works.
#define V8_REMOVE_BUILTINS_CODE_OBJECTS true
#define V8_REMOVE_BUILTINS_CODE_OBJECTS false
class CodeDataContainer;
using CodeT = CodeDataContainer;
#else
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment