Revert "[test] Migrate cctest/test-weakmaps to unittests/"

This reverts commit d83346be.

Reason for revert: Seems to be breaking TSAN bot (https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20stress-incremental-marking/8867/overview)

Original change's description:
> [test] Migrate cctest/test-weakmaps to unittests/
>
> Bug: v8:12781
> Change-Id: Ief6bd7ee0ff2876e19970b2fb6af4f3208ec7f4e
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3815486
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#82699}

Bug: v8:12781
Change-Id: Ia20078e9f40d0e2257cf0b953ddd2e72594c4085
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855938
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#82713}

test/cctest/BUILD.gn

@@ -215,6 +215,7 @@ v8_source_set("cctest_sources") {
     "test-usecounters.cc",
     "test-utils.cc",
     "test-verifiers.cc",
+    "test-weakmaps.cc",
     "torque/test-torque.cc",
     "trace-extension.cc",
     "trace-extension.h",
@@ -269,8 +270,7 @@ v8_source_set("cctest_sources") {
       "test-macro-assembler-mips64.cc",
     ]
   } else if (v8_current_cpu == "x64") {
-    sources += [
-      ### gcmole(arch:x64) ###
+    sources += [  ### gcmole(arch:x64) ###
       "test-log-stack-tracer.cc",
     ]
     if (is_win) {

test/cctest/cctest.status

@@ -51,6 +51,9 @@
   # works as intended.
   'test-api/DisallowJavascriptExecutionScope': [FAIL],
 
+  # We do not yet shrink weak maps after they have been emptied by the GC
+  'test-weakmaps/Shrinking': [FAIL],
+
   # Boot up memory use is bloated in debug mode.
   'test-mark-compact/BootUpMemoryUse': [PASS, ['mode == debug', FAIL]],
 
@@ -1098,6 +1101,8 @@
   'test-weak-references/WeakArrayListBasic': [SKIP],
   'test-weak-references/WeakArraysBasic': [SKIP],
   'test-weak-references/WeakReferencesBasic': [SKIP],
+  'test-weakmaps/WeakMapsWithChainedEntries': [SKIP],
+  'test-weakmaps/Weakness': [SKIP],
   # Timeout (too many GCs)
   'test-heap/Regress8014': [SKIP],
   'test-accessors/HandleScopePop': [SKIP],

test/unittests/BUILD.gn

@@ -477,7 +477,6 @@ v8_source_set("unittests_sources") {
     "objects/symbols-unittest.cc",
     "objects/value-serializer-unittest.cc",
     "objects/weakarraylist-unittest.cc",
-    "objects/weakmaps-unittest.cc",
     "objects/weaksets-unittest.cc",
     "parser/ast-value-unittest.cc",
     "parser/decls-unittest.cc",

test/unittests/heap/heap-utils.h

@@ -97,15 +97,6 @@ class WithHeapInternals : public TMixin, HeapInternalsBase {
       page->MarkNeverAllocateForTesting();
     }
   }
-
-  void GcAndSweep(i::AllocationSpace space) {
-    heap()->CollectGarbage(space, GarbageCollectionReason::kTesting);
-    if (heap()->mark_compact_collector()->sweeping_in_progress()) {
-      SafepointScope scope(heap());
-      heap()->mark_compact_collector()->EnsureSweepingCompleted(
-          MarkCompactCollector::SweepingForcedFinalizationMode::kV8Only);
-    }
-  }
 };
 
 using TestWithHeapInternals =                  //

test/unittests/unittests.status

@@ -5,24 +5,20 @@
 [
 
 [ALWAYS, {
-  'IntlTest.StringLocaleCompareFastPath': [['mode != release', SKIP], SLOW, NO_VARIANTS],
-
   # BUG(5193). The cpu profiler tests are notoriously flaky.
   'SamplerTest.LibSamplerCollectSample': [SKIP],
 
   # This tests only the type system, no point in running several variants.
   'TypesTest.*': [PASS, NO_VARIANTS],
 
-  # These tests are supposed to fail in a slow DCHECK, skip them otherwise.
-  'LocalHandlesTest.DereferenceLocalHandleFailsWhenDisallowed': [SKIP, ['mode == debug', FAIL]],
-  'PersistentHandlesTest.DereferencePersistentHandleFailsWhenDisallowed': [SKIP, ['mode == debug', FAIL]],
-
   # https://crbug.com/v8/8919
   'PlatformTest.StackAlignment': [PASS, ['not is_clang', SKIP]],
 
-  # We do not yet shrink weak maps after they have been emptied by the GC
-  'WeakMapsTest.Shrinking': [FAIL],
+  # These tests are supposed to fail in a slow DCHECK, skip them otherwise.
+  'LocalHandlesTest.DereferenceLocalHandleFailsWhenDisallowed': [SKIP, ['mode == debug', FAIL]],
+  'PersistentHandlesTest.DereferencePersistentHandleFailsWhenDisallowed': [SKIP, ['mode == debug', FAIL]],
 
+  'IntlTest.StringLocaleCompareFastPath': [['mode != release', SKIP], SLOW, NO_VARIANTS],
   'WeakSetsTest.WeakSet_Shrinking': [FAIL],
 }],  # ALWAYS
 
@@ -211,8 +207,6 @@
   'UnifiedHeapDetachedTest.AllocationBeforeConfigureHeap': [SKIP],
   'UnifiedHeapTest.FindingV8ToBlinkReference': [SKIP],
   'ManagedTest.GCCausesDestruction': [SKIP],
-  'WeakMapsTest.WeakMapsWithChainedEntries': [SKIP],
-  'WeakMapsTest.Weakness': [SKIP],
   'WeakSetsTest.WeakSet_Weakness': [SKIP],
   'WebSnapshotTest.SFIDeduplicationAfterBytecodeFlushing': [SKIP],