- 13 Aug, 2021 2 commits
-
-
Benedikt Meurer authored
Previously the V8 inspector would report native accessors, whose getter evaluates to a value without causing a side effect, as own data properties. But then the DevTools front-end will not be able to tell whether that accessor was actually an own property or just an inherited accessor. The reason for reporting them as own properties in the first place was to ensure that these properties show up in the object's preview. But that we can handle differently by just marking these properties as synthetic internally and including them in the preview. Bug: chromium:1076820 Change-Id: I223299af7954e7b1a4a16bb5180d4ceff50f170f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094005 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#76276}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bbf7f0e..5c5313f Rolling v8/buildtools/linux64: git_revision:eea3906f0e2a8d3622080127d2005ff214d51383..git_revision:69ec4fca1fa69ddadae13f9e6b7507efa0675263 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/24e92c2..671803f Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/b825591..83f8edb Rolling v8/third_party/aemu-linux-x64: qWiGSH8A_xdaUVO-GsDJsJ5HCkIRwZqb-HDyxsLiuWwC..21LVieOtkkse_Rl-9YyxWMe3RIxZ3Gpb_MUUrgwitckC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/abc7ba7..bd47f22 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/49a703f..699d70d Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/75e34bc..a38aef9 Rolling v8/third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/7c54c1f..6ac5f7e Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6a8e571..f1ab49b Rolling v8/tools/luci-go: git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe..git_revision:a5735121c6339dee9b1b3644535e230744daaac9 Rolling v8/tools/luci-go: git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe..git_revision:a5735121c6339dee9b1b3644535e230744daaac9 Rolling v8/tools/luci-go: git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe..git_revision:a5735121c6339dee9b1b3644535e230744daaac9 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I341085653d5e8ce7f76f4dbe0d3d34c6183b1377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093309Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#76275}
-
- 12 Aug, 2021 32 commits
-
-
Zhi An Ng authored
This reverts commit a3b2c4ec. Reason for revert: UBSan https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8839060153390139249/+/u/Check/gdbjit Original change's description: > [wasm][diagnostics] Support WasmCode in gdb JIT integration > > - Add new enum WASM_CODE to JitCodeEvent::CodeType > - Use AddressRegion instead of AddressRange (remove the latter) > - Change CodeDescription constructor to take an AddressRegion, > both JIT_CODE and WASM_CODE use this > - Add a simple mjsunit test that sets --gdbjit to check that > we don't crash. > - Add a api test for adding WASM_CODE > > Bug: v8:11908 > Change-Id: I6e87fadc2df67978144d78caf9800c3982bc3705 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3067754 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#76271} Bug: v8:11908 Change-Id: Ic1a74a9239e8ef6107efd36f61c089ae6bfc5b6c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093365 Auto-Submit: Zhi An Ng <zhin@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#76274}
-
Milad Fa authored
Change-Id: I89694796962d46b4fb1ae244ee39639576659465 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3092025Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#76273}
-
Ng Zhi An authored
Use punpcklqdq/punpckhqdq instead of pshufd. Bug: v8:12075 Change-Id: I0260136d3727fde7bae4359df015d2b0090e8b29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3092554Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#76272}
-
Ng Zhi An authored
- Add new enum WASM_CODE to JitCodeEvent::CodeType - Use AddressRegion instead of AddressRange (remove the latter) - Change CodeDescription constructor to take an AddressRegion, both JIT_CODE and WASM_CODE use this - Add a simple mjsunit test that sets --gdbjit to check that we don't crash. - Add a api test for adding WASM_CODE Bug: v8:11908 Change-Id: I6e87fadc2df67978144d78caf9800c3982bc3705 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3067754Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#76271}
-
Rakhim Khismet authored
We add struct.set operation to the fuzzed module by choosing random structtype field and generating corresponding type. Bug: v8:11954 Change-Id: I858bd64dd4b7242f20d6d7a0a507f34469de49c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086469 Commit-Queue: Rakhim Khismet <khismet@google.com> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#76270}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/ab353c6e7..45a913c0 Bug: v8:7834, v8:12085, v8:12086, v8:120448 Change-Id: I3fa00574d99dbeb5a87d1ecb2fcba92a2e2ff79c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3091646Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#76269}
-
Ng Zhi An authored
Move the implementation into shared macro-assembler. TurboFan and Liftoff for both ia32 and x64 can now share the implementation. No functionality change expected. Bug: v8:11589 Change-Id: Ia1f680ba139fca627e82e7dc0a9cf1c833e483cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3088513 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Joyee Cheung authored
Landing define-class-fields microbencharks upstream before optimization so that the benefit is visible. Bug: v8:9888 Change-Id: Ie3bd2bd2cdd5710f43e398aa834985b5faa973d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999030 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#76267}
-
Samuel Groß authored
Bug: chromium:1218005 Change-Id: I52368a70c448b8b928fb0cd04a9b7a72f86fafad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3090973 Auto-Submit: Samuel Groß <saelo@chromium.org> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#76266}
-
Frank Tang authored
flag --harmony_intl_enumeration I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/Txtf_rSqGH8/m/e27FY33JAQAJ Design Doc: https://docs.google.com/document/d/1lbj_YVW-xhzYNMQeHB-qDjVkf4SA-eTHYpYXx3Oaud8 https://chromestatus.com/guide/edit/5649454590853120 Bug: v8:10743 Change-Id: I3bfe0c25b50eb55025498534eba975a20723bd2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953519 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Move the implementation into shared macro-assembler. TurboFan and Liftoff for both ia32 and x64 can now share the implementation. No functionality change expected. Bug: v8:11589 Change-Id: I8d3567ef6e4a430fe8e007e44d5d55cf8e8a6a7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3088273 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Victor Gomes authored
No-Try: true Change-Id: I05c3c4181a905245b23c7a983ffcfcb189e8f05e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3089167 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
QiuJi authored
Change-Id: Idae3870fc82ac117f9d7d916298123921bfcf286 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3089007Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/master@{#76262}
-
Jakob Gruber authored
The concurrent version was added recently in crrev.com/c/3085262. - UnusedPropertyFields requires the MapUpdater lock. - instance_descriptors must be read atomically on the bg thread. Finally, there appears to be a false positive report for the pattern: x = is_concurrent ? foo(kAcquireLoad) : foo(); Here, clang emits code that executes both the atomic and nonatomic reads when is_concurrent is true. Needs more investigation. Bug: v8:7790, chromium:1239009 Change-Id: I07d442e72cf0278f79f202a267e8d246f8abca1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3090341 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#76261}
-
Anton Bikineev authored
fetch_or (lock-prefixed-or on x86) is emulated with branching on armv7/armv8 and therefore generates more instructions. This improves android-binary-size by 45K. It should also improve performance. Bug: chromium:1238884 Change-Id: I48f59b645a4bb872b3798a1fde11608fd2930ce6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3090342 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#76260}
-
Michaël Zasso authored
Use `extern "C"` to declare the __readfsdword function. Fixes error C2732 in the Node.js CI. Bug: chromium:796644 Change-Id: If261985e65bfdade53ce06ff28afe0e2db402f7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086457Reviewed-by:
-
Clemens Backes authored
This should not be needed any more after https://crrev.com/c/2944808, which made job execution deterministic in predictable mode. R=thibaudm@chromium.org Bug: v8:11848, v8:10936 Change-Id: I7f71af063d366ca2ba9223afeb6c2caa77b02a99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3090334Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:11947 Change-Id: Ie32d79d13f85b2929310a75923a02e1585565265 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3090825Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#76257}
-
Ross McIlroy authored
These are no longer enabled, so remove the code mitigation logic from the codebase. BUG=chromium:1003890 Change-Id: I536bb1732e8463281c21da446bbba8f47ede8ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045704 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Camillo Bruni authored
d8 throws on unhandled rejected Promises since https://crrev.com/c/2238569 so no special handling beyond throwing in the async hooks themselves is needed. Drive-by-fix: Use v8::Isolate* as local variable. Bug: chromium:1238467 Change-Id: I271720cd9cfd1d30b58b5407c700b0f730910968 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3090333 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#76255}
-
Santiago Aboy Solanes authored
Bug: v8:12065 Change-Id: I88213ef7eeb37c280a89f08fed3ea256cc0997df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086460Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:7790 Change-Id: I4e25140a83a0ce851195e274a489ac13cacdf676 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086477Reviewed-by:
-
Frank Tang authored
Move from recusion to loop to avoid stack overflow Bug: v8:12059 Change-Id: I44981f4271495adf00d7697114663f966b8f9f11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3087937Reviewed-by:
-
Lutz Vahl authored
TBR=hablich@chromium.org, vahl@chromium.org Change-Id: I223f3018248459f03fab14003c59b27f7b9834ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3090329Reviewed-by:
Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/master@{#76251}
-
Jakob Gruber authored
OSR and concurrent_inlining are not strictly related, thus remove the !is_osr condition when setting the concurrent_inlining flag. OSR jobs simply execute on the main thread, whether CI is enabled or not. Drive-by: Exhaustive CodeKind switch cases. Bug: v8:7790,v8:11981 Change-Id: Ia50e083f1c39d1d9845b1ef4e16ae8fd10798fb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086480 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Leszek Swirski authored
The baseline compiler wasn't saving the accumulator when generating code for StaDataPropertyInLiteral. This could lead to issues in cases where the bytecode compiler optimized away loads of a register into the accumulator. Fixed: chromium:1236978 Change-Id: I8603a4c7446664f82b35db61f81cacefce2e4f3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3090326 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#76249}
-
Peter Kasting authored
Bug: chromium:1066980 Change-Id: I92570706da4e6f8380f100bec12c8414f6ff2edc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086221 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#76248}
-
Jakob Gruber authored
Bug: v8:7790 Change-Id: I9bd852d42cbc81ba12dc81166990a49a6b91168a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3089153 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
Make "emit_s128_set_if_nan" take LiftoffRegisters rather than Registers. The decoding of the FP register code is architecture dependent, and in particular we expect an FP pair on arm. R=clemensb@chromium.org Bug: v8:11856 Change-Id: I44a364c3ef3a0c41000ea1f6cead4916ee04145d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3089165Reviewed-by:
-
Camillo Bruni authored
All the flags are in place and we can disable the slow histogram to fix the expected regression we see on the perf bots. Bug: v8:11946, chromium:1238515 Change-Id: I063582b4dede32bf90b5d5d94ba3a9dfd9f56718 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3089155 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/4124223..2d054b6 Merge branch 'main' of github.com:google/benchmark (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/2d054b6 preparing v1.5.6 release (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/ddc76e5 Set theme jekyll-theme-modernist (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/cb9afbb so much for googletest not failing any more (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/07f833d turn back on strict mode for googletest as it no longer breaks (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/d0db4e0 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I4cd2719542b4c8cf720db557c196147ad0082157 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3087602Reviewed-by:
-
Ng Zhi An authored
Move I32x4SConvertF32x4 into shared implementation, and takes care of both AVX and no-AVX implementation. Instruction selector still requires dst == src to save a move in codegen. Bug: v8:11589 Change-Id: Ie982682b3002192ab27700bf73f8c1e66aeba492 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086732 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
- 11 Aug, 2021 6 commits
-
-
Junliang Yan authored
Change-Id: Ib0a630d0fb5e07e3cec77ce418827f746e64a656 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3088548Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#76242}
-
Milad Fa authored
MovFloatToInt and MovIntToFloat have been optimized on Power8 and above to use VSX instructions instead if using the memory. Change-Id: I77af9aa20aa477f8f9e3ec9545445ef777aa0c72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3087726 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
-
Junliang Yan authored
Change-Id: I6fb16c82e5c730e35d90a3de6c746f9c4415dc00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3087725Reviewed-by:
-
Clemens Backes authored
This adds dedicated histograms for measuring the memory consumption and compilation time for compiling "huge functions". Those are functions with a body of more than 100kB. They are a *very* small fraction of all functions (<0.01% according to current data), but their compile time is often unproportionally large. Since they would just disappear in the overall histograms, this CL adds dedicated histograms to make the compile time and memory consumption of those functions more visible. R=ecmziegler@chromium.org Bug: chromium:1238828 Change-Id: I30bd07792ef4d9d67ff60c49c9edd0892c5c6e6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3089166Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#76239}
-
Junliang Yan authored
Change-Id: I5bab2fec2fc2b7256580982e6433f98f93b2c2f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3088186Reviewed-by:
-
Ng Zhi An authored
MIN_CONTEXT_SLOTS is set to be equals to EXTENSION_INDEX, which is 2, see https://source.chromium.org/chromium/chromium/src/+/main:v8/src/objects/contexts.h;l=519;drc=bb32a2dd632d7350dfb722c9b4ffe4d6e3633225 We check for the scope's ContextHeaderLength instead, and handle both cases where there is an extension slot or not. Change-Id: I0fe46cb49bfcd4b8321f777d47e375e0fd204d00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3085626 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#76237}
-
