• Benedikt Meurer's avatar
    [inspector] Don't pretend that native accessors are own properties. · 52720f63
    Benedikt Meurer authored
    Previously the V8 inspector would report native accessors, whose getter
    evaluates to a value without causing a side effect, as own data
    properties. But then the DevTools front-end will not be able to tell
    whether that accessor was actually an own property or just an inherited
    accessor.
    
    The reason for reporting them as own properties in the first place was
    to ensure that these properties show up in the object's preview. But
    that we can handle differently by just marking these properties as
    synthetic internally and including them in the preview.
    
    Bug: chromium:1076820
    Change-Id: I223299af7954e7b1a4a16bb5180d4ceff50f170f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094005
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76276}
    52720f63
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...