• Jakob Gruber's avatar
    [compiler] Fix multiple races in Map::FindElementsKindTransitionedMap · 1b22e6fb
    Jakob Gruber authored
    The concurrent version was added recently in crrev.com/c/3085262.
    
    - UnusedPropertyFields requires the MapUpdater lock.
    - instance_descriptors must be read atomically on the bg thread.
    
    Finally, there appears to be a false positive report for the pattern:
    
     x = is_concurrent ? foo(kAcquireLoad) : foo();
    
    Here, clang emits code that executes both the atomic and nonatomic
    reads when is_concurrent is true. Needs more investigation.
    
    Bug: v8:7790, chromium:1239009
    Change-Id: I07d442e72cf0278f79f202a267e8d246f8abca1b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3090341
    Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarSantiago Aboy Solanes <solanes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76261}
    1b22e6fb
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...