Commits · 4c707a2c53fd5e12169ae7f6322e4c164fc256f7 · Linshizhi / Chromium_Depot_tools

24 Sep, 2019 2 commits

git-cl: Re-write some tests to use mock. · 4c707a2c

Edward Lemur authored Sep 24, 2019

I think this makes tests easier to read and write.

Change-Id: I9430a5d40e3466ff2a24b6b40253419aea3f30b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1820034Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

4c707a2c

[git-cl] allow setting the bug during force mode · 8b95534d

Anthony Polito authored Sep 24, 2019

Bug: 1001709
Change-Id: I53e7699cb38d810d0a8c88d40907bf249174ad8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1804603Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>

8b95534d

23 Sep, 2019 8 commits

auth: Use luci-auth to get credentials. · ba5bc99b

Edward Lemur authored Sep 23, 2019

Bug: 1001756
Change-Id: Ieab5391662e92ec9e2715a81fce2cef41717c2e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1790607
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

ba5bc99b

Remove unused imports in depot_tools/*.py · 3841eaa1

Quinten Yearsley authored Sep 23, 2019

I know that sometimes imports can have side-effects,
so unused imports shouldn't always be removed, but these
ones look like they could be.

Change-Id: Iea9f82afa99b0ea35f29a28f20ce0493b579cfee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1819860Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

3841eaa1

gclient: Execute python hooks using vpython. · 6f18e687

Edward Lemur authored Sep 23, 2019

Change-Id: I032c838c07ca8b715976bd9dc428c1bd6a77d80b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1793009Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

6f18e687

Revert "git-cache: don't limit pack files to 2GiB." · fdb59f0d

Andrii Shyshkalov authored Sep 23, 2019

This reverts commit 82ae4b4b.

Reason for revert: didn't help. Something else limits 'git gc' by 2GB.
However, even so, total amount of .pack files for chromium/src is <7.5GB.

Original change's description:
> git-cache: don't limit pack files to 2GiB.
>
> This is only relevant to 1 builder which updates git cache bundles.
> Since some time in 2018-2019, it started creating several 2GiB packs
> for chromium/src. I verified that the setting affecting it is
>   core.deltaBaseCacheLimit
>
> Log file of a build which I observed while ssd-ed into the machine (internal):
>   https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8901682638839779824/+/steps/Updating_https:__chromium.googlesource.com_chromium_src/0/stdout
> Git version: version:2.21.0.chromium16
>
> R=ehmaldonado
>
> Change-Id: I52cadfb9f34faea09a57d53387cab7e0538362b9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818076
> Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=tandrii@google.com,ehmaldonado@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I24915555c703bc92fda921524820405de5d69f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1817101Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

fdb59f0d

Add Dawn to projects for my_activity.py · 06e1869f

Ryan Harrison authored Sep 23, 2019

Change-Id: Id22cde5b5c113fb1145c30afb6671ac2ec32afb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1819547
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

06e1869f

Remove some unused private things in git_cl · 90a67e2f

Quinten Yearsley authored Sep 23, 2019

There are many functions in git_cl that appear unused, although
it's possible that some of them are used in other places, where
git_cl may be imported as a library.

This CL just removes some of the private ones, which at least
were not supposed to be used from other places.

Things removed here:

 - _get_commiter_timestamp
 - _git_amend_head
 - GitCookiesChecker._get_usernames_of_domain
 - constants MERGE_BRANCH, CHERRY_PICK_BRANCH;
   the comment says that these are supposed to
   be used in CMDland, but apparently they aren't.
   contextlib which is only used by this, is also
   removed
 - CodereviewSettingsFileMock in git_cl_test;
   it is not used anywhere in the test, and I
   assume that nobody's importing and using
   git_cl_test...

git_cl_test still passes, git cl seems to still work

Change-Id: Ib8eee0dfb181c8cda04c0894d2daea52b3ad42ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818621Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

90a67e2f

Roll recipe dependencies (trivial). · 314adcb8

recipe-roller authored Sep 23, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/494a88f6f8c345512a5dbb9136ca99ab10bc6dd5 Convert entire tricium Results message to JSON only once (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I23d06ccdd70f5e03f6e81574c05a06fb5d192d4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1819539Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

314adcb8

Roll recipe dependencies (trivial). · b5578f4f

recipe-roller authored Sep 23, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e8d0b68df47a63f3a184f64c138404a139e046ed [swarming] expose current bot_id and task_id on api.swarming. (tandrii@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I02270fd71a462c1b3a342e851baef35af27ec655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818976Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b5578f4f

22 Sep, 2019 2 commits

git-cache: fix bug in prior CL. · 7cb60e81

Andrii Shyshkalov authored Sep 22, 2019

cwd param isn't necessary, because actual cwd is already correct --
see 'git gc' invocation below.

R=ehmaldonado, iannucci

Change-Id: Ia885ad32b11b0de37d3b0e4e5359d2031b6852d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818455
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

7cb60e81

git-cache: don't limit pack files to 2GiB. · 82ae4b4b

Andrii Shyshkalov authored Sep 22, 2019

This is only relevant to 1 builder which updates git cache bundles.
Since some time in 2018-2019, it started creating several 2GiB packs
for chromium/src. I verified that the setting affecting it is
core.deltaBaseCacheLimit

Log file of a build which I observed while ssd-ed into the machine (internal):
https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8901682638839779824/+/steps/Updating_https:__chromium.googlesource.com_chromium_src/0/stdout
Git version: version:2.21.0.chromium16

R=ehmaldonado

Change-Id: I52cadfb9f34faea09a57d53387cab7e0538362b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818076
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

82ae4b4b

21 Sep, 2019 3 commits

gclient_utils: Actually pass the include_zero parameter to Annotated constructor · 383f6cf0

Raul Tambre authored Sep 21, 2019

Change-Id: I3d1e155ed2b6c4b4d6549bfb609358538dcdcd0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815868
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

383f6cf0

tests/gclient_scm_test.py: Fix invalid escape sequences in regex strings · a79f0e50

Raul Tambre authored Sep 21, 2019

Note that on line 504 I also fixed the test on windows by allowing \. Also properly escaped /.

Errors:
C:\Google\depot_tools\tests\gclient_scm_test.py:42: SyntaxWarning: invalid escape sequence \[
  TIMESTAMP_RE = re.compile('\[[0-9]{1,2}:[0-9]{2}:[0-9]{2}\] (.*)', re.DOTALL)
C:\Google\depot_tools\tests\gclient_scm_test.py:504: SyntaxWarning: invalid escape sequence \.
  "breaking lock.*\.git/index\.lock")

Bug: 958138
Change-Id: I19ef98538a1c172d7139ca2d7097a7fbc33ebe80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815866
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>

a79f0e50

git-cache: add --gc-aggressive support. · dcfe55f1

Andrii Shyshkalov authored Sep 21, 2019

This will be used on internal cache updater.

For instance, I've just compressed chromium/src resulting bootstrap
files from 20GiB to 7.5 GiB.

R=ehmaldonado

Change-Id: I15411700eb2ac3a26d1c658a12288cc49e48fd48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1802877Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

dcfe55f1

20 Sep, 2019 2 commits

git-cl: Use buildbucket v2 to schedule try jobs. · d4d1ba49

Edward Lemur authored Sep 20, 2019

Change-Id: I3bad4314973cda7e285b5b9cb823f61cd7fb2dff
Bug: 976104
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1809516
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

d4d1ba49

Roll recipe dependencies (trivial). · 410cf3af

recipe-roller authored Sep 20, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/849795f393c621ebbe81a1be35cb45ec0ab3ede5 Spellcheck recipes-py docs (qyearsley@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I958bcf431ef1707357bf5d9c758fea0e48bce250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1816909Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

410cf3af

19 Sep, 2019 3 commits

Reland "Set core.trustctime=false during git checkout operations." · 7735f52c

Nico Weber authored Sep 19, 2019

This is a reland of 3f797636.
Last time it broke a skia test. The test has since been fixed
in https://crbug.com/1005388

Original change's description:
> Set core.trustctime=false during git checkout operations.
>
> This should be faster and more general than running
> `git index --refresh` over all git repositories we can find.
>
> See "Proposal: Setting core.trustctime=false on Chromium's bots"
> on infra-dev (linked to from bug 330461 comment 45).
>
> Bug: 330461,642711,746763,740301.
> Change-Id: I7c35cffa107d46d9cf98f0e3e813ef2ab98df5fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1809419
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
> Commit-Queue: Nico Weber <thakis@chromium.org>

Recipe-Nontrivial-Roll: chromiumos
Bug: 330461, 642711, 746763, 740301.
Change-Id: I5d09a93689e53e4339bff7b1173df938aee73a4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1810400
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

7735f52c

Reland "repo: pull in updates from latest release" · 64ae6993

Nico Weber authored Sep 19, 2019

This reverts commit 2c80d01b.

Reason for revert: Didn't help.

Original change's description:
> Revert "repo: pull in updates from latest release"
> 
> This reverts commit 8baaec47.
> 
> Reason for revert: Speculative, to see if this unbreaks
> https://ci.chromium.org/p/infra/builders/try/ChromiumOS%20downstream%20Recipe%20Roll%20tester%20from%20Depot%20Tools
> 
> Original change's description:
> > repo: pull in updates from latest release
> > 
> > These are mostly about rolling in Python 3 encoding fixes.
> > 
> > Bug: None
> > Test: `repo sync` works w/Python 3
> > Change-Id: I7d749a3a62523a7c802fb0ed7dcd383868df1d6f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1809420
> > Commit-Queue: Mike Frysinger <vapier@chromium.org>
> > Reviewed-by: Alex Klein <saklein@chromium.org>
> 
> TBR=vapier@chromium.org,saklein@chromium.org
> 
> Change-Id: I7b446fe0460390dcefe6248f1ef7a004335bb796
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: None
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1814467
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>

TBR=vapier@chromium.org,thakis@chromium.org,saklein@chromium.org

Change-Id: I5e1ff54478d8597c33901f8d7a2d7bcc6c203d20
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1814469Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

64ae6993

Revert "repo: pull in updates from latest release" · 2c80d01b

Nico Weber authored Sep 19, 2019

This reverts commit 8baaec47.

Reason for revert: Speculative, to see if this unbreaks
https://ci.chromium.org/p/infra/builders/try/ChromiumOS%20downstream%20Recipe%20Roll%20tester%20from%20Depot%20Tools

Original change's description:
> repo: pull in updates from latest release
> 
> These are mostly about rolling in Python 3 encoding fixes.
> 
> Bug: None
> Test: `repo sync` works w/Python 3
> Change-Id: I7d749a3a62523a7c802fb0ed7dcd383868df1d6f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1809420
> Commit-Queue: Mike Frysinger <vapier@chromium.org>
> Reviewed-by: Alex Klein <saklein@chromium.org>

TBR=vapier@chromium.org,saklein@chromium.org

Change-Id: I7b446fe0460390dcefe6248f1ef7a004335bb796
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1814467Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

2c80d01b

18 Sep, 2019 4 commits

Revert "Set core.trustctime=false during git checkout operations." · c6be56ec

Edward Lesmes authored Sep 18, 2019

This reverts commit 3f797636.

Reason for revert: 
Breaks Skia https://skia-review.googlesource.com/c/buildbot/+/242590

Original change's description:
> Set core.trustctime=false during git checkout operations.
> 
> This should be faster and more general than running
> `git index --refresh` over all git repositories we can find.
> 
> See "Proposal: Setting core.trustctime=false on Chromium's bots"
> on infra-dev (linked to from bug 330461 comment 45).
> 
> Bug: 330461,642711,746763,740301.
> Change-Id: I7c35cffa107d46d9cf98f0e3e813ef2ab98df5fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1809419
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
> Commit-Queue: Nico Weber <thakis@chromium.org>

TBR=thakis@chromium.org,tandrii@google.com

Change-Id: I908ce92748f7b516efed5f2c02138ecfee306c88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 330461, 642711, 746763, 740301.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1811537Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

c6be56ec

repo: pull in updates from latest release · 8baaec47

Mike Frysinger authored Sep 18, 2019

These are mostly about rolling in Python 3 encoding fixes.

Bug: None
Test: `repo sync` works w/Python 3
Change-Id: I7d749a3a62523a7c802fb0ed7dcd383868df1d6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1809420
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>

8baaec47

Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" · 24995256

Edward Lemur authored Sep 18, 2019

Don't call ensure_bootstrap from update_depot_tools.
ensure_bootstrap also updates gsutil and all versions of pylint
which is slow, particularly on MinGW.

Original change's description:
> depot_tools: Bootstrap Python 3 on Linux/Mac
>
> This will make it possible for developers to execute depot_tools
> scripts using Python 3 in a known environment.
>
> Bug: 1002153
> Change-Id: I5ff492a49d227c1b5876f49adba020f51a575bdd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1762664
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

Bug: 1002153
Change-Id: Ia7579e440438897ba4a7c65a8b228dcfe7f28c86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1810040
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

24995256

Set core.trustctime=false during git checkout operations. · 3f797636

Nico Weber authored Sep 18, 2019

This should be faster and more general than running
`git index --refresh` over all git repositories we can find.

See "Proposal: Setting core.trustctime=false on Chromium's bots"
on infra-dev (linked to from bug 330461 comment 45).

Bug: 330461,642711,746763,740301.
Change-Id: I7c35cffa107d46d9cf98f0e3e813ef2ab98df5fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1809419Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>

3f797636

17 Sep, 2019 1 commit

Roll recipe dependencies (trivial). · 6f9a0238

recipe-roller authored Sep 17, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/af0d009a41a32bc8df33889d65de737798f9abc8 [swarming] Display timeout type when analyzing results. (kylecameron@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I213b134e95f7270102d508b14c400e6a47a28260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1809391Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

6f9a0238

16 Sep, 2019 6 commits

Revert "git-cl: Use bb to schedule try jobs." · 2c210a49

Edward Lemur authored Sep 16, 2019

This reverts commit 5b6ae8bc.

Reason for revert: Suspected breakage of wpt-importer (https://ci.chromium.org/p/infra/builders/cron/wpt-importer)

Original change's description:
> git-cl: Use bb to schedule try jobs.
>
> Bug: 976104
> Change-Id: I3423667f1ed9edfc5fa17842932de7704951fc62
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1801799
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

TBR=nodir@chromium.org,tandrii@google.com,ehmaldonado@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 976104
Change-Id: I885c1e71b34928c402d3375f820b28f3d6535c54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1806148Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

2c210a49

Revert "Reland "depot_tools: Bootstrap Python 3 on Linux/Mac"" · f73f0f40

Edward Lemur authored Sep 16, 2019

This reverts commits 0e85f633 and 9d25ad41.

Reason for revert:

Causes problems for MinGW users.

Original change's description:
> Reland "depot_tools: Bootstrap Python 3 on Linux/Mac"
>
> This is a reland of dbca865e
>
> Original change's description:
> > depot_tools: Bootstrap Python 3 on Linux/Mac
> >
> > This will make it possible for developers to execute depot_tools
> > scripts using Python 3 in a known environment.
> >
> > Bug: 1002153
> > Change-Id: I5ff492a49d227c1b5876f49adba020f51a575bdd
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1762664
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
>
> Bug: 1002153
> Change-Id: I6938a76ffa05366c21f7c56aed3d07ecb2b84443
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1798845
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=iannucci@chromium.org,dpranke@chromium.org,tandrii@google.com,ehmaldonado@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1002153
Change-Id: I3ee87b95b2532ec694d7f4f87cce8cde8ccf86eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1808137Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

f73f0f40

git-cl: Return exit code of bb when executing git-cl try. · 64d4a375

Edward Lemur authored Sep 16, 2019

Bug: 976104
Change-Id: I09412c19e373af05e629dccc9a9a4dbc760d3d89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1807613
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

64d4a375

Correct an error message where branch and url had changed places · 4a60db4c

Daniel Bratell authored Sep 16, 2019

With certain git remote problems an error message is emitted that
has the place of the url and the place of the branch wrong.

Example:
Remote "opera" for branch "git@github.com:operasoftware/gn-opera.git"
points to "bratell/no_jumbo_for_s", but it doesn't exist.

Should be:
Remote "opera" for branch "bratell/no_jumbo_for_s" points to
"git@github.com:operasoftware/gn-opera.git", but it doesn't exist.

R=dpranke@chromium.org

Change-Id: I484ac8af226903a49df1f62e837d01c345fb5f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1806595
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

4a60db4c

cipd: update to 2a121dde. · 9ccd0577

Andrii Shyshkalov authored Sep 16, 2019

Increases the max number of cached packages.

R=iannucci, vadimsh

Bug: 1003774
Change-Id: I489bca5e6ede4dfb28662b2ba640c972da5afb87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1806137
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

9ccd0577

Roll recipe dependencies (trivial). · 3ddc5235

recipe-roller authored Sep 16, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/87a0c8179bab672f7e51ec0b2e0f35bc87146d82 [swarming] Display timeout type when analyzing results. (kylecameron@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib62c535b09749d9ffb75f9e747584b995766055c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1804519Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3ddc5235

14 Sep, 2019 1 commit

setup_color: Don't output an error if GetConsoleMode fails · 73ec83f0

Raul Tambre authored Sep 14, 2019

Turns out GetConsoleMode fails if the user's console isn't native. This is sometimes the case for Git Bash.

Also moved the checking code out of the if block so it applies in generic console cases too.
This went unnoticed, because setup_color.py is currently only really used in Git scripts, which are piped.

Bug: 1001187
Change-Id: I93357e479f84122f759e419d15c02500809657d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1785605Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>

73ec83f0

13 Sep, 2019 2 commits

depot_tools: Fix update_depot_tools for Windows on MinGW · 9d25ad41

Edward Lemur authored Sep 13, 2019

Bug: 1002153
Change-Id: I518073646a6c1d4e6077adf2f717008ed9972b8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1803481Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

9d25ad41

git-cl: Remove ChangeListImplementation boilerplate. · 125d60a1

Edward Lemur authored Sep 13, 2019

Change-Id: I880c60e4b4e07fdb68a63af8d7a171d54371ee71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1802294
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

125d60a1

12 Sep, 2019 6 commits

git-cl: Use bb to schedule try jobs. · 5b6ae8bc

Edward Lemur authored Sep 12, 2019

Bug: 976104
Change-Id: I3423667f1ed9edfc5fa17842932de7704951fc62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1801799
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

5b6ae8bc

[vpython] Roll to 4722764c4f0247f32e18864c90bd349336bf684f · 57fe4169

smut authored Sep 12, 2019

Changes:
4722764c4 [vpython] Set default Python version explicitly

Bug: 1003552
Change-Id: I01c32b00b3b0ea7bb555d138e56228ae8346e50c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1801812Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: smut <smut@google.com>

57fe4169

Roll recipe dependencies (trivial). · 2d75cf62

recipe-roller authored Sep 12, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8d1e67e5cc59fe452451804e811e144a318822d2 Add dry_run option for trivial autorolls (olivernewman@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2c458fa686f407d54010fc23598a516e411fc3ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1801800Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2d75cf62

git-cl: Remove support for buildbot masters in git-cl. · c8b67ed8

Edward Lemur authored Sep 12, 2019

Bug: 976104
Change-Id: Ief05a8923fcbb9e7515d7c9031afb18b7544da6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1801797Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

c8b67ed8

Roll recipe dependencies (trivial). · 0910f787

recipe-roller authored Sep 12, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/15204d34b732de75d45b06ac45b6d805ede5c689 [raw_io] Make missing placeholder files testable (olivernewman@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I338456a739858a8780acea2cc4c6c06410eb34e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1799257Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

0910f787

Allow TBR for CLs with approved changes to OWNERS files · 3fcadbb9

Alan Cutter authored Sep 12, 2019

https://chromium-review.googlesource.com/982601 disabled TBR for CLs that
modified OWNERS files. This CL relaxes the restriction to permit TBR for
CLs that have LGTMs for their modifications to OWNERS files.

Bug: 688115
Change-Id: I47fef6b1eb021ca7cdfc003dc57722643b174a6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1797605
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

3fcadbb9