setup_color: Don't output an error if GetConsoleMode fails
Turns out GetConsoleMode fails if the user's console isn't native. This is sometimes the case for Git Bash. Also moved the checking code out of the if block so it applies in generic console cases too. This went unnoticed, because setup_color.py is currently only really used in Git scripts, which are piped. Bug: 1001187 Change-Id: I93357e479f84122f759e419d15c02500809657d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1785605Reviewed-by:Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Auto-Submit: Raul Tambre <raul@tambre.ee>
Showing
Please
register
or
sign in
to comment