- 19 Nov, 2020 12 commits
-
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I5d0cc06fafbe7fc05549a4b8fd7f602eaf838bba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2526382 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#71283}
-
Omer Katz authored
This is required for enabling scopes such that NotifySweepingCompleted is not called from within a scope. Bug: chromium:1056170 Change-Id: Ia66aa4de8c22bfa7dfe1e02ee1e0d3ad088f7bf6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2549761Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#71282}
-
Marja Hölttä authored
When accessing a super property which is a getter, the receiver is not restricted the same way as when doing normal property access. In particular, the receiver can be null / undefined. Bug: v8:9237, chromium:1148758, v8:11161 Change-Id: Ic6bc2053e5d046d4b19e868312aa9b50025256a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2549941 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#71281}
-
Dominik Inführ authored
Unpark the thread for logging in TraceAbortedJob. With FLAG_trace_opt enabled, this method is going to access the heap and therefore the local isolate cannot be parked. Bug: chromium:1149131, v8:10315 Change-Id: Ic08de3aebf000df6a4122602940d9f11112b430b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2549946Reviewed-by:
-
Gus Caplan authored
Bug: v8:10961 Change-Id: I79f8410cac1c949100231d4c57dbea0379e88475 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2441128 Commit-Queue: Gus Caplan <snek@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#71279}
-
Maya Lekova authored
This CL moves the disabling to the test source code. Bug: v8:11178 Change-Id: I9771c1eb2ea474143bb401ba40f4452f6e6572ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2549963 Commit-Queue: Maya Lekova <mslekova@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Add ASSERT_NO_SCRIPT_NO_EXCEPTION for places where we don't want any runtime overhead. Change-Id: Iac4e87a8802f2c93b0ba3e981fe3b3ac67a4cdba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546692 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#71277}
-
Clemens Backes authored
For people not too familiar with cloud storage, the direct URL makes it easier to download the zip archive. R=machenbach@chromium.org Bug: chromium:1142437, v8:10891 Change-Id: I6b29ebaac37489a73c4f75473d07e04e7200f2c3 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543395 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71276}
-
Frank Emrich authored
This CL adds partial support for objects whose slow mode dictionaries are OrderedNameDictionaries. This is the case for all slow mode objects if V8_DICT_MODE_PROTOTYPES is enabled. In particular, this part contains the remaining fixes to runtime code, except for the class templating logic, which follows in a later CL. Bug: v8:7569 Change-Id: Ib4d08d7d352125709ca916dfc75018dabf71b0cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2540549Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Frank Emrich <emrich@google.com> Cr-Commit-Position: refs/heads/master@{#71275}
-
Dominik Inführ authored
This is a reland of e95e1b62 After landing https://crrev.com/c/2546682, this CL can be relanded without changes. Original change's description: > [heap] Introduce LocalIsolate for main thread > > Add a LocalIsolate for the main thread to Isolate. This LocalIsolate is > kept alive during the whole lifetime of the Isolate. The main thread > LocalIsolate starts in the Running state in contrast to the background > thread LocalIsolates (those start in Parked). > > Code paths in Turbofan that used to create a LocalIsolate on the main > thread can now simply use the main thread LocalIsolate. > > LocalIsolate for the main thread will help in reducing differences > between the main and background threads. The goal is that the main > thread behaves more like a background thread. > > The main thread LocalIsolate should also make it simpler to share code > between main thread and background threads by using LocalIsolate for > both. > > Bug: v8:10315 > Change-Id: I7fd61d305a6fd7079e2319d75c291c1021e70018 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509593 > Reviewed-by: Simon Zünd <szuend@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71226} Bug: v8:10315 Change-Id: I418b1217aeac4f3c44a0aa514dea9864f8a58656 TBR: szuend@chromium.org, yangguo@chromium.org, ulan@chromium.org, leszeks@chromium.org, neis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543399Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a3c2a5d..26db078 Rolling v8/third_party/aemu-linux-x64: ZJSAA8Pwi2mDf7nU7eRK7e3lmUHyrNUgCmzdRwsMbnMC..C3a5C0JPR3a0eNVs8zflK6G9ym7N3f47xoQOm1lQe-gC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/80f68fb..6e44bd8 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/868f530..5589652 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/1b039cb..2d30d87 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib51eed2e7067c3697c04bf63abb8114873943c34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2548127Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#71273}
-
Zhi An Ng authored
Move the simd post mvp flag check into caller, instead of only checking in the default case. This allows us to check *all* opcodes to see if they are post-mvp or not. Before this change, we missed the check for load and store lanes. Bug: v8:10975,chromium:1149078 Change-Id: Id3cff8169ef5137f54a49d28291698139116e8a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543170Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71272}
-
- 18 Nov, 2020 27 commits
-
-
Milad Fa authored
Change-Id: I2f6e76d93309f44f90a24c2ce93f324b44a8fc6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2544921Reviewed-by:
-
Maya Lekova authored
This is a temporary workaround until the root cause is fixed. Bug: v8:11178 TBR=jgruber@chromium.org Change-Id: I04ffaa83b88bca3d0db8079c1e798986e6bfcb62 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2547294Reviewed-by:
-
Camillo Bruni authored
- introduce view specific helper.mjs module - clean up some imports Bug: v8:10644 Change-Id: I0497c1a962c90f61f2beca667aca4a3f53a11e59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2545705Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71269}
-
Jakob Kummerow authored
Mac-arm64 devices always have support for it. Found by thakis@chromium.org Change-Id: Id2dd9d53b66715efe8b4f7f0019d1ba06289c359 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2547281Reviewed-by:
-
Frank Tang authored
Bug: v8:9613, v8:10447 Change-Id: Iff43b298c6edaa9b258038ae15406d5df209e8b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543266 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Emrich authored
AddToDictionaryTemplate in literal-objects.cc was missing several cases when handling the overwriting between properties with statically known and dynamically computed names. This led to wrong enumeration orders in class prototypes created from class templates. Bug: v8:11158 Change-Id: I7381b4680ec533bd307a6c32d75c8a66394869df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536464 Commit-Queue: Frank Emrich <emrich@google.com> Reviewed-by:
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/0e7319c0..36d2d2d34 Bug: v8:7834 Change-Id: If35f50920cddaad0dd8e12029d153c1e2f478aeb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2545572Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#71265}
-
Jakob Gruber authored
Megamorphic load builtins are a performance optimization when current feedback is megamorphic. We can't make this assumption for shared NCI code though, since feedback in other native contexts may *not* be megamorphic, and we'd thus miss out on necessary feedback collection. Bug: v8:8888 Change-Id: I2adc5ef9a6b021b35cf26f975c79228d556bf94f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546694 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#71264}
-
Jakob Gruber authored
... to --turbo-dynamic-map-checks. With the upcoming use in NCI code, this feature is no longer used exclusively by Turboprop. Bug: v8:8888 Change-Id: I61e01db086fd2e8566d2e2a09574be74b6e5a7bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546693 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Bug: v8:11166 Change-Id: I39d2b7e926d9954c25dec149a741c24d6a0e7353 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2545707 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Andreas Haas authored
There is a flag in the WebAssembly trap handler that is set whenever WebAssembly code is entered, and that is reset when WebAssembly code is left. In runtime functions we have DCHECKs in place that check the value of this flag. This flag is only needed when trap handlers are enabled though. When trap handlers are disabled, the flag is not enabled and disabled consistently. DCHECKs should therefore only check the flag value when trap handlers are actually enabled. R=manoskouk@chromium.org CC=vkont@google.com Bug: v8:10982 Change-Id: I3325f6057ff8d9c39d029ef04c55792162d927f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2545708Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#71261}
-
Andreas Haas authored
This CL implements the spec change done in https://github.com/WebAssembly/reference-types/pull/116. R=manoskouk@chromium.org Bug: v8:10994 Change-Id: Ic2b4e0a52af225b5640447fe051a9c36e6d41be2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534818 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This has similar performance as the thread_id check. It removes the need to get the isolate for this check though, so it's a net positive. Bug: v8:7790 Change-Id: I329bb9d5fe695fb9ef4990ba3593703b1eedca0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546690Reviewed-by:
-
Patrick Thier authored
Some tests explicitly set the --always-opt flag, but they are not ignored when the testrunner is invoked with variant="jitless" or variant="nooptimization". This CL implies --opt from --always-opt and excludes --always-opt when the testrunner is invoked with jitless or nooptimization variants. Change-Id: I49ebc3907666c462aa09a294a39a504a0c90de96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2544548Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#71258}
-
Dominik Inführ authored
AssembleCode used CcTest::i_isolate() to load the isolate, however this might not be the isolate that should be used. Therefore take the isolate as an explicit argument. Note that this changes behavior of ExecuteMemoryAccess in test-sync-primitives-arm.cc. I think this test inadvertently created the assembly code in the isolate of another thread, while it didn't use the isolate it sets the handle scope up for. This change is required for relanding https://crrev.com/c/2543399. Bug: v8:10315 Change-Id: I754f4b45cec93727309fa73723011afe976f3689 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546682Reviewed-by:
-
Santiago Aboy Solanes authored
Pointer compression is not supported in arm32 and we will not encounter those MachineRepresentations. Bug: v8:7703 Change-Id: I72c94d57b27710bdca54d649755a91e869b4947e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546686 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This CL fixes a spot (pointed out by Mythri) in which it was possible to start running unoptimized bytecode even if cached NCI code was present. Previously, the CompileLazy builtin would skip the runtime and start running bytecode immediately if the SharedFunctionInfo was already compiled; any NCI code was ignored. This CL changes the CompileLazy builtin to additionally check the SFI::may_have_cached_code bit. If set, call into the (new) function Runtime::kTryInstallNCICode to try and install NCI code. Bug: v8:8888 Change-Id: Icbee9f0780f9b65e9339f1a958f5b28abe42c810 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546680Reviewed-by:
-
Maya Lekova authored
This CL introduces a new fast_api_call_target field on the isolate, which is set by Turbofan before making the fast call. It then uses the field when creating a stack sample and stores it in the existing external_callback_entry used for regular API callbacks. The CL also adds a cctest with simple usage scenario and introduces a minor refactoring in test-api.cc. Design doc: https://docs.google.com/document/d/1r32qlPzGz0P7nieisJ5h2qfSnWOs40Cigt0LXPipejE/edit Bug: chromium:1052746 Change-Id: I2dab1bc395ccab0c14088f7c354fb52b08df8d32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2488683 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This removes the dependency on Lua for running gcmole, and Python's expressiveness lets us clean up the code a bit, including getting rid of global variables, embedding the multiprocessing (removing the need for a separate `parallel.py`), and using difflib for printing the test expectation diff. Bug: v8:11169, v8:8590, chromium:1097212 Change-Id: If0ab5ea6f764864855d73cd0ba63cb37c1823955 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543927 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Remove more deprecated APIs after upgrading uses in chrome. Bug: v8:11165, v8:10641, v8:8124, chromium:1096017 Change-Id: If0379806d73c2dbc877f09603b15a5a68dc75d36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543926Reviewed-by:
-
Nico Hartmann authored
NOTRY=true TBR=szuend@chromium.org Bug: v8:11176 Change-Id: If10560a5c36e22ef0cd9f3c7344b4dc30d3bcf02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546687Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#71251}
-
Georg Neis authored
Bug: v8:10927 Change-Id: I37d3b591ceedeec0239fcec66d41bcf26f8503bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546683 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: Ifd47a3256ec23d2c62ff7bbaf4de226fdfd3f68d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546123Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71249}
-
Jakob Gruber authored
To be unskipped once root cause is fixed. Bug: v8:11166 Change-Id: I03c3ac9a7e715fce7683d230965bd92a410c8f91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546681 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c854b81..a3c2a5d Rolling v8/third_party/aemu-linux-x64: FwzgY9X10eGIOA-l6ukRroKmBYo1As7yOiPDRfc6PxAC..ZJSAA8Pwi2mDf7nU7eRK7e3lmUHyrNUgCmzdRwsMbnMC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f92a763..80f68fb Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d4e6fb6..868f530 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c72342c..1b039cb TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic47da443ac8cd3b2ce6a83e3d80a54df8df7db8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546167Reviewed-by:
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: I71fabf7628ec13440585c24381f5ba89e4df03d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543168Reviewed-by:
-
Zhi An Ng authored
These are prototype instructions, and were missing validation checks for lane immediates. Bug: chromium:1149040 Change-Id: I22537061e26980a1aa0b3944839ab947e5351d9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543164Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71245}
-
- 17 Nov, 2020 1 commit
-
-
Frank Tang authored
This is a reland of 915f729a Original change's description: > Add regression tests for 4 calendar bugs > > These bugs was fixed by ICU68 > > Bug: v8:10526, v8:10527, v8:10528, v8:10529 > Change-Id: I8d0dcb52d849f742e0a29314ac8a148370f60a1a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527086 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71062} Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng Bug: v8:10526 Bug: v8:10527 Bug: v8:10528 Bug: v8:10529 Change-Id: I8857fb8c104bb4bede8fe816574bfd46ccbcd082 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536737 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
