[compiler] Rename --turboprop-dynamic-map-checks

... to --turbo-dynamic-map-checks. With the upcoming use in NCI code,
this feature is no longer used exclusively by Turboprop.

Bug: v8:8888
Change-Id: I61e01db086fd2e8566d2e2a09574be74b6e5a7bd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546693
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71263}

src/compiler/js-heap-broker.cc

@@ -4665,8 +4665,7 @@ void FilterRelevantReceiverMaps(Isolate* isolate, MapHandles* maps) {
 MaybeObjectHandle TryGetMinimorphicHandler(
     std::vector<MapAndHandler> const& maps_and_handlers, FeedbackSlotKind kind,
     Handle<NativeContext> native_context, bool is_turboprop) {
-  if (!is_turboprop || !FLAG_turboprop_dynamic_map_checks ||
-      !IsLoadICKind(kind)) {
+  if (!is_turboprop || !FLAG_turbo_dynamic_map_checks || !IsLoadICKind(kind)) {
     return MaybeObjectHandle();
   }
 

src/flags/flag-definitions.h

@@ -551,9 +551,6 @@ DEFINE_BOOL(trace_generalization, false, "trace map generalization")
 DEFINE_BOOL(turboprop, false, "enable experimental turboprop mid-tier compiler")
 DEFINE_BOOL(turboprop_mid_tier_reg_alloc, true,
             "enable mid-tier register allocator for turboprop")
-DEFINE_BOOL(turboprop_dynamic_map_checks, true,
-            "use dynamic map checks when generating code for property accesses "
-            "if all handlers in an IC are the same for turboprop")
 DEFINE_BOOL(turboprop_as_midtier, false,
             "enable experimental turboprop mid-tier compiler")
 DEFINE_IMPLICATION(turboprop_as_midtier, turboprop)
@@ -733,6 +730,9 @@ DEFINE_BOOL(
 DEFINE_BOOL(turbo_fast_api_calls, false, "enable fast API calls from TurboFan")
 DEFINE_INT(reuse_opt_code_count, 0,
            "don't discard optimized code for the specified number of deopts.")
+DEFINE_BOOL(turbo_dynamic_map_checks, true,
+            "use dynamic map checks when generating code for property accesses "
+            "if all handlers in an IC are the same for turboprop and NCI")
 
 // Native context independent (NCI) code.
 DEFINE_BOOL(turbo_nci, false,

src/runtime/runtime-test.cc

@@ -254,7 +254,7 @@ RUNTIME_FUNCTION(Runtime_IsConcurrentRecompilationSupported) {
 RUNTIME_FUNCTION(Runtime_DynamicMapChecksEnabled) {
   SealHandleScope shs(isolate);
   DCHECK_EQ(0, args.length());
-  return isolate->heap()->ToBoolean(FLAG_turboprop_dynamic_map_checks);
+  return isolate->heap()->ToBoolean(FLAG_turbo_dynamic_map_checks);
 }
 
 RUNTIME_FUNCTION(Runtime_OptimizeFunctionOnNextCall) {

test/cctest/heap/test-heap.cc

@@ -1251,7 +1251,7 @@ UNINITIALIZED_TEST(Regress10843) {
 TEST(Regress10774) {
   i::FLAG_allow_natives_syntax = true;
   i::FLAG_turboprop = true;
-  i::FLAG_turboprop_dynamic_map_checks = true;
+  i::FLAG_turbo_dynamic_map_checks = true;
 #ifdef VERIFY_HEAP
   i::FLAG_verify_heap = true;
 #endif

test/mjsunit/compiler/test-dynamic-map-check-deprecated-maps-polymorphic.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --turboprop --turboprop-dynamic-map-checks --opt
+// Flags: --allow-natives-syntax --turboprop --turbo-dynamic-map-checks --opt
 // Flags: --no-always-opt
 
 function f(o) {

test/mjsunit/compiler/test-dynamic-map-check-deprecated-maps.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --turboprop --turboprop-dynamic-map-checks --opt
+// Flags: --allow-natives-syntax --turboprop --turbo-dynamic-map-checks --opt
 // Flags: --no-always-opt
 
 function f(o) {

test/mjsunit/compiler/test-dynamic-map-check-deprecated-maps2.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --turboprop --turboprop-dynamic-map-checks
+// Flags: --allow-natives-syntax --turboprop --turbo-dynamic-map-checks
 // Flags: --opt --no-always-opt --deopt-every-n-times=0
 
 function b(a) { return a; }

test/mjsunit/compiler/test-dynamic-map-checks-poly-mono.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --turboprop --turboprop-dynamic-map-checks --opt
+// Flags: --allow-natives-syntax --turboprop --turbo-dynamic-map-checks --opt
 // Flags: --no-always-opt
 
 function load(obj){

test/mjsunit/compiler/test-dynamic-map-checks-wrong-handler.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --turboprop --turboprop-dynamic-map-checks --opt
+// Flags: --allow-natives-syntax --turboprop --turbo-dynamic-map-checks --opt
 // Flags: --no-always-opt
 
 function load(obj){

test/mjsunit/compiler/test-dynamic-map-checks-wrong-handler1.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --turboprop --turboprop-dynamic-map-checks --opt
+// Flags: --allow-natives-syntax --turboprop --turbo-dynamic-map-checks --opt
 // Flags: --no-always-opt
 
 function load(obj){

test/mjsunit/compiler/test-dynamic-map-checks.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --turboprop --turboprop-dynamic-map-checks --opt
+// Flags: --allow-natives-syntax --turboprop --turbo-dynamic-map-checks --opt
 // Flags: --no-always-opt
 
 function load(obj){

test/mjsunit/es6/super-ic-opt-dynamic-map-checks.js

@@ -4,7 +4,7 @@
 
 // Flags: --allow-natives-syntax --super-ic --opt
 // Flags: --no-always-opt --no-stress-opt --turboprop
-// Flags: --turboprop-dynamic-map-checks --deopt-every-n-times=0
+// Flags: --turbo-dynamic-map-checks --deopt-every-n-times=0
 
 // This file contains tests which require --dynamic-map-chekcs.
 

test/mjsunit/regress/regress-1112155.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
-// Flags: --turboprop-dynamic-map-checks --allow-natives-syntax --opt --no-always-opt
+// Flags: --turbo-dynamic-map-checks --allow-natives-syntax --opt --no-always-opt
 
 function f(v) {
   return v.b;

test/mjsunit/regress/regress-1125871.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --turboprop-dynamic-map-checks --opt --no-always-opt
+// Flags: --allow-natives-syntax --turbo-dynamic-map-checks --opt --no-always-opt
 
 function bar(obj) {
   // Add two dummy loads to make sure obj.b is in the same slot index as obj.a

test/mjsunit/regress/regress-1141502.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax --no-lazy-feedback-allocation
-// Flags: --turboprop-dynamic-map-checks
+// Flags: --turbo-dynamic-map-checks
 
 function bar(a) {
   return a.x;