• Andreas Haas's avatar
    [wasm] Fix trap handler DCHECK in IsValidRefValue · 1bd9b66c
    Andreas Haas authored
    There is a flag in the WebAssembly trap handler that is set whenever
    WebAssembly code is entered, and that is reset when WebAssembly code is
    left. In runtime functions we have DCHECKs in place that check the
    value of this flag.
    
    This flag is only needed when trap handlers are enabled though. When
    trap handlers are disabled, the flag is not enabled and disabled
    consistently. DCHECKs should therefore only check the flag value when
    trap handlers are actually enabled.
    
    R=manoskouk@chromium.org
    CC=vkont@google.com
    
    Bug: v8:10982
    Change-Id: I3325f6057ff8d9c39d029ef04c55792162d927f6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2545708Reviewed-by: 's avatarManos Koukoutos <manoskouk@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71261}
    1bd9b66c
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...