• Jakob Gruber's avatar
    [nci] Check for NCI code in the CompileLazy builtin · 49ec5c4c
    Jakob Gruber authored
    This CL fixes a spot (pointed out by Mythri) in which it was possible
    to start running unoptimized bytecode even if cached NCI code was
    present.
    
    Previously, the CompileLazy builtin would skip the runtime and start
    running bytecode immediately if the SharedFunctionInfo was already
    compiled; any NCI code was ignored.
    
    This CL changes the CompileLazy builtin to additionally check the
    SFI::may_have_cached_code bit. If set, call into the (new) function
    Runtime::kTryInstallNCICode to try and install NCI code.
    
    Bug: v8:8888
    Change-Id: Icbee9f0780f9b65e9339f1a958f5b28abe42c810
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546680Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71255}
    49ec5c4c
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...