- 23 Sep, 2020 11 commits
-
-
Michael Achenbach authored
No-Try: true Bug: v8:10952 Change-Id: Iee858419b160a354a4df61f51b18782fcbc4a521 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424155 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#70089}
-
Leszek Swirski authored
We currently have a pattern of setting a dereferenced Handle location to update that Handle's value: *handle.location() = new_value.ptr() This is slightly opaque, and definitely not type-safe, so add a new Handle<T>::PatchValue method which does this operation. Ideally we would make Handle::location() return a const pointer to discourage this sort of use, but there's a bunch of places where that location pointer is used and passed around as a Handle surrogate, so those would have to be updated first. Change-Id: I157f7e2473ed1b86f7a93cae260b0932fed0ad88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424249 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#70088}
-
Zhao Jiazhong authored
Currently the kWasmInstanceOffset is computed according to the reg a0(kWasmInstanceRegister)'s position in the frame. And according to Builtins::Generate_WasmCompileLazy, it's the 7th gp_regs that are pushed on to stack, so the index should be 6 other than 7. Since the kWasmInstanceRegister will be pushed on to stack after all parameter registers, so we can use it's index, which does not reply on which reg kWasmInstanceRegister is, and what order the parameter registers are pushed on to stack. So the new index is equal to the number of all parameter registers. Change-Id: I7a77fb052a5d68ee28dab10409462260ad491578 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2425329 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70087}
-
Thibaud Michaud authored
For invalid modules, the {kFinishedExportWrappers} event and the validation error can happen in any order. Make the order deterministic for predictable mode. R=clemensb@chromium.org Bug: v8:10936 Change-Id: Ib5b1e5a1a3af901a81bc37919b5aff4e5c237579 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424134Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#70086}
-
Dominik Inführ authored
Not needed for correctness but this avoids adding the pending object to the on_hold worklist. Bug: v8:10315 Change-Id: Ide910cee37a4069c71c4046c32fa9f663265775e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424137Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#70085}
-
Omer Katz authored
ProcessWorklistsWithDeadline now takes deadlines instead of durations. Bug: chromium:1131203 Change-Id: Ie346334cfb043567836262614958282de078a1dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424129 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#70084}
-
Camillo Bruni authored
Bug: chromium:1129854, v8:10937 Change-Id: I0a9fd3e16a6ae8ea47a7a3f0a9325542d9e46014 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424133Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70083}
-
Martin Bidlingmaier authored
The m (multiline) and s (dotall) flags just needed to be marked as allowed; the required logic was already in the regexp parser. A regexp /<x>/ without the y (sticky) flag is equivalent to the sticky regexp /.*?<x>/y. The interpreter now assumes that every regexp is sticky, and the compiler appends a preamble corresponding to /.*?/ before non-sticky regexps. To reuse existing code for compiling this preamble, the logic for each kind of quantifier is now in a separate function and called from VisitQuantifier and for the preamble. The commit also includes some improvements/fixes for character ranges: - Empty character ranges/disjunctions should never match, but before this commit they would *always* match. - The check of the range bounds in CanBeHandledVisitor was unncessary; without the unicode flag this can't be a range that can't be specified in 2-byte codepoints, and once we support unicode we simply support all codepoints. - The capacity of the list containing the complementary intervals of a character range is now calculated more accurately. Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Bug: v8:10765 Change-Id: I71a0e07279b4e1140c0ed1651b3714200c801de9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404766 Commit-Queue: Martin Bidlingmaier <mbid@google.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#70082}
-
Manos Koukoutos authored
This fixes a bug caused by StartFunction() being called for an invalid module. Bug: v8:7748 Change-Id: I47a3f3573355d87554b123dd1edc7c829bb43d0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423710 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#70081}
-
Camillo Bruni authored
This is a reland of 66e4c99c Move recursive check variable onto PerIsolateData to avoid data races. Original change's description: > [d8] Avoid recursive unhandled rejected Promise processing > > Bug: chromium:1126309 > Change-Id: I9d9d33cd151ed8af5ee8af09b8957eae9df2dcb1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2410059 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Auto-Submit: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69986} Bug: chromium:1126309 Change-Id: I83353e891e8987fa6f828e1efd82968b895638b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423708Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70080}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e78873c..c8dc0f5 Rolling v8/third_party/aemu-linux-x64: zVhDYckO5pABaht9PlF8y1S_JicWTnMzwymJyNabQj4C..laU2vAii09mMfCaTLtA8O6UYjPdUXy0B-0zzOR0OPekC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cc29098..d1580d5 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/79326ef..83b2ac6 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/7c1d1f3..3017eda TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0913fb10fb814a52442b6a942406f2d597635ca3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2425526Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#70079}
-
- 22 Sep, 2020 29 commits
-
-
Ng Zhi An authored
This reverts commit 2bc09b89. Reason for revert: Skip some tests on ARM devices for now Original change's description: > Revert "[wasm-simd][scalar-lowering] Enable some spec tests" > > This reverts commit cfe9544a. > > Reason for revert: Some spec tests fail: > https://ci.chromium.org/p/v8/builders/ci/V8%20Arm%20-%20debug/15933 > > Original change's description: > > [wasm-simd][scalar-lowering] Enable some spec tests > > > > These tests can now be enabled as we implemented more scalar lowering > > support. > > > > Bug: v8:10507 > > Change-Id: Ida5f896300e074db079ec24720302729b0582d9d > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2411774 > > Reviewed-by: Bill Budge <bbudge@chromium.org> > > Commit-Queue: Zhi An Ng <zhin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#70006} > > TBR=bbudge@chromium.org,zhin@chromium.org > > Change-Id: Idb2da40178860f045ffab9ab5b2c8b1f2ebafcf6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:10507 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2419036 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70010} TBR=bbudge@chromium.org,zhin@chromium.org # Not skipping CQ checks because this is a reland. Bug: v8:10507 Change-Id: Ifaf15c49ece65cfeaef83b0ace6cfbb804e93a4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2419039Reviewed-by: Zhi An Ng <zhin@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70078}
-
Ng Zhi An authored
Rename opcodes based on the renaming in the proposal, https://github.com/WebAssembly/simd/pull/322. Bug: v8:10946 Change-Id: If267d6f8fb1b9deeff64cd9abcd7e4cd64a540a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2422357 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#70077}
-
Camillo Bruni authored
This is a reland of 21bb43cc The build failures seems to be an infra flake. Original change's description: > [log][d8] Only use d8.log.getAndStop on temporary log file > > We run tests in parallel which can cause multiple tests to write to > the shared v8.log file. This obviously breaks the simple assertions in > mjsunit/tools/log.js. > > - Use temporary files for log testing with --logfile='+' > > - Change the symbol from '&' to '+' for using temporary files for > logging with --logfile > > - Enable skipped log tests again. > > Bug: v8:10937, chromium:1129854, chromium:1130196 > Change-Id: I607dc9a9ecc352e58525cdd21c1c93efebf0f09f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421826 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70071} Bug: v8:10937 Bug: chromium:1129854 Bug: chromium:1130196 Change-Id: I2ccf7528f35057ef668aa211142e0f1073fc1fc3 Tbr: verwaest@chromium.org, victorgomes@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424257Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70076}
-
Francis McCabe authored
This reverts commit 54b141ef. Reason for revert: closed tree due to: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20noi18n%20-%20debug/33838? Original change's description: > [wasm][ukm] Add tests for Wasm events (reland) > > Ensure that events are triggered when a module is decoded, compiled, > instantiated and tiered-up. > > This is a reland of I9dc87957fc03023c5ab1c4f49e865957c8324e1a. > > R=clemensb@chromium.org > > Bug: chromium:1092417 > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng > Change-Id: Ib5883a338c3756c6f3488fbdd7b6861ecc2ba218 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2367866 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70074} TBR=adamk@chromium.org,clemensb@chromium.org,ecmziegler@chromium.org Change-Id: I859c69bacfca9c790ed274140bb9e8d23de26729 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1092417 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2425104Reviewed-by: Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#70075}
-
Emanuel Ziegler authored
Ensure that events are triggered when a module is decoded, compiled, instantiated and tiered-up. This is a reland of I9dc87957fc03023c5ab1c4f49e865957c8324e1a. R=clemensb@chromium.org Bug: chromium:1092417 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Change-Id: Ib5883a338c3756c6f3488fbdd7b6861ecc2ba218 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2367866Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#70074}
-
Frank Tang authored
Bug: chromium:1130489 Change-Id: I506f2ea418bf3bde9468126534df9d78337e5f82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2422086Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#70073}
-
Francis McCabe authored
This reverts commit 21bb43cc. Reason for revert: See broken build: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20builder/49882 Original change's description: > [log][d8] Only use d8.log.getAndStop on temporary log file > > We run tests in parallel which can cause multiple tests to write to > the shared v8.log file. This obviously breaks the simple assertions in > mjsunit/tools/log.js. > > - Use temporary files for log testing with --logfile='+' > > - Change the symbol from '&' to '+' for using temporary files for > logging with --logfile > > - Enable skipped log tests again. > > Bug: v8:10937, chromium:1129854, chromium:1130196 > Change-Id: I607dc9a9ecc352e58525cdd21c1c93efebf0f09f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421826 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70071} TBR=cbruni@chromium.org,verwaest@chromium.org,victorgomes@chromium.org Change-Id: I5de61792c283139b2a898334e28e1f7b2d7c08f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10937 Bug: chromium:1129854 Bug: chromium:1130196 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424625Reviewed-by: Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#70072}
-
Camillo Bruni authored
We run tests in parallel which can cause multiple tests to write to the shared v8.log file. This obviously breaks the simple assertions in mjsunit/tools/log.js. - Use temporary files for log testing with --logfile='+' - Change the symbol from '&' to '+' for using temporary files for logging with --logfile - Enable skipped log tests again. Bug: v8:10937, chromium:1129854, chromium:1130196 Change-Id: I607dc9a9ecc352e58525cdd21c1c93efebf0f09f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421826 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#70071}
-
Vicky Kontoura authored
This CL extends fast-path transformations of JavaScript parameters when calling an exported WebAssembly function from JavaScript to support types kF32 and kF64. Bug: v8:10943 Change-Id: I730a04c426614460777cad7c6552533868cd902e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424263Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Vicky Kontoura <vkont@google.com> Cr-Commit-Position: refs/heads/master@{#70070}
-
Ng Zhi An authored
Load and zero extend is still in prototype phase [0], implementing for ARM64 in order to get more benchmark results. [0] https://github.com/WebAssembly/simd/pull/237 Bug: v8:10713 Change-Id: I7d632324e4bdb0934ab024911201a06b19a1a83d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2416407 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#70069}
-
Michael Achenbach authored
No-Try: true Bug: chromium:1126457 Change-Id: I3c293afb191a269c5b25d43d68f5f92d93afb410 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424270 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#70068}
-
Michael Achenbach authored
No-Try: true Bug: chromium:1126467 Change-Id: Ib8c6bea1397ef27ae9ccff3891194ec5999c4cb7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424269 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#70067}
-
Milad Fa authored
Change-Id: I0a3ac5e56504c7c99f94a29f30c3827e99718b7d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423615Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#70066}
-
Francis McCabe authored
This reverts commit 64caf2b0. Reason for revert: Seems to be causing a failure: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/38809? Original change's description: > [torque] refactor: use -tq only in filenames derived from .tq files > > This is to establish a naming rule for Torque-generated files: > - If the file is called foo/bar-tq..., then it is derived from a > file foo/bar.tq > - Otherwise it doesn't belong to a specific .tq file. > > So far, we attached -tq to all Torque-generated file names, where it > sometimes corresponded to a .tq file name and sometimes not. > It is not necessary to add -tq to file names to indicate that they are > Torque-generated, since they are already in a directory called > torque-generated, and we always refer to them as > "torque-generated/filename", so there is no confusion even though some > files now have the same name as a corresponding hand-written file, for > example factory.cc. > > TBR: hpayer@chromium.org > Bug: v8:7793 > Change-Id: Ie172babad1fc7422fd1059c48f5dafaa53e50c8b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414218 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70060} TBR=jgruber@chromium.org,tebbi@chromium.org Change-Id: I6960fe540861947536c6ddfc0f4887ea80899fae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7793 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424486Reviewed-by: Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#70065}
-
Z Nguyen-Huu authored
Using associative property of addition: (x + A) + B => x + (A + B). Note: A and B need to have the same sign and we need to check that (x + A) isn't used anywhere else. 20% perf improvement of the following function. function f(n) { var c = 0; for (var i = 0; i < n; i++) { c = c + 2 + 3; } return c; } for n = 10_000_000. Before: 7.31s. After: 6.05s. Bug: v8:10305 Change-Id: If45d1cad6128a9a25cb9f43a4828ae28d594a84b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2365221 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#70064}
-
Ng Zhi An authored
We are hitting some limits in number of opcodes on ARM64. Try to reduce it by merging AnyTrue opcodes (from 4 to 1) since the codegen is identical. Bug: v8:10930 Change-Id: Ib0bcedbd24d122a4da1ffcb29c1e4b5656fa6ac2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2422087Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70063}
-
Shu-yu Guo authored
The detach CHECK is currently crashing on a non-TypedArray and non-Array input source to TypedArray#set that detaches the destination TypedArray in its length getter. Bug: v8:10885 Change-Id: I80bcb4ffb4e4122afbff5c412623c008dc9509df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2419655Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#70062}
-
Ng Zhi An authored
Strange things happen if we add too many opcodes such that we exceed the number of bits ArchOpcodeField has, and in some arch (ARM64), we are only one away from requiring 10 bits (at 0x1ff) now. Bug: v8:10930 Change-Id: I8dc6b7e0822291f2403db4e4e1dfaf90b9416a8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2422843 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#70061}
-
Tobias Tebbi authored
This is to establish a naming rule for Torque-generated files: - If the file is called foo/bar-tq..., then it is derived from a file foo/bar.tq - Otherwise it doesn't belong to a specific .tq file. So far, we attached -tq to all Torque-generated file names, where it sometimes corresponded to a .tq file name and sometimes not. It is not necessary to add -tq to file names to indicate that they are Torque-generated, since they are already in a directory called torque-generated, and we always refer to them as "torque-generated/filename", so there is no confusion even though some files now have the same name as a corresponding hand-written file, for example factory.cc. TBR: hpayer@chromium.org Bug: v8:7793 Change-Id: Ie172babad1fc7422fd1059c48f5dafaa53e50c8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414218 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#70060}
-
Dominik Inführ authored
It is not allowed to invoke ResetPendingObject() in MarkCompactCollector::StartMarking(). This method is invoked when starting incremental marking, at this point the object might not be initialized. Bug: v8:10315 Change-Id: I7659855d78fbb28536f57b26e8a7d33c1ba4092e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424267Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#70059}
-
Dominik Inführ authored
Avoid race with concurrent allocation thread by updating the flag conditionally. Bug: v8:10315 Change-Id: I63df8ab5a6a506e9337281c9fef7555b9deaaee6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424264Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#70058}
-
Leszek Swirski authored
Also remove yangguo@ at his behest. Change-Id: Ief4176663ab01ff7b1d75aa8d6907c96ab519310 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421822Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#70057}
-
Andreas Haas authored
The tests are flaky because of missing safepoint information for stack checks. Adding the safepoint information there is not trivial though, so I disable these tests for now to keep at least the bots green. An alternative would be to revert the CLs that add safepoints in the first place. However, I would prefer to avoid the overhead that would be caused by it. The implementation is completely hidden behind a flag, so it does not have impact on production code. R=clemensb@chromium.org Bug: v8:10929 Change-Id: I38c0e3c3806de2cc39ba26bc3b47c2ea8d1cf81a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423705Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#70056}
-
Tobias Tebbi authored
Bug: v8:10577 Change-Id: I28aaec30b73def5034294f71bb6bda466172b4ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2400978 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#70055}
-
Dominik Inführ authored
Otherwise concurrent allocation might start incremental marking, which would then mark the global handle. Bug: v8:10315 Change-Id: Ibc681b001847a7c52e9fd8a0420e42a0d0ecfbda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424004Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#70054}
-
Cong Zuo authored
Change-Id: I257cd745966cbd9ee87eb725b3f80fbf5bf40ca3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423743Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#70053}
-
Clemens Backes authored
This flag has no uses in any tests, and it's hard to image a use case for debugging or similar. R=ahaas@chromium.org Bug: v8:10933 Change-Id: I2e96187e4410805824d213e9a9df152b54dd3fb2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421825Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70052}
-
Michael Achenbach authored
No-Try: true Bug: chromium:1126457 Change-Id: Iea2f8f37b172fb130c13b0f1d397eb5789c82893 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423720 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#70051}
-
Vicky Kontoura authored
This CL improves the condition that checks all parameters received from JavaScript when calling an exported WebAssembly function to determine whether they can be transformed without calls to built-in functions. The condition is now updated to stop checking if one parameter that cannot be transformed quickly is encountered. Bug: v8:10943 Change-Id: If199aa8d2ffcef86f973c23d9663f8091dfced8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423713Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Vicky Kontoura <vkont@google.com> Cr-Commit-Position: refs/heads/master@{#70050}
-