• Martin Bidlingmaier's avatar
    [regexp] Support the msy flags in experimental engine · e6e9cbac
    Martin Bidlingmaier authored
    The m (multiline) and s (dotall) flags just needed to be marked as
    allowed; the required logic was already in the regexp parser.
    
    A regexp /<x>/ without the y (sticky) flag is equivalent to the sticky
    regexp /.*?<x>/y.  The interpreter now assumes that every regexp is
    sticky, and the compiler appends a preamble corresponding to /.*?/
    before non-sticky regexps.  To reuse existing code for compiling this
    preamble, the logic for each kind of quantifier is now in a separate
    function and called from VisitQuantifier and for the preamble.
    
    The commit also includes some improvements/fixes for character ranges:
    - Empty character ranges/disjunctions should never match, but before
      this commit they would *always* match.
    - The check of the range bounds in CanBeHandledVisitor was unncessary;
      without the unicode flag this can't be a range that can't be specified
      in 2-byte codepoints, and once we support unicode we simply support
      all codepoints.
    - The capacity of the list containing the complementary intervals of a
      character range is now calculated more accurately.
    
    Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng
    Bug: v8:10765
    Change-Id: I71a0e07279b4e1140c0ed1651b3714200c801de9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404766
    Commit-Queue: Martin Bidlingmaier <mbid@google.com>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70082}
    e6e9cbac
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...