Reland "[d8] Avoid recursive unhandled rejected Promise processing"

This is a reland of 66e4c99c

Move recursive check variable onto PerIsolateData to avoid data races.

Original change's description:
> [d8] Avoid recursive unhandled rejected Promise processing
>
> Bug: chromium:1126309
> Change-Id: I9d9d33cd151ed8af5ee8af09b8957eae9df2dcb1
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2410059
> Commit-Queue: Toon Verwaest <verwaest@chromium.org>
> Auto-Submit: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#69986}

Bug: chromium:1126309
Change-Id: I83353e891e8987fa6f828e1efd82968b895638b6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423708Reviewed-by: Marja Hölttä <marja@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70080}

src/d8/d8.cc

@@ -1142,6 +1142,7 @@ PerIsolateData::PerIsolateData(Isolate* isolate)
   if (i::FLAG_expose_async_hooks) {
     async_hooks_wrapper_ = new AsyncHooks(isolate);
   }
+  ignore_unhandled_promises_ = false;
 }
 
 PerIsolateData::~PerIsolateData() {
@@ -1172,6 +1173,7 @@ MaybeLocal<Context> PerIsolateData::GetTimeoutContext() {
 }
 
 void PerIsolateData::RemoveUnhandledPromise(Local<Promise> promise) {
+  if (ignore_unhandled_promises_) return;
   // Remove handled promises from the list
   DCHECK_EQ(promise->GetIsolate(), isolate_);
   for (auto it = unhandled_promises_.begin(); it != unhandled_promises_.end();
@@ -1186,17 +1188,17 @@ void PerIsolateData::RemoveUnhandledPromise(Local<Promise> promise) {
 void PerIsolateData::AddUnhandledPromise(Local<Promise> promise,
                                          Local<Message> message,
                                          Local<Value> exception) {
+  if (ignore_unhandled_promises_) return;
   DCHECK_EQ(promise->GetIsolate(), isolate_);
   unhandled_promises_.emplace_back(v8::Global<v8::Promise>(isolate_, promise),
                                    v8::Global<v8::Message>(isolate_, message),
                                    v8::Global<v8::Value>(isolate_, exception));
 }
 
-size_t PerIsolateData::GetUnhandledPromiseCount() {
-  return unhandled_promises_.size();
-}
-
 int PerIsolateData::HandleUnhandledPromiseRejections() {
+  // Avoid recursive calls to HandleUnhandledPromiseRejections.
+  if (ignore_unhandled_promises_) return 0;
+  ignore_unhandled_promises_ = true;
   v8::HandleScope scope(isolate_);
   // Ignore promises that get added during error reporting.
   size_t i = 0;

src/d8/d8.h

@@ -260,7 +260,6 @@ class PerIsolateData {
   void AddUnhandledPromise(Local<Promise> promise, Local<Message> message,
                            Local<Value> exception);
   int HandleUnhandledPromiseRejections();
-  size_t GetUnhandledPromiseCount();
 
  private:
   friend class Shell;
@@ -273,6 +272,7 @@ class PerIsolateData {
   Global<Value> realm_shared_;
   std::queue<Global<Function>> set_timeout_callbacks_;
   std::queue<Global<Context>> set_timeout_contexts_;
+  bool ignore_unhandled_promises_;
   std::vector<std::tuple<Global<Promise>, Global<Message>, Global<Value>>>
       unhandled_promises_;
   AsyncHooks* async_hooks_wrapper_;

test/message/mjsunit/fail/assert-in-promise-fail-recursive.out

@@ -8,11 +8,4 @@ Error: WebAssembly.compile(): Argument 0 must be a buffer source
     at console.log (<anonymous>)
     at *%(basename)s:12:9
 
-*%(basename)s:9: Error: WebAssembly.compile(): Argument 0 must be a buffer source
-  WebAssembly.compile();
-              ^
-Error: WebAssembly.compile(): Argument 0 must be a buffer source
-    at TypeError.name (*%(basename)s:9:15)
-    at TypeError.toString (<anonymous>)
-
-2 pending unhandled Promise rejection(s) detected.
+1 pending unhandled Promise rejection(s) detected.