• Camillo Bruni's avatar
    Reland "[log][d8] Only use d8.log.getAndStop on temporary log file" · 1724c77c
    Camillo Bruni authored
    This is a reland of 21bb43cc
    
    The build failures seems to be an infra flake.
    
    Original change's description:
    > [log][d8] Only use d8.log.getAndStop on temporary log file
    >
    > We run tests in parallel which can cause multiple tests to write to
    > the shared v8.log file. This obviously breaks the simple assertions in
    > mjsunit/tools/log.js.
    >
    > - Use temporary files for log testing with --logfile='+'
    >
    > - Change the symbol from '&' to '+' for using temporary files for
    >   logging with --logfile
    >
    > - Enable skipped log tests again.
    >
    > Bug: v8:10937, chromium:1129854, chromium:1130196
    > Change-Id: I607dc9a9ecc352e58525cdd21c1c93efebf0f09f
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421826
    > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Reviewed-by: Victor Gomes <victorgomes@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70071}
    
    Bug: v8:10937
    Bug: chromium:1129854
    Bug: chromium:1130196
    Change-Id: I2ccf7528f35057ef668aa211142e0f1073fc1fc3
    Tbr: verwaest@chromium.org, victorgomes@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424257Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70076}
    1724c77c
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...