- 30 Apr, 2021 18 commits
-
-
Clemens Backes authored
cpplint rules change over time, and we change the exact rules we enable for v8. This CL removes NOLINT annotations which are not needed according to the currently enabled rules. R=pthier@chromium.org Bug: v8:11717 Change-Id: Id930a72e938a82e4dd8117cb2d4834d9dfb7e9e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862763Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74306}
-
Nico Hartmann authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/cab90cb..d5bb24e Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/94367a1..8cc6617 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/5dbd89c..5da6005 Rolling v8/buildtools/linux64: git_revision:dba01723a441c358d843a575cb7720d54ddcdf92..git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/f6a8e55..5f51521 Rolling v8/third_party/aemu-linux-x64: KmvDYKZZ-xQz7ZzzSKBh3HrWPpQv89vfFY9mBp6RDq4C..kswh0qF56RoEDBXJbyo1IWPAJ9F7WGAvMHGyWGbpBtUC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ca2c407..bbfed50 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ae1b2b1..0d1afc9 Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/835951a..64cb55e Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/0949050..e8da4da Rolling v8/tools/luci-go: git_revision:a3a1f3a2e925eb44367c62783877c922c9ef7289..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 Rolling v8/tools/luci-go: git_revision:a3a1f3a2e925eb44367c62783877c922c9ef7289..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 Rolling v8/tools/luci-go: git_revision:a3a1f3a2e925eb44367c62783877c922c9ef7289..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id081f2b8d4214852d1bb19eab4df82379db03ba5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862144Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#74305}
-
Vicky Kontoura authored
This CL adds support for oddballs false, true, null and undefined. Bug: v8:11525, v8:11706 Change-Id: I0dc870f05578c0eb9ff06bf2ccd2474e18464566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856843 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74304}
-
Jochen Eisinger authored
Tracking the context is not enough, as we might clear the context to avoid repeatedly reentering the same context. Also fix unittests that relied on the default microtask queue getting automatically processed instead of the one of the current context. Bug: chromium:728583 Change-Id: Ia9a51c513fc7363a518af86cc54c5bda26b5fbe8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859850Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#74303}
-
Clemens Backes authored
cpplint rules change over time, and we change the exact rules we enable for v8. This CL removes NOLINT annotations which are not needed according to the currently enabled rules. R=jkummerow@chromium.org Bug: v8:11717 Change-Id: I29e8dfca88f871b5d6b4c6422d036157021514da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862762Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74302}
-
Benedikt Meurer authored
Previously we'd attach source positions to implicit returns that are generated when leaving an async function with a promise rejection. This was due to the use of `kNoSourcePosition` on the `end_position` in the `ReturnStatement` nodes as indicator to pick the return position from the function literal, instead of really not putting a source position on that specific `Return` bytecode. This CL adds a dedicated marker to `ReturnStatement` to express that the `BytecodeGenerator` should put the return position from the function literal there instead of overloading the meaning of `kNoSourcePosition`. Bug: chromium:901819, chromium:782461 Fixed: chromium:1199919, chromium:1201706 Change-Id: I3647e0c3d711e9c3d6ae44606b70ec92ad82e1cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859945 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#74301}
-
Michael Achenbach authored
This reverts commit e13a744a. Reason for revert: breaks perfetto: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20debug%20-%20perfetto%20-%20builder/12849 Original change's description: > [build] Fix gn check failures in v8/third_party > > This removes the blanket exclusion for third_party but leaves > third_party/icu excluded (which is the same as chrome). > > Most fixed issues are to do with previously removed header files and > missing dependencies. > > Bug: v8:7330 > Change-Id: I7e634e35c0620a1f3db9aba01119921e4f781e3e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856838 > Auto-Submit: Dan Elphick <delphick@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74295} Bug: v8:7330 Change-Id: I05cf897c0aeb6bf87f9889b878358c0d02600081 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862767 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74300}
-
Clemens Backes authored
cpplint rules change over time, and we change the exact rules we enable for v8. This CL removes NOLINT annotations which are not needed according to the currently enabled rules. R=jkummerow@chromium.org Bug: v8:11717 Change-Id: Iaaab7cc1ba8af297cf6f3aafa349bf29b34cd60d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859949 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Clemens Backes authored
cpplint rules change over time, and we change the exact rules we enable for v8. This CL removes NOLINT annotations which are not needed according to the currently enabled rules. R=szuend@chromium.org Bug: v8:11717 Change-Id: Icce08a55509b06bacfc75276a2ae69c59e8b021d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859951Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74298}
-
Clemens Backes authored
cpplint rules change over time, and we change the exact rules we enable for v8. This CL removes NOLINT annotations which are not needed according to the currently enabled rules. R=ahaas@chromium.org Bug: v8:11717 Change-Id: Ica92f4ddc9c351c1c63147cbcf050086ca26cc07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859854 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74297}
-
Clemens Backes authored
cpplint rules change over time, and we change the exact rules we enable for v8. This CL removes NOLINT annotations which are not needed according to the currently enabled rules. R=jkummerow@chromium.org Bug: v8:11717 Change-Id: I5e6261c9a4825f6b58068d57327601723edfa481 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859948Reviewed-by:
-
Dan Elphick authored
This removes the blanket exclusion for third_party but leaves third_party/icu excluded (which is the same as chrome). Most fixed issues are to do with previously removed header files and missing dependencies. Bug: v8:7330 Change-Id: I7e634e35c0620a1f3db9aba01119921e4f781e3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856838 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Map::HasOnlyStablePrototypesWithFastElements and Map::SerializeForElementStore were asking if the prototype was a JSObject but they were doing so with the original map on every loop iteration instead of the current prototype's map. Also, we can change it so that instead of using the underlying data to check if it was a JSObject, but we can get the same information reading the map's instance_type directly. Bug: v8:7790 Change-Id: I314b361e59dd16e101d4fbcfbe558aeffd576cd5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859164 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74294}
-
Clemens Backes authored
cpplint rules change over time, and we change the exact rules we enable for v8. This CL removes NOLINT annotations which are not needed according to the currently enabled rules. R=mlippautz@chromium.org Bug: v8:11717 Change-Id: I05951486c8bbcd06bd4f329793cc483a1ade6833 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859851 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74293}
-
Clemens Backes authored
cpplint rules change over time, and we change the exact rules we enable for v8. This CL removes NOLINT annotations which are not needed according to the currently enabled rules. R=mlippautz@chromium.org Bug: v8:11717 Change-Id: I26602ad8aa509646053ec1bdd79470116b89dc3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859853 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Wenyu Zhao authored
Bug: v8:11641 Change-Id: I3d9efa63ffb2ec7d188c13d0bf24bdc7e8297a28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2861064 Auto-Submit: Wenyu Zhao <wenyu.zhao@anu.edu.au> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74291}
-
Marja Hölttä authored
Bug: chromium:1203122 Change-Id: I80a22bbc1e700cca33e26d6a1cf294a5e9a334eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856538Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74290}
-
Alex Rudenko authored
In https://crrev.com/c/2842128, a concern was raised that using `V8InspectorSession::createCommandLineAPI` directly would not cache the command line API definitions and V8 could expose a higher level API for this use case. This CL exposes `InjectedScript::ContextScope` via V8InspectorSession. If this approach is approved, V8InspectorSession::createCommandLineAPI could be removed. Example usage: https://crrev.com/c/2858964 Bug: chromium:1200705 Change-Id: Ib9fcadcb9bbd75c08f0122b0e4ee61e2874c4f8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857640 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#74289}
-
- 29 Apr, 2021 22 commits
-
-
Junliang Yan authored
Change-Id: I294c465230b1c1b8bdb21e8e42bc419c8528d217 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2860742Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#74288}
-
Jakob Kummerow authored
By (mostly) unifying the different kinds of WasmFunctionData, and precomputing and caching what we can, we can reduce the amount of work that has to be done for each call. We still have to store the current instance for JS function calls; that may be eliminatable in the future. WasmCapiFunctions are not included in the refactoring yet. Bug: v8:7748,v8:9495 Change-Id: Ie6839153153d5854670cd01bc77a86111c1f68d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856543 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Vicky Kontoura authored
This is a reland of 7dcc70b8 Original change's description: > [web snapshot] Support numbers > > This CL adds support for integer and double values in web snapshots. > > Bug: v8:11525, v8:11706 > Change-Id: Ib75c52d440cd51bf78f57eecca09cecf35b801a4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854734 > Commit-Queue: Vicky Kontoura <vkont@google.com> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74259} Bug: v8:11525 Bug: v8:11706 Change-Id: Ia5912ab22db24559c6d0f028a8e744ec448e2250 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859942Reviewed-by:
-
Sam Parker authored
Modify TryAnyExtendMatch to combine Int64Add/Int64Sub(x, ChangeInt32ToInt64(y)) to use an extend register operand, removing the cast. Change-Id: Id130f8a9614e2c208f9ed8c17b923ee738fcb916 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857964Reviewed-by:
-
Vasili Skurydzin authored
Change-Id: Idabbd2b1326fcca04cd937a730c5418f9c9cf8af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855075Reviewed-by:
-
Junliang Yan authored
Change-Id: Ia3c703dc47744cffc3f86ec46abb341e6c37590c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857637Reviewed-by:
-
Maya Lekova authored
This reverts commit 4ff37d3a. Reason for revert: Fails with stress_incremental_marking - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20stress-incremental-marking/3049/blamelist Original change's description: > cppgc: Fix test IteratePointersFindsCalleeSavedRegisters > > call the compiler can clobber the tested register. Moving this tricky > part into a noninlinable lambda allows to reduce pressure from the > register allocator and thereby avoid such clobbering. > > Subtle: between the first inline assembly and the IteratePointers() > Change-Id: Ibeca8fa2f4fd54d07c2f585a4e876504a6a991b7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859843 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74280} Change-Id: Ib257e30273f382d19ec922e2fa3279c39e918cde No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859847 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74282}
-
Camillo Bruni authored
Selecting a single script from related events was not implemented. Change-Id: Id6dbe7f8eb235c5917e48a9ade7347404c114618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859943Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74281}
-
Anton Bikineev authored
call the compiler can clobber the tested register. Moving this tricky part into a noninlinable lambda allows to reduce pressure from the register allocator and thereby avoid such clobbering. Subtle: between the first inline assembly and the IteratePointers() Change-Id: Ibeca8fa2f4fd54d07c2f585a4e876504a6a991b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859843 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Milad Fa authored
This CL adds Power10 recognition to Linux, AIX as well as IBMi. Enabled features include: MODULO FPR_GPR_MOV SIMD LWSYNC ISELECT VSX Change-Id: Ifc337e6497a3efe9697bcf03063a2b94471f96e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855041Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Junliang Yan <junyan@redhat.com> Reviewed-by:
Vasili Skurydzin <vasili.skurydzin@ibm.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74279}
-
Dan Elphick authored
This is a reland of dbd5ae52 Less common configs were fixed in other CLs. Original change's description: > [build] Enable gn check for most of v8 > > Currently there are 32 gn check failures across v8 (not including > third_party). These are due to issues in cppgc and inspector, which are > not trivially resolveable, so for now 4 targets (+ third_party) are > being excluded from the checks. > > Bug: v8:7330 > Change-Id: I506abe8e452c26239262499fc1fe2a6347a4c84b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2851886 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74255} Bug: v8:7330 Change-Id: I82047cfa7f8213312158123885808c2a4ad02160 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859842 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Dan Elphick authored
Converts two deps to public_deps and adds a missing dependency. Bug: v8:7330 Change-Id: Ib83920bbd9886d8ebd2d4e531fde0d40c5e8cc33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857967Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#74277}
-
Benedikt Meurer authored
The "Restart frame" feature was implemented as part of LiveEdit and primarily used to support LiveEdit of active functions, but that was previously disabled as part of https://crrev.com/c/2846892 because it's too brittle and causes crashes when using seemingly unrelated features. The "Restart frame" feature was also available as a context menu item separately in the DevTools front-end, but that was also already removed as part of https://crrev.com/c/2854681 earlier. So all uses are gone now. This change works by marking Debugger.restartFrame as deprecated and having it respond with a ServerError all the time. It thus allows us to remove a whole bunch of machinery that was essentially just put in various places to support the restart_fp_ magic. In particular the debugger no longer needs any machine specific builtins now. Bug: chromium:1195927 Change-Id: I1153ba6b00e979620af57dd9f58aa1c035ec4484 Fixed: chromium:1203606 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854750Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Michael Lippautz authored
- Reset parent object and signal stack with nullptr sentinel - Adjust FATAL messaging - Fix dispatch for in-construction objects on stack Bug: v8:11709 Change-Id: I4da0f0f373699aa1fa09745231911c7056978a4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856837Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74275}
-
Georg Neis authored
Tbr: nicohartmann@chromium.org Change-Id: I88048691595dcd8df55082d57455c49f32a5fe31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857966Reviewed-by:
-
Junliang Yan authored
Root slots are full pointer size. Using tagged ptr loads will lead to errors on big endian platform. Change-Id: I477597fadee025b6fb060d67a83bee60290aeb14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857636 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Dan Elphick authored
This fixes the gn check errors for configs using v8_use_external_startup_data = false and v8_enable_vtunejit = true. Bug: v8:7330 Change-Id: If7eb48bbf339ba53646e4722c7c90d6e5857ff22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859162 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Dominik Inführ authored
We don't need to iterate all heap objects here since we are only interested in builtins. Bug: v8:11641 Change-Id: Ib5b959010ad82b6fe50991f85a93d165030bd804 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857962 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Wenyu Zhao authored
* Will bring them back after TPH supports collection. Bug: v8:11641 Change-Id: Ia170302ccaad9595663cf6bc618e725545a916e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2858294 Auto-Submit: Wenyu Zhao <wenyu.zhao@anu.edu.au> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Change-Id: I424e4de75cfd628d034033c99ce2a6e7b88c6a52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857958Reviewed-by:
-
Toon Verwaest authored
While evaluating a class literal the containing function points to Token::CLASS. It may have pushed a context for that class that uses the range of the class scope. So far the class scope had a range that started after the class name or class token in case of anonymous classes. That means the source position of the function frame doesn't point to a position that is included in the active context range. This breaks the debugger because it relies on being able to find the matching parser scope for the active context by looking at the source position. The fix is two-fold: - extend the class scope source range to include Token::CLASS - update ScopeChainRetriever::ContainsPosition to include the start position of class scopes as a valid source position. We can't always include start due to arrow functions that don't have braces. Bug: chromium:1156498 Change-Id: I9ec640c6326289dadcb154bb0a329ca6f8188f8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857957Reviewed-by:
-
Camillo Bruni authored
Bug: chromium:1201936 Change-Id: I1ee545e33587ddf4a5c7e1cbd64b53d36c75a146 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850936Reviewed-by:
-
