Commit 3d1254dc authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[build] Fix gn check errors for less common configs

This fixes the gn check errors for configs using
v8_use_external_startup_data = false and v8_enable_vtunejit = true.

Bug: v8:7330
Change-Id: If7eb48bbf339ba53646e4722c7c90d6e5857ff22
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859162
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Auto-Submit: Dan Elphick <delphick@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74272}
parent f98856e0
......@@ -1975,7 +1975,10 @@ action("v8_dump_build_config") {
v8_source_set("v8_snapshot") {
visibility = [ ":*" ] # Targets in this file can depend on this.
deps = []
deps = [
":v8_internal_headers",
":v8_libbase",
]
public_deps = [
# This should be public so downstream targets can declare the snapshot
# output file as their inputs.
......
......@@ -22,9 +22,7 @@ static_library("v8_vtune") {
"vtune-jit.h",
]
configs += [ ":vtune_ittapi" ]
deps = [
"../../..:v8",
]
deps = [ "../../..:v8" ]
}
static_library("v8_vtune_trace_mark") {
......@@ -33,16 +31,13 @@ static_library("v8_vtune_trace_mark") {
"vtuneapi.cc",
"vtuneapi.h",
]
deps = [
":ittnotify",
]
deps = [ ":ittnotify" ]
}
static_library("ittnotify") {
sources = [
"//third_party/ittapi/include/ittnotify.h",
"//third_party/ittapi/include/legacy/ittnotify.h",
"//third_party/ittapi/src/ittnotify/disable-warnings.h",
"//third_party/ittapi/src/ittnotify/ittnotify_config.h",
"//third_party/ittapi/src/ittnotify/ittnotify_static.c",
"//third_party/ittapi/src/ittnotify/ittnotify_static.h",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment