• Benedikt Meurer's avatar
    [debugger] Don't attach source positions to implicit returns. · 379331b7
    Benedikt Meurer authored
    Previously we'd attach source positions to implicit returns that are
    generated when leaving an async function with a promise rejection. This
    was due to the use of `kNoSourcePosition` on the `end_position` in the
    `ReturnStatement` nodes as indicator to pick the return position from
    the function literal, instead of really not putting a source position on
    that specific `Return` bytecode.
    
    This CL adds a dedicated marker to `ReturnStatement` to express that the
    `BytecodeGenerator` should put the return position from the function
    literal there instead of overloading the meaning of `kNoSourcePosition`.
    
    Bug: chromium:901819, chromium:782461
    Fixed: chromium:1199919, chromium:1201706
    Change-Id: I3647e0c3d711e9c3d6ae44606b70ec92ad82e1cf
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859945
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74301}
    379331b7
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...