- 25 Mar, 2020 7 commits
-
-
Ng Zhi An authored
Bug: v8:10347 Bug: chromium:1043034 Change-Id: I804ea511e3ed7c866e0202c97a22dcac007243e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2117325 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#66857}
-
Richard Townsend authored
MSVC 19.25 complains about signbit being ambiguous between signbit(float) and signbit(double) overloads when called with an int8_t. To remove the ambiguity, cast to a double. Change-Id: I698f05eed9248eef493bbe46b75fcd07e37e2a05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2118510Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#66856}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:10321 Change-Id: I318d46fa638c1d6f4d5d347e5aa0ad1faf02d5e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2120532 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66855}
-
Georg Neis authored
For some input types containing -0 but not +0, the result type of NumberMin and NumberMax would unnecessarily include +0. However, for some larger inputs, the result type would not include the spurious +0, thus breaking monotonicity. The CL fixes this and addresses a TODO as well. Bug: chromium:1063661 Change-Id: Icd56d6102fbea12a2d96aa063a803b1052c714b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116199 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#66854}
-
Dominik Inführ authored
Add LocalHandleScope to allow for local handles in LocalHeaps (background threads). This class is similar to HandleScope which still needs to be used on the main thread. When performing a GC, the main thread halts all background threads at a safepoint such that it can safely iterate their roots. Bug: v8:10315 Change-Id: Id8f5d54cc2535e004081ccdef15dc03a39b2d0f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2111218 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#66853}
-
Clemens Backes authored
A StepOver at a return (either explicit return instruction, or implicit return at the end of the function) should stop again in the caller frame. R=thibaudm@chromium.org Bug: v8:10321 Change-Id: I313e6b612ac52e73b33ef07c6da1ced2aa0db600 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2110250Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66852}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/26e9d48..de373bb Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/032c783..054d61d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2b2aec6..e3a49aa Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/105a846..a560ab4 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I04a2522f65cecb00308bdc0a8f7ed780fe4f3961 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2119950Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#66851}
-
- 24 Mar, 2020 14 commits
-
-
Clemens Backes authored
This fixes issues with replacing the return address of deeper (non-top) wasm frames, i.e. frames which are at a call position. The replaced address should also point after the call in the new code, so we don't execute the same call again. This is achieved by using slightly different encodings for breakpoint positions and other (wasm instruction) positions. Breakpoints set {is_instruction} to {false} in the source position table entry, whereas usual wasm instruction set it to {true}. Also, during stack walking for OSR, we remember whether we want to OSR to the position before the instruction (if it's the top frame), or after the call instruction (if it's deeper in the stack). We then use the {is_instruction} predicate to find the right location. R=thibaudm@chromium.org Bug: v8:10321 Change-Id: I73212a7532c6ecf4c82bde76fe4059c8203e422c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116206Reviewed-by: -
Michael Lippautz authored
As discussed offline, adding myself to OWNERS for the C++ GC, handles, and Blink embedding issues in general. Bug: chromium:1056170 Change-Id: Iff6a9f119000c04b40fb12b70f56d9bab7e32b43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116204Reviewed-by:
-
Ng Zhi An authored
Rework the testMemoryGrowReadWrite and testMemoryGrowZeroInitialSize tests. Combine the different sized tests (32, 16, 8 bit integers) into a single base tests, taking in function arguments to specify which load/store function to call from the module exports. Also reduced the number of checks made in each test. Previously the test was asserting on every single valid offset. Now it checks the first 5 and the last 5 of each page of memory. From a quick local test using `time`, it speeds up this test on x64 from ~40s to ~20s. There is more work to be done: there are other tests below that also assert on each offset, we can change those in a future patch. The goal is to be able to run this on arm simulators sufficiently quickly, and not require to mark this test as slow. Bug: v8:7783 Change-Id: I2b17cf1811de6c26332d7e8f91efbbac3e89f6e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116601Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#66848}
-
Michael Lippautz authored
GCInfo and its related infrastructure is used to record information about types. Currently, we store finalization and vtable information. Future changes will introduce naming and tracing, similar to Oilpan in Blink. Information is stored in a process-wide global table that is maintained at runtime. For static builds such information can be recorded in the binary without the runtime overhead which is future work. This ports `third_party/blink/renderer/platform/heap/gc_info.{h,cc}` on a semantic level. In addition to adjusting to V8's needs, we also re-commit the already filled parts of the info table as read-only when possible, making it harder to override type information. Bug: chromium:1056170 Change-Id: Ib01eb24e6f8a94a4a647efde7af37689f8c20ba2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2111214 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:Hannes Payer <hpayer@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Georg Neis authored
This DCHECK can fail because we currently pass arbitrary types in the typer unittests. Changing the tests is complicated by the fact that the compiler makes heavy use of type Any and we don't want to lose test coverage for that. Hence for now I just remove the DCHECK. I'm working on a follow-up CL but that one will not be able to land any time soon due to the current restrictions. Bug: v8:10338 Change-Id: Ibb3bb44e41b76cd91b190af184f6345cdf97d49d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116203 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: Id7859be3e28331a78dd548b445272cc645ce50d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116202Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port e5b4cb45 R=fanchen.kong@intel.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I2198b423aa22b41b1b55f4ba733d2c2c5c3fe1ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2117781 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#66844}
-
Zhao Jiazhong authored
Architecture judgement functions like ‘IsMipsArchVariant’, ‘IsFpxxMode’ used to be macro functions, which may cause ‘unreachable-code’ error if they are used as condition expressions for ‘if’ statements. This CL change them to constexpr functions to avoid it. Change-Id: Id3d8473920711a05abc39265c88e91cc1cb7d5e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2115833 Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
-
Clemens Backes authored
We have similar logic in place when allocating wasm memory fails. For growing, we also need to hard-abort the program, because it would cause observable differences in program behaviour otherwise. R=ahaas@chromium.org, machenbach@chromium.org Bug: chromium:1063951 Change-Id: I98f3b5364100900fce0e6553a347155a39923ca6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116036Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66842}
-
Hannes Payer authored
Bug: chromium:1056872 Change-Id: I68341f0320663796cd8487b66bb38d87c7ad8bd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2115435Reviewed-by:
-
Zhao Jiazhong authored
Port e5b4cb45 https://crrev.com/c/2108299 Change-Id: Iac7e70aaa13cd46be4aaec1bf52388071ce17ae9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2115835 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10281 Change-Id: Id6c004c60e3bf142c603d9e37f730348f89cd89d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2111221Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bf3f9ee..26e9d48 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/4164a30..7977eb1 Rolling v8/buildtools/linux64: git_revision:9499562d94bf142f43d03622492e67b217461f67..git_revision:5ed3c9cc67b090d5e311e4bd2aba072173e82db9 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/bf306f5..032c783 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/befc299..2b2aec6 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I1a1926717ab4fa2f358220270ff8623695baed67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2117391Reviewed-by:
-
Kong, Fanchen authored
Bug: v8:9909 Change-Id: Ia830b2fc00751abfb4dadb61651a252f1da48a1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2108299 Commit-Queue: Fanchen Kong <fanchen.kong@intel.com> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#66837}
-
- 23 Mar, 2020 19 commits
-
-
Camillo Bruni authored
This might help reduce flaky test results caused by too high memory consumption due to the large Float32Array in regress-crbug-1057653.js. Bug: v8:10333 Change-Id: Id99ebb67ebe5a7a730e44cd8967ebbea905ccdc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2108547Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#66836}
-
Igor Sheludko authored
... to make it work from any location. Bug: v8:10155 Change-Id: I4b949ed6fde0b38a92c1c1ab57eba0cf0f007b6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116034 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#66835}
-
Michael Lippautz authored
"By my deeds I honor him. V8." - Add basic build files for library and unittests. - Integrate unittests also in existing V8 unittests for simplicity. The CL also adds FinalizerTrait and unittests to allow building a testing target that executes code. FinalizerTrait is used to determine how managed C++ types are finalized. The trait should not be overridable by users but needs to be exposed on API-level to avoid including library-internal headers. Bug: chromium:1056170 Change-Id: I64d91053410a17a7835e50547f58990625d2da28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2108549Reviewed-by:
-
Clemens Backes authored
Before, it was specified between the globals and the exports section. This changed with https://github.com/WebAssembly/exception-handling/issues/98. The event section is now placed between the memory and the globals section. R=jkummerow@chromium.org CC=aheejin@chromium.org Bug: v8:10176 Change-Id: Icafeaae4ff7796273c73d61ed417c028fcbcb02d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116032Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66833}
-
Milad Farazmand authored
Change-Id: I7c4f06d53e7b58b902f929944c03dc7c65bf4abf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2115935Reviewed-by:
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10281 Change-Id: Ife66eef08ad3a578884b42d7171c04a3003ccee5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2111219Reviewed-by:
-
Thibaud Michaud authored
We previously could not OSR a frame paused in a breakpoint with another frame in which the same breakpoint was removed, because the latter was missing the source position. This change fixes this by iterating the stack to collect frame positions, and emitting the corresponding source positions in Liftoff. R=clemensb@chromium.org Bug: v8:10321,v8:10147 Change-Id: I5a7950d5ce6e3cd5a0648b861db75f4f3dafa644 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2115433 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
Close WasmCodeRefScope before we potentially free the native module in UpdateNativeModuleCache. R=clemensb@chromium.org Bug: chromium:1062868 Change-Id: I7cd11fd2283a2cc399d05e32c609ff1af07e2706 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2113380 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Ye Kuang authored
This is identical to these CLs we did to Chromium's mb.py * https://crrev.com/c/2105272 * https://crrev.com/c/2094482 Bug: chromium:1059167 Change-Id: Ibad4ed0d0655b8bf56a0e7fd672983eac5ac5d38 Reviewers: dpranke@chromium.org, tikuta@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2100697Reviewed-by:
-
Clemens Backes authored
The behaviour was clarified in the spec: https://github.com/WebAssembly/exception-handling/pull/97 br_on_exn (which was done in another CL) and also rethrow should trap on nullptr. This CL implements this by an explicit check in the builtin called for rethrow. R=jkummerow@chromium.org CC=aheejin@chromium.org Bug: v8:10128 Change-Id: Icb0f4e54991b3385917bf183efa825048db4cb82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2115430 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Clemens Backes authored
The behaviour was clarified in the spec: https://github.com/WebAssembly/exception-handling/pull/97 br_on_exn (and also rethrow, which will be added in another CL) should trap on nullptr. This CL implements this by an explicit check on each br_on_exn (within {GetExceptionTag}). This check will be redundant if several br_on_exn follow each other. Since also the runtime call for {GetExceptionTag} is redundant, and also the fact that we do a runtime call is suboptimal, I consider the whole implementation prototypical for now anyway. R=jkummerow@chromium.org CC=aheejin@chromium.org Bug: v8:10128 Change-Id: I234c3183f93fe0884aadd2ab6dbd6c2b7a07c660 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2113381 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Don't use deprecated HTML Imports, directly fetch the template files from html instead. Bug: v8:10155 Change-Id: Ic85a8b2cf227231fc6abf5adca6f1f144bf728f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2113371Reviewed-by:
-
Clemens Backes authored
The spec was changed such that traps are not catchable in wasm: https://github.com/WebAssembly/exception-handling/pull/93 This CL implements this in V8 by adding a private symbol as a property to all uncatchable exceptions. It also adds a number of tests. R=jkummerow@chromium.org CC=aheejin@chromium.org Bug: v8:10194 Change-Id: I498531762e8876f809d3b8aeb72ccc053e0e3cd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2113375 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Leszek Swirski authored
During off-thread space merge, we free the linear allocation area in the off-thread space. Since the off-thread space isn't marked, we have to make sure that we don't try to compensate for black allocated live bytes. Bug: chromium:1011762 Change-Id: Id2eb2212dc25e78952f817482abcdb4b49f3a373 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2111224Reviewed-by:
-
Georg Neis authored
Change-Id: I5a424f6349d2f71de1dccdcedb0d98d50c68fc98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2113379Reviewed-by:
-
Thibaud Michaud authored
Remove unused breakpoints as we hit them. OSR in this case does not work properly yet, because we are missing the source position for the removed breakpoint in the new code. R=clemensb@chromium.org Bug: v8:10321 Change-Id: I908546c1b37ca044166b24b4900126ab79f117ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2111216 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Eric Rannaud authored
On Linux, Perfetto translates the builtin "ts" timestamp in trace event from CLOCK_MONOTONIC to CLOCK_BOOTTIME, before passing them to devtools. Devtools therefore implicitly operates on timestamps that are in CLOCK_BOOTTIME. However, additional timestamps sent in trace event payload arguments will not be converted to CLOCK_BOOTTIME by Perfetto, raising the possibility of devtools using timestamps from multiple clock domains incorrectly. Since trace events sent by CpuProfile also include the builtin "ts" trace timestamp (sampled from CLOCK_MONOTONIC nearly at the same time by the tracing framework), sending "data.startTime" and "data.endTime" is essentially redundant. devtools-frontend:2113957 stops the use of the value of these timestamps in the payload of Profile and ProfileChunk events. Devtools continue to use the presence of these arguments to indentify start and end profile events. ProfileChunk events also include "timeDeltas" which are relative timestamps. They are also in CLOCK_MONOTONIC and are not translated by Perfetto. devtools-frontend:2113957 computes absolute CLOCK_BOOTTIME timestamps from timeDeltas by adding them to "ts" in the "Profile" event (previously, "data.startTime" was used). This is only valid if the system is not suspended/resumed during profiling. Providing support for suspend/resume in the middle of profiling will likely involve having Perfetto convert "timeDeltas" directly to CLOCK_BOOTTIME. This CL introduces no code changes and only adds comments to explain the above. BUG=chromium:1055871 Change-Id: I649dfcce8ea1a100c0ecfe03f843c7cb1fdd6f33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2114001 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#66820}
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10281 Change-Id: I2c49093585fbd6e9ba1fe777492188d64625dc92 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2111222 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b53200e..bf3f9ee Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/39af23e..bf306f5 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I2f928720575546690e7df15830ce53d27bba211d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2114656Reviewed-by:
-
