• Clemens Backes's avatar
    [wasm] Fix OSR on wasm calls · 851a395f
    Clemens Backes authored
    This fixes issues with replacing the return address of deeper (non-top)
    wasm frames, i.e. frames which are at a call position. The replaced
    address should also point after the call in the new code, so we don't
    execute the same call again.
    
    This is achieved by using slightly different encodings for breakpoint
    positions and other (wasm instruction) positions. Breakpoints set
    {is_instruction} to {false} in the source position table entry, whereas
    usual wasm instruction set it to {true}.
    Also, during stack walking for OSR, we remember whether we want to OSR
    to the position before the instruction (if it's the top frame), or after
    the call instruction (if it's deeper in the stack). We then use the
    {is_instruction} predicate to find the right location.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10321
    Change-Id: I73212a7532c6ecf4c82bde76fe4059c8203e422c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116206Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66850}
    851a395f
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...