Commit 499dcead authored by Georg Neis's avatar Georg Neis Committed by Commit Bot

[turbofan] Remove a DCHECK

This DCHECK can fail because we currently pass arbitrary types
in the typer unittests. Changing the tests is complicated by the
fact that the compiler makes heavy use of type Any and we don't want
to lose test coverage for that. Hence for now I just remove the DCHECK.

I'm working on a follow-up CL but that one will not be able to land any
time soon due to the current restrictions.

Bug: v8:10338
Change-Id: Ibb3bb44e41b76cd91b190af184f6345cdf97d49d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116203
Commit-Queue: Georg Neis <neis@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Auto-Submit: Georg Neis <neis@chromium.org>
Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66846}
parent 280bbb30
......@@ -1083,7 +1083,6 @@ Type Typer::Visitor::JSEqualTyper(Type lhs, Type rhs, Typer* t) {
// Types are equal and are inhabited only by a single semantic value,
// which is not nan due to the earlier check.
DCHECK(lhs.Is(rhs));
DCHECK(lhs.Is(Type::NonInternal()) || lhs.Is(Type::Hole()));
return t->singleton_true_;
}
return Type::Boolean();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment