- 17 Mar, 2021 40 commits
-
-
Ulan Degenbaev authored
Previously we needed to register the backing stores globally because the embedder could create them from a raw pointer. This is no longer possible after the removal of the old API. The global backing store registry now keeps track only of wasm memory backing stores. Bug: v8:9380 Change-Id: Iffefbf14dcafc1f9ce0dc3613335c754c9cb649a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763874Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#73493}
-
Milad Fa authored
Also added multiply low/high and vector merge instructions to the simulator. Change-Id: I889004b5572ee7df75be706c424ac2e83e53e8b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2769058 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73492}
-
Shu-yu Guo authored
Bug: chromium:1188868 Change-Id: If3916891806b7db7c4556f0dc50ae73afa06036c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2766223 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73491}
-
Clemens Backes authored
This tests the 'beforeScriptWithSourceMapExecution' mode of setInstrumentationBreakpoint for wasm. R=bmeurer@chromium.org Bug: chromium:1151211 Change-Id: I3020ab3e67e090407e2641a105c513e7614aa305 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764342 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#73490}
-
Ng Zhi An authored
These tests require --validate-asm, which is available only on WebAssembly enabled builds. This was causing problems on https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite/15320/overview. Moving them into regress/asm, the status file automatically skips these tests if WebAssembly is not enabled. Bug: v8:11238 Change-Id: Ib337fb6bd43319f61a33302efd4277c092935a9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767600 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73489}
-
Igor Sheludko authored
Bug: v8:11421 Change-Id: Ia4d3a20b9fdb5bc262cf480ece6e189aedff388f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762143 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73488}
-
Andreas Haas authored
The machine graph verifier did not handle kUnalignedLoad and kUnalignedStore yet, which caused problems with debug builds on arm. R=mvstanton@chromium.org Bug: v8:11384 Change-Id: I1a33c1e5993f9f0dd453a2d3f757e0eaff65b479 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756213Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73487}
-
Omer Katz authored
Sweeper cannot assume that platform never changes, so that we can support using testing-specific platforms. Instead, the sweeper gets the current platform from HeapBase on sweeping start. The platform is set to nullptr whenever sweeping is not active. Bug: chromium:1056170 Change-Id: I749e1dbfa204635fbb446a8c383aaa2548a717be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767139Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73486}
-
Camillo Bruni authored
- Fix link to older tool versions - Adapt card style to versions page NOTRY=true Change-Id: Id857cc1220605d9bf62e1b810bd46c5766633383 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767228 Commit-Queue: Patrick Thier <pthier@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#73485}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: If779c3c581317fb062c062a3ad60d1eebc1743d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767142Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73484}
-
Milad Fa authored
Change-Id: Ic4dff5209279f51ed75c76f2a0b159c727fb6164 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767198Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#73483}
-
Ng Zhi An authored
Bug: v8:11577 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ie83cb991bdd9f6dc680824fa313fafa198ad9ce7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767599 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Andreas Haas authored
The bulk-memory proposal and the reference types proposal have been merged into the main repository, so we don't have to run the proposal tests anymore. R=ecmziegler@chromium.org Change-Id: I14583b8c1c387075442a402458ce04e7c6071f89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752165 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#73481}
-
Thibaud Michaud authored
If the block is unreachable, the interface is not called and the {try_info} field is not set. Therefore, check it before accessing it. R=clemensb@chromium.org Bug: chromium:1188975 Change-Id: Ic6d7d2b7e26b0448143076e25a89c036216e8618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767017Reviewed-by: -
Thibaud Michaud authored
This completes support for encoding/decoding exception values of any type, and with that completes exception handling support in Liftoff. R=clemensb@chromium.org Bug: v8:11453 Change-Id: Ie70b16478061cb68f3165b96c3806503f9908b6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767141 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:11453 Change-Id: I0d02162e1a6974b550ec23ebb93c2478112a704d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767023 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Clemens Backes authored
The text representation of that opcode is "memory.grow", so the macro should also be called WASM_MEMORY_GROW. This is also consistent with WASM_MEMORY_SIZE. R=thibaudm@chromium.org Change-Id: Ibda328e52418d04392856820d3099f2dadaaf98f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764466Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73477}
-
Igor Sheludko authored
This is a speed-for-memory tradeoff, which can be achieved by re-mapping the builtins code blob into existing code range. This CL handles cases where both embedded and un-embedded off-heap builtins' PCs might appear on the call stack. The v8_enable_short_builtin_calls build flag is still disabled. Bug: v8:11527, v8:11421 Change-Id: Ie3db6eb8e264854df42b936a97d3e73d01de5dfd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2749636 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#73476}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:11453 Change-Id: I3aada28f3cb9839b2d5fc7e85f5fe87018d17d1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767022 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Victor Costan authored
One of the x86 ISA extensions is confusingly named SSSE3 (*Supplemental* Streaming SIMD Extensions 3). SSSE3 supersedes SSE3, and is superseded by SSE4. This CL adds testing coverage for x86 CPUs that support SSE3 instructions, but do not support SSSE3 instructions. Chrome supports these CPUs, and they are used by a non-trivial amount of Chrome's users on Windows. This CL aims to cover all the spots missed by https://crrev.com/c/2757893. Change-Id: I83fc963b977b285898ffe12304443ad67db68d1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764820 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73474}
-
Manos Koukoutos authored
This will enable more optimizations in later compilation stages. Bug: v8:11510 Change-Id: Ia4125f564014432a356c7889c862f6cd767f9db5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764756 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:11453 Change-Id: Ia8521b1707b083e3e674801481081bfc16a8b5c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764757 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Michael Lippautz authored
This is a reland of d76064df Original change's description: > cppgc: Rework GC info creation > > Previously, GCInfoTrait relied on the non-trivial constructor of a > static object for registering a new GCInfo object. The generated code > is required to be thread-safe which is achieved by introducing guard > variables in the compiler. > > The new version is similar to Blink in that it relies on zero > initialization of a trivially constructible atomic. > > Compared to guard variables that are created per GCInfo registration, > the atomic creates less bloat (~20bytes/type) and also results in a > better fast path. > > Minimum example: https://godbolt.org/z/qrdTf8 > > Bug: chromium:1056170 > Change-Id: I95efbbf035b655d0440c9477f5391e310e2b71fa > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764750 > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73463} Bug: chromium:1056170 Change-Id: I01e60beabc1d279d352361657f408f113aac768e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767021 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73471}
-
Santiago Aboy Solanes authored
We have it readily available at all call-sites. There is no need to request it via GetIsolate on the function itself. Change-Id: I4936177c47c8adf9dfeafe1e320f8411ae358a5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2761200Reviewed-by:
-
Jakob Kummerow authored
When dropping the exception from the stack, we have to take locals into account when computing the right stack slot. Fixed: chromium:1187836 Change-Id: I76acb1e4dc50992524123cc369dea8e51242164c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764749 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:11510 Change-Id: I1e8fcb54444e494c7d765ad556d09d954441361f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752876 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... introduced in https://chromium-review.googlesource.com/c/v8/v8/+/2727502 Bug: v8:11527, v8:11421 Change-Id: I97d8711ad946789f8a39de5fcca41e77f20cde79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767019Reviewed-by:
-
Maya Lekova authored
This reverts commit d76064df. Reason for revert: Breaking MSAN - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/37390/overview Original change's description: > cppgc: Rework GC info creation > > Previously, GCInfoTrait relied on the non-trivial constructor of a > static object for registering a new GCInfo object. The generated code > is required to be thread-safe which is achieved by introducing guard > variables in the compiler. > > The new version is similar to Blink in that it relies on zero > initialization of a trivially constructible atomic. > > Compared to guard variables that are created per GCInfo registration, > the atomic creates less bloat (~20bytes/type) and also results in a > better fast path. > > Minimum example: https://godbolt.org/z/qrdTf8 > > Bug: chromium:1056170 > Change-Id: I95efbbf035b655d0440c9477f5391e310e2b71fa > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764750 > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73463} Bug: chromium:1056170 Change-Id: I71960103513d6db7789d752b70727d014c2e6406 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767020 Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I3ef480e34fa005add44c927e82b50ec31581e632 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759517Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73465}
-
Andreas Haas authored
The original CL was reverted because PC authentication was missing for the `caller_pc` in the stack walk. This caused a crash on the CFI bot. PS1 is the original CL, later patch sets contain the fix. Original Message: [wasm] Emit safepoint info for callee-saved registers in the deopt-index Encode safepoint info of callee-saved registers in the deopt index of the normal safepoint. R=clemensb@chromium.org, jkummerow@chromium.org Change-Id: I633cd715eccc697e888cd381e3bda1a47d0d0851 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759520Reviewed-by:
-
Michael Lippautz authored
Previously, GCInfoTrait relied on the non-trivial constructor of a static object for registering a new GCInfo object. The generated code is required to be thread-safe which is achieved by introducing guard variables in the compiler. The new version is similar to Blink in that it relies on zero initialization of a trivially constructible atomic. Compared to guard variables that are created per GCInfo registration, the atomic creates less bloat (~20bytes/type) and also results in a better fast path. Minimum example: https://godbolt.org/z/qrdTf8 Bug: chromium:1056170 Change-Id: I95efbbf035b655d0440c9477f5391e310e2b71fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764750Reviewed-by:
-
Omer Katz authored
Copy over from Blink two tests that the library was missing. Bug: chromium:1056170 Change-Id: If4349e8c4dc0036f4894d274e5d38e63b0390c4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764751 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Changes: - Remove the restriction that ref.test, ref.cast and br_on_cast may only cast to subtypes of the cast object's type. Optimize unrelated type casts in the decoder. Add tests. - Generalize Unreachable() interface function to Trap(TrapReason). - Fix rtt.sub to be able to accept an rtt without depth. Modify related test accordingly. - Type local.tee according to the local's type as opposed to the value's type. Bug: v8:7748, v8:11541 Change-Id: I4d1846a2cfda891d32a9c1ed26781e4518d4cdf9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756210Reviewed-by:
-
Santiago Aboy Solanes authored
We can ensure that the constructor is set before the map is set on the JSObject. Setting the constructor remains non-atomic. Bug: v8:7790 Change-Id: Ie65519f61e29c9bed89bf09f582aa8bd39de1b03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2761199Reviewed-by:
-
Camillo Bruni authored
- Sort by labels if no category is selected - Support page separators in simple txt files. - Fix un-toggling subcategories - Prompt for labels when loading multiple files - Improve parsing performance by using raw for-loops and fixing regexps Change-Id: Ibd388e4134b4c0722a7f44d7eb4c5c56748e5175 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2759511 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Igor Sheludko authored
This is a speed-for-memory tradeoff, which can be achieved by re-mapping the builtins code blob into existing code range. The feature can be enabled by v8_enable_short_builtin_calls flag and it's off by default. This CL adds GN flag and updates code generator to emit shorter pc-relative calls/jumps to builtins. However, the runtime doesn't support appearance of the off-heap builtins' PCs that point to the embedded code blob on the stack yet. Bug: v8:11527, v8:11421 Change-Id: Iaba384c549675852beae70739175976ee193ffef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727502Reviewed-by:
-
Liu Yu authored
Port: 3f9ff062 Bug: v8:11238 Change-Id: I3ac454b7ea1addbbf41407c7acd6a18da7b35d10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763965 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
-
Dominik Inführ authored
Since unboxed doubles are removed already, MigrateFastToSlow doesn't need to invalidate old-to-old-slots anymore. Bug: chromium:1188483 Change-Id: I0875fc0c8bcf8086f22678ffbbef000fd94ea7ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764745Reviewed-by:
-
Jakob Gruber authored
.. which was previously broken due to 1. a hardcoded impl names list and 2. the addition of a new impl (riscv). The new solution prevents this in the future by basing both enum and name generation on a macro list. Bug: v8:11572 Change-Id: Ieb2134c9ecf3729633b76e4a30e7ddceba396328 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764752 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Nico Hartmann authored
This reverts commit 220e68c0. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1188563 Original change's description: > [TurboFan] Move FunctionTemplateInfo to never serialized > > This CL moves FunctionTemplateInfo to the list of never serialized > objects, allowing direct heap reads. To make this threadsafe, the CL: > - adds necessary atomic (relaxed/acquire-release) operations to the > accessors of FunctionTemplateInfo. > - changes FunctionTemplateInfoRef::LookupHolderOfExpectedType to be > usable from the background thread (e.g. no handle construction) with > the caveat of skipping optimization in some cases where necessary > JSObjects are not serialized. > > Drive-by: Add missing serialization of objects possibly reachable > through CallHandlerInfo::data. > > Bug: v8:7790 > Change-Id: I49cf4f328ecfab368dff9076fde8f5783ead3246 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2679687 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73364} TBR=neis@chromium.org No-Try: true No-Presubmit: true No-Tree-Checks: true Bug: v8:7790 Change-Id: I66fd8d915e2434e3f78103b9e11dce01eb356675 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764753Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#73454}
-
