Commit 644b7306 authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

Add test coverage for x86 processors with SSE3 but not SSSE3 support.

One of the x86 ISA extensions is confusingly named SSSE3 (*Supplemental*
Streaming SIMD Extensions 3). SSSE3 supersedes SSE3, and is superseded
by SSE4.

This CL adds testing coverage for x86 CPUs that support SSE3
instructions, but do not support SSSE3 instructions. Chrome supports
these CPUs, and they are used by a non-trivial amount of Chrome's users
on Windows. This CL aims to cover all the spots missed by
https://crrev.com/c/2757893.

Change-Id: I83fc963b977b285898ffe12304443ad67db68d1f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764820
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73474}
parent 80d52966
......@@ -827,6 +827,17 @@
'suffix': 'nosse3',
'test_args': ['--extra-flags', '--noenable-sse3 --noenable-ssse3 --noenable-sse4-1 --noenable-avx']
},
# Nossse3.
{
'name': 'mozilla',
'suffix': 'nossse3',
'test_args': ['--extra-flags', '--noenable-ssse3 --noenable-sse4-1 --noenable-avx']
},
{
'name': 'v8testing',
'suffix': 'nossse3',
'test_args': ['--extra-flags', '--noenable-ssse3 --noenable-sse4-1 --noenable-avx']
},
# Nosse4.
{
'name': 'mozilla',
......@@ -920,6 +931,24 @@
'test_args': ['--extra-flags', '--noenable-sse3 --noenable-ssse3 --noenable-sse4-1 --noenable-avx'],
'shards': 3
},
# Nossse3.
{
'name': 'mozilla',
'suffix': 'nossse3',
'test_args': ['--extra-flags', '--noenable-ssse3 --noenable-sse4-1 --noenable-avx']
},
{
'name': 'test262',
'suffix': 'nossse3',
'variant': 'default',
'test_args': ['--extra-flags', '--noenable-ssse3 --noenable-sse4-1 --noenable-avx']
},
{
'name': 'v8testing',
'suffix': 'nossse3',
'test_args': ['--extra-flags', '--noenable-ssse3 --noenable-sse4-1 --noenable-avx'],
'shards': 3
},
# Nosse4.
{
'name': 'mozilla',
......
......@@ -93,6 +93,7 @@ INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = {
"--enable-armv8": ["--no-enable-armv8"],
"--gc-interval=*": ["--gc-interval=*"],
"--no-enable-sse3": ["--enable-sse3"],
"--no-enable-ssse3": ["--enable-ssse3"],
"--no-enable-sse4-1": ["--enable-sse4-1"],
"--optimize-for-size": ["--max-semi-space-size=*"],
"--stress_concurrent_allocation": ["--single-threaded-gc", "--predictable"],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment