• Maya Lekova's avatar
    Revert "cppgc: Rework GC info creation" · 8b9d0138
    Maya Lekova authored
    This reverts commit d76064df.
    
    Reason for revert: Breaking MSAN - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/37390/overview
    
    Original change's description:
    > cppgc: Rework GC info creation
    >
    > Previously, GCInfoTrait relied on the non-trivial constructor of a
    > static object for registering a new GCInfo object. The generated code
    > is required to be thread-safe which is achieved by introducing guard
    > variables in the compiler.
    >
    > The new version is similar to Blink in that it relies on zero
    > initialization of a trivially constructible atomic.
    >
    > Compared to guard variables that are created per GCInfo registration,
    > the atomic creates less bloat (~20bytes/type) and also results in a
    > better fast path.
    >
    > Minimum example: https://godbolt.org/z/qrdTf8
    >
    > Bug: chromium:1056170
    > Change-Id: I95efbbf035b655d0440c9477f5391e310e2b71fa
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764750
    > Reviewed-by: Omer Katz <omerkatz@chromium.org>
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#73463}
    
    Bug: chromium:1056170
    Change-Id: I71960103513d6db7789d752b70727d014c2e6406
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767020
    Auto-Submit: Maya Lekova <mslekova@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#73466}
    8b9d0138
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...