- 02 Feb, 2021 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/dce1147..dc9dc45 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/9904915..fc5af1a Rolling v8/third_party/aemu-linux-x64: Y_rckHsnBv6dqNUbG4QoVkl3njqEx7ewCNGmqOE_h1MC.._nJMIPzu-ykpL-XPjf14IZ3CAFT3iQRtsbzyiSm9u7QC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/91735e2..4920147 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cb07c52..8c95595 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c876c8f..bf44340 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/9290907..ec98581 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic364444072e5b2405dc05d3cce7133585cce84c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2666713Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#72469}
-
Michael Lippautz authored
- Allow downcasting construciton and assignment; - Add WeakCrossThreadPersistent::Lock() that safely retrieves a strong handle for a weak reference; Bug: chromium:1056170 Change-Id: I5f8d85a87c9955506dd87723ffb4c80d66770c04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2663160 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#72468}
-
- 01 Feb, 2021 17 commits
-
-
Milad Fa authored
Port 6d3a53e7 Original Commit Message: This is a reland of commit 9c09c227. The fix for gc stress failure is merged: https://crrev.com/c/2656857. Original change's description: > Bug: v8:11331 > Change-Id: Ie394ec841a1a1c4030c4f589eac2cee8a6a2a1f9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2639033 > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72304} R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I68991b81c18e06714d272f019dab7994419692bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2665894Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#72467}
-
Junliang Yan authored
Port 07b03b83 Original Commit Message: c_entry_fp is normally cleared in `LeaveExitFrame`, but we adjust the frame without it in the exception path. This can cause the SafeStackFrameIterator to assume we have an exit frame and iterate over frames incorrectly, which for arm64 can cause pointer authentication failures with CFI enabled. Even without the pointer authentication failure, we iterate over frames incorrectly, so make this change for other architectures too. Also clear c_entry_fp in the beginning of JSEntry, after pushing it on the stack. Not doing this doesn't cause pointer authentication failures, but it will make the SafeStackFrameIterator assume we are executing C++ and miss the JS frames on top. R=georgia.kouveli@arm.com, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com, mfarazma@redhat.com BUG= LOG=N Change-Id: Id12286a0f18fce928f9e44825fc13cd0338bac46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2665893Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#72466}
-
Ng Zhi An authored
This is a reland of commit 9c09c227. The fix for gc stress failure is merged: https://crrev.com/c/2656857. Original change's description: > Bug: v8:11331 > Change-Id: Ie394ec841a1a1c4030c4f589eac2cee8a6a2a1f9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2639033 > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72304} Bug: v8:11331 Change-Id: I82f57b3fe5f0c456472aa7ce404703f34b73d17e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659511Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72465}
-
Ng Zhi An authored
Bug: v8:10975 Change-Id: Icfc5982c96132ef3eaa4d8b9dc2b8229d87ab15e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659509Reviewed-by:
-
Ng Zhi An authored
Change them to wasm-linkage.h. Bug: v8:11074 Change-Id: Ic29cdd85b3d20cf384952aacc7ca82236e3bf276 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659502Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72463}
-
Daniel Clark authored
The DCHECK is firing because the fuzzer doesn't set any HostImportModuleDynamically callback. Previously RunHostImportModuleDynamicallyCallback would not assert for this and would just return a rejected promise. After https://chromium-review.googlesource.com/c/v8/v8/+/2620578, this results in a failed DCHECK. This change restores the old behavior by loosening the DCHECK such that it only fails if both the deprecated and the new callback are set. Bug: chromium:1172121 Change-Id: Ifda28eb28572a40d3752928997edf25d607b61c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659505Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#72462}
-
Georg Neis authored
Make the crash_on_error parameter false by default, so that the typical use is easier to read: Use GetOrCreateData(obj) if you expect the object to be known already. Use TryGetOrCreateData(obj) if you don't. Bug: v8:7790 Change-Id: I5732ad13ec582c2a1112032f88be54c833906a6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2658327 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#72461}
-
Clemens Backes authored
Minor cleanup before starting to refactor the debug side table. R=thibaudm@chromium.org Bug: chromium:1172299 Change-Id: I507cb297e66954488194a346aac31664a34a20f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659260Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72460}
-
Liviu Rau authored
Used for testing infra change https://crrev.com/c/2650208 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Bug: chromium:1144601 Change-Id: I93ea610c45d3cbc9557f9a13e2ccc74927720384 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659256 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#72459}
-
Georgia Kouveli authored
c_entry_fp is normally cleared in `LeaveExitFrame`, but we adjust the frame without it in the exception path. This can cause the SafeStackFrameIterator to assume we have an exit frame and iterate over frames incorrectly, which for arm64 can cause pointer authentication failures with CFI enabled. Even without the pointer authentication failure, we iterate over frames incorrectly, so make this change for other architectures too. Also clear c_entry_fp in the beginning of JSEntry, after pushing it on the stack. Not doing this doesn't cause pointer authentication failures, but it will make the SafeStackFrameIterator assume we are executing C++ and miss the JS frames on top. Bug: v8:10026 Change-Id: Ie94834920f51e9f1cc5c1c775596726b61fc0507 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2642256Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/master@{#72458}
-
Ulan Degenbaev authored
The flags are enabled by default and have stable coverage. This also removes the corresponding bots. Bug: v8:10315 Change-Id: Icce01383050dff758b6554db8e0c3589d6e5459c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2658324 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Peter Wong authored
- Removed no longer used StringBuiltinAssembler methods (DispatchOnStringEncodings, PointerToStringDataAtIndex) - Removed no longer used Runtime functions (StringIncludes, StringIndexOf, StringIndexOfUnchecked). - Overall builtin code size is reduced (652 bytes on Mac x64.release build), builtin size breakdown: BEFORE ====== TFS Builtin, StringIndexOf, 1092 TFJ Builtin, StringPrototypeIncludes, 1784 TFJ Builtin, StringPrototypeIndexOf, 1536 Total = 4412 AFTER ===== TFC Builtin, StringIndexOf, 2036 (+944) TFJ Builtin, StringPrototypeIncludes, 1072 (-712) TFJ Builtin, StringPrototypeIndexOf, 652 (-884) Total = 3760 (-652) Bug: v8:8996 Change-Id: I9a88c095e2097f7d570e58e744d6692dc524ddf4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2660995 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
-
Manos Koukoutos authored
Changes: - Remove an obsolete TODO from wasm-module-builder. - Replace CHECK with gTest's EXPECT in unittests. - Remove setting of --experimental-wasm-liftoff-extern-ref in wasm-gc. - Test test-gc/JSAccess with Liftoff. - Remove useless #undef's from module-decoder-unittest. Change-Id: I11b4a3dde9683cc9c7d1eb89b1a63e1859505aad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659063 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72455}
-
Shu-yu Guo authored
Bug: v8:9548 Change-Id: I92b8c3b305f0e18557fb6628c42c668faf694bd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659512 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Iain Ireland authored
RegExpParser::ParseRegExpSyntax was added to allow the SpiderMonkey embedding of irregexp to report early errors. It was removed in https://chromium-review.googlesource.com/c/v8/v8/+/2509596 because it was unused. This patch restores it, with a comment to prevent future deletion. Bug: v8:11368 Change-Id: Iebec7e14b92e9a0fccc08f2f1c85d8ff4d6173f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2658037Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I56a5e0a3e3141ef781a816656dc50d0d0a1573cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659258 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7a702b2..dce1147 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia57ea2e2a6b9ad9e89136ac4b1509b45fb54a44d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2662502Reviewed-by:
-
- 31 Jan, 2021 2 commits
-
-
Manos Koukoutos authored
br_on_* instructions need a precisely typed branch target, as opposed to being treated like regular br instructions. Bug: v8:7748 Change-Id: Iedace79faf59d61cf2ce5ac88e633e07b5a2a43f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655507 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/568bd76..7a702b2 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4a6400cfa7e2b7ae8737fd263ed01b877d1ead45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2661901Reviewed-by:
-
- 30 Jan, 2021 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c083992..568bd76 Rolling v8/third_party/aemu-linux-x64: 2AjFHxe4t1iSrrSx8ayS9uaUpVgbf4uevQoAj-Pt5_0C..Y_rckHsnBv6dqNUbG4QoVkl3njqEx7ewCNGmqOE_h1MC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9d5ec46..91735e2 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/558a304..cb07c52 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/f097906..f4147b2 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/2c183c9..c876c8f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/cc8d00a..9290907 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9be1ce5e4cd16c80304d60694429ad74cff0ddc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2660942Reviewed-by:
-
Bill Budge authored
This reverts commit 352b9ecb. Reason for revert: fuzzers turned up more problems: https://bugs.chromium.org/p/chromium/issues/detail?id=1171759 https://bugs.chromium.org/p/chromium/issues/detail?id=1171846 tbr=ahaas@chromium.org,neis@chromium.org Original change's description: > Reland "Reland "[compiler][wasm] Align Frame slots to value size"" > > This is a reland of 1694925c > > Minor fix to linkage for constexpr. > > TBR=ahaas@chromium.org,neis@chromium.org > > Original change's description: > > Reland "[compiler][wasm] Align Frame slots to value size" > > > > This is a reland of cddaf66c > > > > Original change's description: > > > [compiler][wasm] Align Frame slots to value size > > > > > > - Adds an AlignedSlotAllocator class and tests, to unify slot > > > allocation. This attempts to use alignment holes for smaller > > > values. > > > - Reworks Frame to use the new allocator for stack slots. > > > - Reworks LinkageAllocator to use the new allocator for stack > > > slots and for ARMv7 FP register aliasing. > > > - Fixes the RegisterAllocator to align spill slots. > > > - Fixes InstructionSelector to align spill slots. > > > > > > Bug: v8:9198 > > > > > > Change-Id: Ida148db428be89ef95de748ec5fc0e7b0358f523 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512840 > > > Commit-Queue: Bill Budge <bbudge@chromium.org> > > > Reviewed-by: Georg Neis <neis@chromium.org> > > > Reviewed-by: Andreas Haas <ahaas@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#71644} > > > > Bug: v8:9198 > > Change-Id: Ib91fa6746370c38496706341e12d05c7bf999389 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2633390 > > Commit-Queue: Bill Budge <bbudge@chromium.org> > > Reviewed-by: Andreas Haas <ahaas@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#72195} > > Bug: v8:9198 > Change-Id: I91e02b823af8ec925dacf075388fb22e3eeb3384 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2640890 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72209} TBR=bbudge@chromium.org,neis@chromium.org,ahaas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9198 Change-Id: Ifee566e3e82f2e774525996b038ce135190d0be1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2660378 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#72447}
-
- 29 Jan, 2021 17 commits
-
-
Milad Fa authored
kNumberOfSavedGpParamRegs is based on the number of registers defined under Generate_WasmCompileLazy within the builtins and not the list under wasm-linkage.h. More information can be found within the comments of this CL: https://crrev.com/c/2656857 Change-Id: I9d2122545120c95b7686c98eb838ab25ea376bf1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659756 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
-
Daniel Clark authored
Hosts are not supposed to rely on the ordering of import assertions list received from V8. Thus, as a simplification, remove the sorting of the import assertions passed to the HostImportModuleDynamically callback. Update the corresponding test so that it doesn't require any particular ordering of assertions. Import asssertions for static imports will continue to be sorted. These need to have a consistent ordering for purposes of deduplication in SourceTextModuleDescriptor::module_requests_, so removing sorting of these wouldn't simplify much. Bug: v8:10958 Change-Id: I2cb07c4e68f24fa45152bf3f4321938bf94d84ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653170Reviewed-by:
-
Ng Zhi An authored
We have macro lists defined for these SSE instructions, use them for disassembly. Bug: v8:11074 Change-Id: Ide714ba488913a95078573db70d34a4f5d61ef9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2648186Reviewed-by:
-
Ng Zhi An authored
We don't need separate Load32Zero and Load64Zero instructions, since the implementation is LdrS and LdrD, which we already have. Bug: v8:11038 Change-Id: I784ec8dc419c0d59de97eb2bb0b464c176dacae1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2501969 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: I343ad420a2fcbabf6493d657cd93c1b40d76fd3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2644547Reviewed-by:
-
Adam Klein authored
Bug: v8:11353 Change-Id: Iba5b6a2740a5fca55c5f4cee53367fb6413ba3d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659635Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#72441}
-
Deepti Gandluri authored
Bug:V8:11074 Change-Id: I843fcc2b48aa9303396c8d192d15c75e2f763d2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2657971 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Ng Zhi An authored
In https://crrev.com/c/2645694 we push the full q registers before lazy compile, but we did not change the fixed frame size to account for the wider registers being pushed. This manifested in the frame having data like: (gdb) x/10xg start.ptr_ 0x7f5576ff3eb0: 0x0000000000000000 0x0000336b08202759 0x7f5576ff3ec0: 0x7ff000007f801000 0x0000000000000000 0x7f5576ff3ed0: 0x7ff000007f801001 0x0000000000000000 0x7f5576ff3ee0: 0x7ff000007f801002 0x0000000000000000 0x7f5576ff3ef0: 0x7ff000007f801003 0x0000000000000000 The GC then walks part of this frame, thinking that 0x7ff000007f801003 is a heap object, and then crashes. Add some static_asserts (similar to builtins-x64) to remind ourselves that the pushed registers have to match the size in frame constants. Bug: chromium:1161555,v8:11358 Change-Id: Ic5138cc17ad44ccab9121ca226f9f812afef72c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2656857Reviewed-by:
-
Ng Zhi An authored
Bug: v8:11074 Change-Id: I21926f3c8f640d26b9e067569455b49211321148 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2658075Reviewed-by:
-
Clemens Backes authored
Even though we sped up the test since the first landing of the CL, it still sometimes times out on TSan. Since TSan coverage is not needed for this test, just skip it. R=adamk@chromium.org Bug: v8:11369 Change-Id: I7825d1824ad34fccc313459a115b38eae1d5b553 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659262 Commit-Queue: Adam Klein <adamk@chromium.org> Auto-Submit: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#72437}
-
Daniel Clark authored
Advance v8::Isolate::CreateParams::supported_import_assertions from V8_DEPRECATE_SOON to V8_DEPRECATED now that Blink has stopped setting it. Bug: v8:10958 Change-Id: I502f08c0c2e424f3afae3a6cb11835376a847bcb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2656936Reviewed-by:
-
Clemens Backes authored
This adds a regression test for https://crrev.com/c/2652488. The test reduces the available code space such that it would trigger an OOM condition if code is not garbage-collected. In order to guarantee garbage-collection in all configurations, an explicit interrupt check is added to the WasmDebugBreak runtime function. R=thibaudm@chromium.org Bug: chromium:1168564 Change-Id: I8fce7aa5128c9e3c9a7e2d2e7397c394fec7de85 Cq-Include-Trybots: luci.v8.try:v8_linux64_asan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_mac64_asan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2652490 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
The latest wasm-gc spec introduces classification functions {ref.as, ref.is, br_on}_{func, data, i31}, to cast values typed as anyref and eqref. Bug: v8:7748 Change-Id: I39c288e4a4c96466e64e490f164ccc76b00011ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655506 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: -
Andreas Haas authored
... LiftoffStackSlots::Construct R=thibaudm@chromium.org Bug: chromium:1171788 Change-Id: Ifb8e20f4e81fe2c698fe1f51c0b833a6049f7558 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659255Reviewed-by:
-
Mike Stanton authored
Actual FeedbackVector IC slots don't participate in the Ref class, since they are read during serialization as we process bytecode. So FeedbackVectorRef really only deals with the FeedbackCell array and the SharedFunctionInfo. These two types are already in the no serialized list, so it's pretty easy to move this class over there too. Bug: v8:7790 Change-Id: I51b7bf4c3404ae5bcfb16d29b5e719787ddd6b17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2656317 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Clemens Backes authored
We were doing the cache lookup using the original {wire_bytes_vec}, but then inserting the module with another copy stored in the {NativeModule}. This causes {NativeModuleCache::Key::operator<} to do a full {memcmp} on the two wire bytes copies. By using the same pointer consistently, we can avoid that costly {memcmp}. R=thibaudm@chromium.org Bug: v8:11164 Change-Id: I19ba1022f700d8da40671818ee2e2ebdbbddd5c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2658329Reviewed-by: -
Michael Lippautz authored
Adds getters for GC phases to be used by advanced embedders to ensure and check consistency conditions as needed. Bug: chromium:1056170 Change-Id: Ia0b219f838bf31f0edbfe40585b95bb5eafa734d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2658328Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
