• Junliang Yan's avatar
    PPC/s390: [builtins] Clear c_entry_fp when entering JS and at exception path · 9fd2c27f
    Junliang Yan authored
    Port 07b03b83
    
    Original Commit Message:
    
        c_entry_fp is normally cleared in `LeaveExitFrame`, but we adjust
        the frame without it in the exception path.
    
        This can cause the SafeStackFrameIterator to assume we have an exit
        frame and iterate over frames incorrectly, which for arm64 can
        cause pointer authentication failures with CFI enabled. Even without
        the pointer authentication failure, we iterate over frames
    incorrectly,
        so make this change for other architectures too.
    
        Also clear c_entry_fp in the beginning of JSEntry, after pushing it
        on the stack. Not doing this doesn't cause pointer authentication
        failures, but it will make the SafeStackFrameIterator assume we
        are executing C++ and miss the JS frames on top.
    
    R=georgia.kouveli@arm.com, joransiu@ca.ibm.com, junyan@redhat.com,
    midawson@redhat.com, mfarazma@redhat.com
    BUG=
    LOG=N
    
    Change-Id: Id12286a0f18fce928f9e44825fc13cd0338bac46
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2665893Reviewed-by: 's avatarMilad Fa <mfarazma@redhat.com>
    Commit-Queue: Junliang Yan <junyan@redhat.com>
    Cr-Commit-Position: refs/heads/master@{#72466}
    9fd2c27f
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...