- 13 Sep, 2021 16 commits
-
-
Benedikt Meurer authored
This unblocks https://crrev.com/c/3099011 by speeding up the case for the DebugPropertyIterator where only non-indexed properties (for large arrays or typed arrays) are requested. Previously we'd walk through all properties - including all indexed properties - and only filter out the indexed properties in the end in `ValueMirror::getProperties()`. Bug: chromium:1199701, chromium:1162229 Change-Id: I2555e3129fef29da347314eee400ea97ebf5e5b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3114135 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#76796}
-
Michael Lippautz authored
The refactoring is triggered by https://crrev.com/c/3121905 where we noticed that a bunch of tricky counter paths could be simplified, making reasoning about corectness easier. In this CL: 1. Use uniqe_ptr instead of Optional to allow moving SweepingJob away from the header file. 2. sweeping_in_progress_ is replaced with simply checking for a job. 3. freed_bytes_ are moved to the job and the dependency is reversed, avoiding the inside-out (Job->Sweeper) dependency completely. 4. Merge() and counter updates are merged into a Finalize() method. 5. FinishIfDone() allows for conditional finization. 6. young_bytes_ and old_bytes_ are removed as they were always updated when the corresponding bytes in the ArrayBufferList was updated. Change-Id: I56e5b04087166ce03d3a9195ac48359122a84c73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124776Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#76795}
-
Lu Yahan authored
In riscv64, pc-relatice call need meet IsInt32(offset + 0x800), so max pcrelatice code range is 4094MB. Change-Id: Id3481483eb3131b5c08f22bde08206ee30cc25db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3156585 Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by:
Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#76794}
-
Jakob Kummerow authored
No asymptotic improvements, and none are planned either. Minor speedups (25-50%) through reduced overhead: accessing Digits is faster than working with Handle<BigInt>, and this implementation avoids allocating intermediate results. Bug: v8:11515 Change-Id: I2aab2b1c5c9cbb910800161b8514c497daf2b587 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149453Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#76793}
-
Manos Koukoutos authored
Bug: v8:12166 Change-Id: I4e9322ff5289cc76b4434b200f9369d9231e5bc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3145416 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#76792}
-
Thibaud Michaud authored
The "unreachable" state is usually reset in the first catch block. Ensure that this is done for catchless tries too. R=clemensb@chromium.org Bug: chromium:1246712 Change-Id: If746a3fe3158b0bac4b9b02e4978ca444f8ce427 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3157949Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76791}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:12108 Change-Id: Iad128d108df64a5a0c205f7ed69a06cdffb40c31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148133Reviewed-by:
-
Marja Hölttä authored
The bug was introduced in https://chromium-review.googlesource.com/c/v8/v8/+/3147910 : We only want the fast path when "start" is either missing or the number 0, not when it's something which converts to 0. Bug: chromium:1248704 Change-Id: I72bb8fa8a9b90a13aae216c6a8e16e7be54285fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3157948 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#76789}
-
Darshan Sen authored
Signed-off-by:
Darshan Sen <raisinten@gmail.com> Change-Id: I51650e87261c817d6a58a34d56920b6fb8c1e281 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3112985Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76788}
-
Manos Koukoutos authored
Bug: v8:12166 Change-Id: If77ecea8102e4ba5d98d3e1e6700e9c1efaa319a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3144913 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Andreas Haas authored
This reverts commit 91b72485. Reason for revert: Some spec tests are failing, see WPT tests. Original change's description: > [wasm] Ship Reference Types > > R=ecmziegler@chromium.org > > Bug: v8:7581 > Change-Id: I9acd99f3cf6832ee393d839cde7444a475a8f808 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123409 > Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76565} Bug: v8:7581 Change-Id: I18ed821ffda51cdc9869e0e36666c816d0bf00df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141576 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/main@{#76786}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: I0e7db9ca74b9d61f2e86581b0cd2f424ad006db9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151958Reviewed-by:
-
Lu Yahan authored
Change-Id: Ieeb5888efc068707766aef6ba6fc842c5deaaf9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3146673 Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/1bd8098..400ed3f Added support of packaged GTest for running unit tests. (#1226) (Vitaly Zaitsev) https://chromium.googlesource.com/external/github.com/google/benchmark/+/400ed3f TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: If97861f0a44893f81754d21dcc7f8d3c3f207ef2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3157436Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#76783}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fafbd9b..38820a5 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I7212e63e5cd185c06578633a347d39c7947b9e04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3157433Reviewed-by:
-
Lu Yahan authored
Bug: v8:12211 Change-Id: Ib12b2327bcbb93ef2556ce32a43a8b5749bbdd39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3153835 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by:
-
- 12 Sep, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/af371a9..fafbd9b Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/17de752..a5b6419 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/50911df..7a4741c TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I2bff5fac27fef407cdb8625684cba5b0d7e2046c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3156376Reviewed-by:
-
- 11 Sep, 2021 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0c04087..af371a9 Rolling v8/third_party/aemu-linux-x64: vFeMtD7pamorE14xM1EkyVug7KRVEPRc7i89yT2sdaYC.._MqlabIiZ-51x79A36MyMSHmpsXJ6kjMY-4BqteuKPoC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8141144..50911df Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e1482c5..8f09549 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/664e425..e74330f TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I5d8cd20c120559a87c60e5a8bac3fafb451846f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3156362Reviewed-by:
-
Frank Tang authored
see https://github.com/tc39/test262/pull/3173 Bug: v8:12167 Change-Id: I49bed6bf361dbc216a5174be16d747fe2b104208 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152714Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#76778}
-
- 10 Sep, 2021 18 commits
-
-
Ng Zhi An authored
This is a follow-up on https://crrev.com/c/3131374 to support more instructions, float32 sqrt, cmp, round, float64 cmp. Rename the opcodes since they are no longer SSE specific. Bug: v8:12148 Change-Id: Ie5f74bc1b4510092cbfbcb7e420ef82cb1c39a14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3154983Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76777}
-
Junliang Yan authored
Change-Id: I1935a1ce50fcfb5f33511502367df624cc50a9df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3155382Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76776}
-
Ng Zhi An authored
In https://crrev.com/c/3131374 we switched some instructions to use macro-assembler functions which can handle AVX and SSE. However for Cvtsi2ss and Cvtsi2sd, the behavior subtly changed. The old behavior directly called cvtsi2ss/cvtsi2sd in the code-generator. The new behavior used the macro-assembler functions, which xor the dst operand. This led to more instructions and larger code size in some benchmarks. The xor is supposed to help reduce dependence chain length (see comments on Cvtsi2ss), but doesn't seem to have helped in this benchmark. So, partially revert the changes, and rename all affected IA32 opcodes back to SSE. Bug: chromium:1248509 Change-Id: Ie700e2980fe9ed083c1160bda3a28f64e1e43041 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3154349 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I05bcba3ad27b46b7c7888940895605ad463fc960 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3155302Reviewed-by:
-
Junliang Yan authored
Change-Id: Iea662aa79bf6d8fc7f8951482b6dfc0bcf30d081 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151964Reviewed-by:
-
Ng Zhi An authored
Move some AVX_OP into shared macro-assembler, for reuse by ia32 in future patches. Movlhps is also unused in x64, so remove it. Drive-by cleanup to use macro assembler helper Move to move 128-bit const into a XMMRegister. The change in liftoff-assembler-x64 is required because now the macro-assembler functions are defined in the base class, so even though we can use &TurboAssembler::Pcmpeqd to refer to that member function, it actually resolves to &SharedTurboAssembler::Pcmpeqd. Bug: v8:11589 Change-Id: Ie8f6a4dfd95b41192936f6e6be48c683042acec4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3150138Reviewed-by:
-
Clemens Backes authored
The {CountClearHalfWords} method is called whenever loading a constant into a register. It showed up with >0.5% in Liftoff compilation profiles. This CL refactors the method to return the number of *set* halfwords instead of *cleared* halfwords and avoids the loop in the implementation. This makes the method roughly twice as fast, and makes the code more readable. R=zhin@chromium.org Bug: v8:11879 Change-Id: I7da8160b3c045e5fc1e97fc0e575083b3920cb5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151962Reviewed-by:Zhi An Ng <zhin@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76771}
-
Clemens Backes authored
If background threads are tiering up, they could temporarily make code writable (if using the mprotect based approach). This would make our death tests fail (i.e. not crash). This CL fixes that by repeatedly writing in that case. Eventually, the code should be protected again, and then we would crash. Failure to crash would manifest as a timeout of the tests. R=jkummerow@chromium.org CC=mpdenton@chromium.org Bug: v8:11974 Change-Id: Ibe34af499da9b964ad260d58e9b4e390007898e9 Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151959 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Ng Zhi An authored
We already have some logic to try to get a reasonable name for the function when logging code. It looks up the name custom section, and falls back to the function index. Extract this into a helper, and call it when disassembly the code. Bug: v8:12098 Change-Id: Ieebe6594bc3184fa655f878faa0cb67c248d7f56 Fixed: v8:12098 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3125355Reviewed-by:
-
Junliang Yan authored
Change-Id: I1efa3969ee07deca1dfa33f730f46a1067c12d73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152753Reviewed-by:
-
Junliang Yan authored
Change-Id: Ie9c8cf6475532df979c96df62254af32de6cf98f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152748Reviewed-by:
-
Milad Fa authored
StackCheck needs to be implemented on liftoff. Change-Id: I29624d65b82cbba3ef640ab7ea0cc78c2d5f2c4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152745Reviewed-by:
-
Clemens Backes authored
In the case that {dst}, {lhs} and {rhs} all point to the same register, we would emit wrong code (negating the register and adding it to itself). This CL fixes this by checking if {lhs == rhs}, and just clearing the {dst} register in that case. R=thibaudm@chromium.org Bug: chromium:1247659 Change-Id: I7913617850adb34a5ad812369f16a7422358454d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151955Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76765}
-
Marja Hölttä authored
Removing code left over by https://chromium-review.googlesource.com/c/v8/v8/+/3124806 . Bug: v8:7790 Change-Id: Id198df521ff58fe4f476f6f6a1fc624cb297be4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147591Reviewed-by:
-
Clemens Backes authored
With statically in-bounds memory accesses (implemented in https://crrev.com/c/2919827) we would only have an offset but no index register for {TraceMemoryOperation}. This CL fixes that situation. R=thibaudm@chromium.org Bug: chromium:1248024 Change-Id: I856b263a560cb71791c61e446e78dd99c9664190 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149464Reviewed-by:
-
Liu Yu authored
Change-Id: I1148508825b7bdff3dae0634aed5318a605ba4da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3153355Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#76762}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/17d097b..0c04087 Rolling v8/third_party/aemu-linux-x64: QewYN5289B8deg5Mn6clWEv58UqpocHGKeob2F0T87kC..vFeMtD7pamorE14xM1EkyVug7KRVEPRc7i89yT2sdaYC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2331f08..8141144 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7285666..e1482c5 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/ece15d0..3f44383 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/47226fa..20795c9 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I8f1144a9514c8e27c41701dee8380c6d9859db50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152860Reviewed-by:
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/50f3fca..66a3c3aa Bug: v8:7834, v8:12209 Change-Id: I74a5fd1b781c8280a68f47276e578e5c703876b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152710Reviewed-by:
-
- 09 Sep, 2021 3 commits
-
-
Ng Zhi An authored
We have a macro list defined, and already use it in other places, use it to disassemble the AVX instructions too. Bug: v8:11879 Change-Id: Id1a5bdc167d3f17d603aa2e43e1ac80ef4b1fdb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3150139Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76759}
-
Milad Fa authored
value must be written to memory in LE order on BE machines as they will be loaded in reverse when emitting S128Const. Change-Id: Ia1d6c784505abe499fb71a6d86daea2721615da4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151956Reviewed-by:
-
Ng Zhi An authored
With these accessors we can remove Assembler as a friend class. Drive-by cleanup to change DCHECK(!x || y) to DCHECK_IMPLIES(x, y). Change-Id: I74b7a23e85b50db93bbfe84fdfcc8563527f14d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3144374Reviewed-by:
-
